phpBB

fix for bug #5586

rather large update, most important things done:
- implemented provided patch/diff file for bug #5350 (Highway of Life) with some tiny changes and alterations
- more username/colour changes/fixes
- added a note about PM rule-dependant message removals so the user is not wondering too much if he can’t remember his rules. :)
- some column changes to fix unicode issues
- bugfixes

- fixing a bunch of bugs
- moved the install trigger error to sessions and also disabled it for those having DEBUG_EXTRA enabled.
i hope not having introduced too many new bugs.

consistant obtain_* functions

ok, i am an idiot…

- implemented the suggested html_entity_decode function made by david
- fixed string length checking by also decoding entities for the sake of checking
- used the new html_entity_decode function

- Handle upper/lower case in memberlist properly [Bug #5012]

- introducing clean usernames, needs to be tested more, I’m not sure I didn’t miss anything
- homograph list should probably be extended

tried to begin adjusting all string functions where applicable – still a lot to do.
i hope i catched all relevant sections and did not mess something up.

- no more encoding mixture, say hello to UTF-8 (I’ll add a validation solution for PHP 4.3.3/4 ASAP) [side effect: fixes Bug #3762]
- take local server time into consideration for birthday/age calculation
- faster active topic search
- allow changing active topic time frame [Bug #4150]
- reload stylesheet on language change [Bug #4222]

- birthdays/age in user’s timezone and not server’s local time
- parse bbcode in posts with fewer characters than selected maximum on search results page
- retrieve search word context in posts which are longer than maximum characters (no raw BBCode anymore)
- formatted text is processed in the same order everywhere now: censor_text, replace newlines, bbcode, smileys, attachments, highlighting [including Bug #2048]
- highlighting pattern updated to exclude style and script (e.g custom BBCode) [Bug #3856]
- fixed a style problem in Opera [Bug #3770]
- performance increase for user::img()
- slight adjustments to search

sql_in_set changes

- fixed some bugs
- made imageset naming more consistent
- updated every schema to be consistent and also fixed it (every db should install fine now)
-

- fixed the age calculation (note: turn on your brain before commiting something like this the next time) [Bug #3337]
- removed the split_words array, introduced an enforced search_query
- the forum used for global topics in the search is now a forum, and no longer a category [Bug #2561]
- Bug #3404
- allow accessing reports by report_id, in contrast to mcp_queue this cannot just use the post id, since there can be multiple closed reports per post, so closed reports have to be accessed by report id, open reports, can optionally be accessed by report id or post id [Bug #3149]
- only attempt to unflag reported topics on closing a report when there are any without other reported posts [Bug #3057]
- updated fulltext_mysql to use the the search_query string
- overwrote the old fulltext_native with our improved version since it consumes too much time to maintain boths and we would switch to the improved version later anyway
- always show a link to search a user’s posts even if the postcount is zero since he might only have posted in forums which do not count posts [Bug #3267]

hmm… This commit does not increase the number of BBCodes. However, this does other things that we need to do first. This splits the usage of allow_* from the BBCode bitfield in forum descriptions, forum rules and group descriptions. This also fixes a tiny, tiny severe issue that nobody found :D I hope it works :P

- renamed the following columns:
comment -> attach_comment
new, forwarded, unread, marked, deleted -> pm_new, pm_forwarded, pm_unread, pm_marked, pm_deleted
module_name -> module_basename
value -> lang_value

- every column is now NOT NULL
- every column is now having a DEFAULT value
- hopefully mostly consistent across every db schema
- untested schemas: sqlite, oracle, firebird

- display age in user profile and make it available on viewtopic
- various tiny bugfixes including [Bug #2351] [Bug #2549] [Bug #2681] [Bug #3015]
- strip first, then change newlines [Bug #2403]
- added support for creating user profiles to the login function (makes use of user_add), triggered by LOGIN_SUCCESS_CREATE_PROFILE constant
- moved newest user updating from ucp_register to user_add function
- renamed the admin_ auth module function to acp_
- added initialisation code to auth_apache which checks whether it will work
- added user_add support to both auth_ldap and auth_apache
- some auth_ldap tweaks, should work with users deeper in the organisation structure too now
- adjusted global topics in mcp_report to work like mcp_queue

- add additional auth check to the permission roles modules
- added new function to return globally used expressions (get_preg_expression($mode)). This should be very helpful in getting wide spread similar checks (regular expressions) to one place reducing the risk of forgetting to change every location if you fix one. ;) We will add additional ones later, at the moment only the email check is retrieved…
- added “active module” var to the module class returning the current active module
- changed call to image magick
- add administrator to global moderators group by default
- extend auth_option column a little bit
- other bugfixes

time to squash some bugs

fix bugs #2271 and #2273

- forgot to commit common.php
- cleaning up a few more mcp permissions
- adjust some links
- make global topics work properly in MCP

ok, this one is rather large… the most important change:
re-introduce append_sid: old style continues to work, not a performance hog as it was in 2.0.x -> structure is different

apart from this, code cleanage, bug fixing, etc.

- added search by author_id to solve problems with looking up posts of users with a name containing wildcards
- user based flood control (seperate limits for users and guests) [Bug #1357]
- inform the user about ignored words if he receives a “no words specified” message
- solve problems with the number of entries per page [Bug #1973]
- different height for popup window [“Bug” #1814]
- speed improvements for posting and search reindexing in fulltext_native
-> use php files for ignore words and synonyms

- fixed a few smaller things

- fixing a few tiny bugs
- added new function to (re)apply sids where needed (login and mcp quickmod) – #1829

This is a screwy world! Screwy I tell you!

- introduce new function build_url to easily build a valid url from the user->page object as well as optionally removing certain keys
- changed attachment config to utilize the config build methods
- cleaned up posting.php
- the submit/delete_post functions are now usable (functions_posting.php)
- adjusted header icons (transparency)
- a bunch of fixes for mssql
- bug fixes

- introduce LA_, UA_ and A_ template variables (they allow styles to use template variables used for javascript in subSilver outside javascript in their own template while they won’t break our javascript if they contain quotes) also fixes [Bug #1116]
- corrected page title for search indexing progress bar [Bug #1695]
- correct poster name for the anonymous user in mcp_queue and mcp_reports

- some adjustements for phpdocumentor

- Bug #1257

- clean up marklist calls (global function)
- added new feature: test out others permissions (admin permissions will not be copied)
- changed attachment processing by directly using the template engine
- fixed some attachment related bugs
- additional tiny fixes

To all people having their bug status set to fixed: SF pserver CVS access is currently down, therefore the snapshots are still out of date.

- fix a bunch of bugs
- <!- $Id$ -> is no longer allowed in template (.html) files
- changed layout of private message screens (folders are menu items)
- removed unread mode for private messages
- added new feature to template engine – “jump out of loop” or “loop another loop within my loop” :D (will be documented within the coding guidelines)
- added autologin field to sessions
- check session length checks
- added add_log statement to sessions to track session valid to invalid changes if ip/browser change depending on config settings (only debug)
- added multibyte support for various variables (exception at the moment is usernames which needs some discussion)
- hopefully not broke something. :/

- extended session_page and user_lastpage to hold a maximum of 200 chars (instead of 100) – session_page gets truncated to 200 chars
- streamlined the process of generating text with bbcode/smilies/urls (forum rules, forum descriptions, group descriptions at the moment)
- a bunch of schema changes for the bbcode-enabled text and the session page change (sorry for this)
- if decode_message is used there is no need to include functions_posting.php anymore (should fix the search.php bug too)

added some language strings as well as fixing the activity listing (Yawner, could you please test it again at area51?)

- some bugfixes
- committed coding guidelines as they are at area51
- removed script_path (needs a close inspection later)
- removed the need for server_name and server_port
- able to define server port/name/protocol and force the user-defined server vars (very handy for proxy setups)

Changed url target method for BBcode help links and fixed undefined index bug

- overhauled search system
– updated structure for search backend plugins
– better result caching using ACM
– search results no longer session restricted => link to them by copying the URL :)
– in-topic search
– indexing posts now uses search backend plugins
– develop/search_fill.php working again
– fulltext_mysql not working yet
- tiny bugfixes to ACM

- sperate permissions from sessions
- added some comments to the auth class for better understanding
- revised some permission functions
- added option to negate permission check by prefixing option with a ! (for example checking for !f_read returns true if user is not able to read forum)
- used the new option for testing in ucp front

Changed ONLINE_STATUS flag to S_ONLINE for consistancy

Added rank_image_src template variable so it can be used with CSS. Also fixed some undeclared variables.

poster_id does not exist (anonymous should be not present too)

A few minor bug fixes to the view profile page

- session changes

- add ability to limit search to groups

- some fixes here and there

- first try to break things…

- fix serious bug (not updating topic/post count), i do not know why this slipped through and no one noticed… :) Maybe only i, lately i was performing very badly, had a few flaws, need to update myself to a stable version…

- removed unnecessary pm options
- added one option to clearly define email visibility

Fix profile msn contact link

- only small fixes to the memberlist

- re-enable polls (user is now able to decide if users are able to change votes if this feature is enabled within the given forum)

widdle

- removing karma

- fork/copy topic
- resync topics
- possible to show only reported posts in topic_view
- view reports in post details
- mcp_queue (show unapproved items)

- remove output buffering options from download.php (not needed anymore)
- optimized viewtopic.php a little bit
- removed the create_function (was consuming too much memory) from viewtopic
- check for manually added convert[.exe] program name to imagemagick path in admin_attachments
- reduced filesize checking for imagemagick program (some installations require less than 20k)
- added checked=”checked” for “not selected” topic icon
- moved parse_text_display function from functions_posting.php to functions.php (see comment above function)
- check for user_id != ANONYMOUS in page_footer for displaying the administration link (there seems to be a problem checking for global options)
- rewrote attachment thumbnail functions – utilize GD2 functions if available, more uptodate checks…
- changed final thumbnail size calculation
- define S_ROW_COUNT within template class itself
- added SID to template vars in page_header
- added ability to view topic/forum within admin_viewlogs
- added optional acl checking to make_jumpbox, no need to duplicate the function for this small need
- added custom body file for confirm_box

only display those forums the user is able to read in.

- put consoring and smilie processing into functions (we use them all over the place) for better changing and consistency.
- changed docs/AUTHORS to reflect the recent code re-use in functions_messenger.php
- pleasing the users a little bit more by using table constants. :D
- login box if “mode” is not allowed -> posting (thought about trigger_error integration, but we do not need this that often).

Update for new karma image location/creation

Updated the various “users of emailer”, fixed issue(!) of jabber using the email address as the uid, blah fixes, blah, blah di blah yakety smackety

Add “Add Friend” to viewprofile

hhmm

Various bits and pieces … this isn’t really what I wanted M-2 to look like but hum ho

Missing sprintf

A few minor updates

Incorrect avatar dimensions

Avatar preferencial display here too

page header/footer become functions, forum passwords (I know, I know but it appears a popular feature for some reason … inclusion not yet set in concrete nor complete), various bug fixes (and no doubt new bugs).