phpBB

Some changes… non-invasive…

Cleaning up (#13689)
Also removed the useless login box from the ACP.

a bunch of fixes

some fixes

ok, mess around with the templates + fixing some bugs + adjusting headers for those files already modified to circumvent conflicts for those having their editor set to remove trailing spaces (not recommended!)

“Ghost” topics in active topics list when shadow topics and corresponding topic in same resultset [#10313]
Find a member supporting hidden groups for those able to see them [#10305]
Display hidden groups for all those able to see them across the board (composing messages, viewonline)
Fix space for sending PM’s to groups
Let the permissions_phpbb file be included the same way as all other permission files [#10301]
Add request_a-z+ handling within modules_auth suggested by Pyramide. This will allow modders to directly show/hide their module in addition to !empty() $_REQUEST variables. [#10297]

- viewtopic/forum search boxes should also use search config option and u_search permission [Bug #9850]
- mcp_reports was still using some of the mcp_queue post_id logic, changed enough to report_id logic to make it work properly now. I hope I didn’t miss any external places referring to mcp_reports which send it a post_id_list. I really wonder whether people don’t test the MCP at all? Good that I noticed this myself when fixing an incorrect language string (No reports selected) message [Bug #9741]
- forgot to check in the changed mcp/info file for mcp_warn with global m_warn option
- mcp_post.html was missing a submit button for changing the poster in prosilver [Bug #9771]
- language variables in javascript in templates should use LA_ not L_ for proper escaping of single quotes

apply correct check for hiding session

for the time being, completely revert back to the old method – which may be slower for very very large boards… the previous code had severe bugs – to fix them properly would introduce even more queries which would slow down the complete viewforum page again.

Small thing that buggd me for years – adding the folder_img alt text as a variable for viewforum

do not display passworded forum topics within the active topics list if the user did not enter the password before… thanks to gamer4ever for pointing this out (though next time straight to the security tracker please)

fixing some bugs i introduced while fixing other bugs. :)

minor bugfixing

rather large update, most important things done:
- implemented provided patch/diff file for bug #5350 (Highway of Life) with some tiny changes and alterations
- more username/colour changes/fixes
- added a note about PM rule-dependant message removals so the user is not wondering too much if he can’t remember his rules. :)
- some column changes to fix unicode issues
- bugfixes

ok, change from doing the same logic all over again we call a function to do it for us. Also allow template designers to choose which method to use by just adding a fully compiled username string (profile link + user colour). This commit may introduce problems.

consistant obtain_* functions

Censor last post topic [#4714]

this change may introduce yet another query (not if store_reverse is used internally most of the time), but i hardly noticable on small forums. This change scales very very better than the old method. With the old one viewforum became slower and slower the more topics were present. For me the difference for a forum with 100.000 topics were 0.4 seconds (local server) – for others the speed increase should be noticeably higher.

Next phase of last post changes + a few minor bugs

Note: This template variable is available but will not be used by default

- some bugfixes
- using E_USER_WARNING if an error occurred within the ACP (sadly not able to use it as a default for trigger_error – it seems to be hardcoded in PHP)

Initial batch of colourization changes. This includes:
– schema changes for first post and last post
– display in viewforum, search and ucp of first post
– update of database on posting
Still outstanding
– display of last post

- load tracking updates. Need to be tested on a clean installation too – at the moment only tiny quirks are noticed at area51.
- reported bugs fixed

- fixing some bugs
- shortening some db columns to meet the requirements
- correctly increase/decrease user post counts
- fix the topic title length bug(s)

Some changes to the way folder images are handled for “special” topics

Fix the ability to report/view reports and warn in global announcements

ok, this one is rather large… the most important change:
re-introduce append_sid: old style continues to work, not a performance hog as it was in 2.0.x -> structure is different

apart from this, code cleanage, bug fixing, etc.

- fixing a few smaller bugs/glitches
- init user session in cron.php (else it can produce errors if functions expect the user object being set)
- fix sql escaping for mssql/mssql_odbc

- fixed dotted topics on some occassions being wrong
- fixed post author change
- fixed moving topics (they should not count into read tracking now) – think about having only one column for shadow topics/similar to forum links
- moved a function from functions.php to functions_display.php (this function is only used by viewtopic and viewforum which already include this file)
- some rather tiny fixes for mssql

- removed group settings from roles
- added forum icon in front of forums in permissions acp
- added trace permissions in permission masks (thanks naderman for writing the first code and for the idea… :))
- some bugfixes
- PHP6 fix

To all people having their bug status set to fixed: SF pserver CVS access is currently down, therefore the snapshots are still out of date.

- fix a bunch of bugs
- <!- $Id$ -> is no longer allowed in template (.html) files
- changed layout of private message screens (folders are menu items)
- removed unread mode for private messages
- added new feature to template engine – “jump out of loop” or “loop another loop within my loop” :D (will be documented within the coding guidelines)
- added autologin field to sessions
- check session length checks
- added add_log statement to sessions to track session valid to invalid changes if ip/browser change depending on config settings (only debug)
- added multibyte support for various variables (exception at the moment is usernames which needs some discussion)
- hopefully not broke something. :/

- some adjustments for search related config options
- one year is 365 days long (52 * 7 = 364, but we have one more day each year ;)) [Bug #1181]
fixed search own posts link in UCP [Bug #1163]
- corrections to timezone selection [Bug #1148]
- fix quickmod tools on post details page [Bug #1188]

- some bugfixes
- committed coding guidelines as they are at area51
- removed script_path (needs a close inspection later)
- removed the need for server_name and server_port
- able to define server port/name/protocol and force the user-defined server vars (very handy for proxy setups)

- moved add_log out of functions_admin (this file should only be included in admin/admin-related pages)
- fixed cookie based topic tracking
- added missing config variables
- other minor things

Bug Spray!
- No longer asks a user to login to a passworded forum even though his auth is not high enough, it just rejects the user now.

- some SQL:2003 changes (basicly joins, mysql5 is sql:2003 compliant in strict mode now) – postgresql not supporting this standard. :/
- acp changes

- updated topic tracking code
- additional changes (mostly bugfixes)
- bart, if you update your user table with the user_lastmark field, set it to the user_lastvisit value ;)
- and last but not least, introducing some bugs in ucp main front (regarding topic tracking)

- some cross-db related changes
- putting active bots array into cache

- made path information available to template (T_)
- eased topic/post icon in templates (removing hardcoded img)
- added S_FIRST_ROW and S_LAST_ROW to template engine

- Documentation related changes
- added resend activation email dialog
- fixed issue in session code
- log failed/successful admin re-authentication/login
- fixed simple forum dropdown box (used in mcp and posting)

- sticky bug fix

...see if i am able to break the cookie tracking system this time. :D
- made some session code updates
- added new acl function (might be helpful later)

- search updates

- load_moderators taken into account at index.php
- added S_UNREAD_TOPIC to viewforum
- changed S_UNREAD to S_UNREAD_POST in viewtopic

Danger Wil Robinson Danger! Paul is commiting files! Danger

- approve/disapprove posts/topics
- changed mcp_front to be more moderator friendly
- able to change the forum in mcp_queue (for moderators moderating more than one forum)

- remove output buffering options from download.php (not needed anymore)
- optimized viewtopic.php a little bit
- removed the create_function (was consuming too much memory) from viewtopic
- check for manually added convert[.exe] program name to imagemagick path in admin_attachments
- reduced filesize checking for imagemagick program (some installations require less than 20k)
- added checked=”checked” for “not selected” topic icon
- moved parse_text_display function from functions_posting.php to functions.php (see comment above function)
- check for user_id != ANONYMOUS in page_footer for displaying the administration link (there seems to be a problem checking for global options)
- rewrote attachment thumbnail functions – utilize GD2 functions if available, more uptodate checks…
- changed final thumbnail size calculation
- define S_ROW_COUNT within template class itself
- added SID to template vars in page_header
- added ability to view topic/forum within admin_viewlogs
- added optional acl checking to make_jumpbox, no need to duplicate the function for this small need
- added custom body file for confirm_box

- added folder_moved image
- new feature: bookmark topics
- fixed post details link
- added confirmation screen to cookie deletion

- forum rules + link to forum rules
- three new (tiny) functions added to functions_posting responsible for handling text with bbcode/smilies/urls, use them at items all over across phpbb…
- some bugfixes within admin_forums and other files
- new admin_board layout (much safer, security wise)

fix some issues with oop, fixing small bugs and prepare the next steps…
NOTE TO DEVS: have a look at adm/admin_board.php (new config layout)

- put consoring and smilie processing into functions (we use them all over the place) for better changing and consistency.
- changed docs/AUTHORS to reflect the recent code re-use in functions_messenger.php
- pleasing the users a little bit more by using table constants. :D
- login box if “mode” is not allowed -> posting (thought about trigger_error integration, but we do not need this that often).

Mark given set of forums marked, show “Mark forums read” link on subforum display

new permissions, merged attachment tables (the intended purpose of two tables is no longer valid), attachment updates along the merging…

Note: please merge your attachment tables (develop dir).

login prompt upon notified about new topic
enabled prune_viewed at auto_prune.

Change in format of module db data, add zebra, many things probably “damaged goods” for now … don’t panic Mr. Mainwaring, don’t panic

Fixed: invalid start value will not cause the whole table to be returned ;)

Added: fetch posts the other way (see forum)

Various bits and pieces … this isn’t really what I wanted M-2 to look like but hum ho

Wrong icon for global announcements

Global announcements … sort of work … well they seem to, need to look at possbility of splitting topics table in two

Mostly read tracking (re-)fixes … it works again … I’ll try not to break it a second time … other changes for Firebird compatibility

more fun with cookies

Various updates, changed jump to first unread as per Ashe’s suggestion/request ... hope people don’t start linking to it making me regret reverting to this implementation :D Moved many decisions on what icons to output to templates … feedback wrt any performance impacts happily accepted.

More functions added …

Changed forum_link_track to forum_flags for storage of additional info [ pruning related ], moved lang selection into DB, other minor changes, still working on admin_prune, per forum styling for posting

hhmm, sort of explains the weird post count behaviour of recent days …

Various updates, forum links, “improve” forum management, cleanups, blah blah, note the schema changes, note also that forum management may misbehave … reports on wrong doings are welcome … seem to be having problems with some mcp functions under apache/win32