View | Annotate | Download (27.1 KB)
Cleanup
Rewrote this stuff so that it is all multiple object oriented instead of looping single objects… The way it is written, there should be no speed decrease (and in some places, a speed increase) and maybe a miniscule amount of extra memory used in the move_topics function… Everything in there should be O(n) where n is the number of topics or posts being delete or moved or whatever. Multiple topic insertions are not supported as I cannot forsee where one would like to insert multiple topics into the same forum. Different forums I can understand but there is no way to optimize that at all. More work to come…
ok… i hope i haven’t messed too much with the code and everything is still working.Changes:- Ascraeus now uses constants for the phpbb root path and the php extension. This ensures more security for external applications and modifications (no more overwriting of root path and extension possible through insecure mods and register globals enabled) as well as no more globalizing needed.- A second change implemented here is an additional short-hand-notation for append_sid(). It is allowed to omit the root path and extension now (for example calling append_sid(‘memberlist’)) – in this case the root path and extension get added automatically. The hook is called after these are added.
Some enhancements to the posting api, replaced the bitfield with two int fields… This represents what the new system could be…
merge some changes/fixeshenry: is your viewonline fix/change missing? ;)
Some fixes
Some neat stuff, the new DBAL function has the potential of removing somewhere in the ballpark of 40% of all the DBAL code. It combines a few very common idioms into one statement, allowing us to implicitly use prepared statements. Short term advantages are the ability to remove the gross code that attempts to work around DB2, Oracle and Firebird. Long term advantages include removing the burden of sanitizing data (at least on input) from our end and placing it on shoulders of the backend PHP driver.
Also included is a new posting API I am working on. It is not a real API in so much as it is a backend that a “nice” API could use. User submitted functions are welcome :) It represents a massive simplification in post and topic accounting and a generalization of concepts like “soft deletion” as it works across both topics and posts (yes, this has preliminary support for soft deletions). The only “interesting” problem left is global topics, this has yet to be solved.
Enough talk, time for sleep.
P.S.Sorry if I broke stuff, was not done on purpose :)