phpBB

revert r8893 – there were massive problems with the display and select all code

ok… i hope i haven’t messed too much with the code and everything is still working.
Changes:
- Ascraeus now uses constants for the phpbb root path and the php extension. This ensures more security for external applications and modifications (no more overwriting of root path and extension possible through insecure mods and register globals enabled) as well as no more globalizing needed.
- A second change implemented here is an additional short-hand-notation for append_sid(). It is allowed to omit the root path and extension now (for example calling append_sid(‘memberlist’)) – in this case the root path and extension get added automatically. The hook is called after these are added.

oh boy…
- Migrate code base to PHP 5.1+

dumdidum… sorry. ;)

- BBCode parsing order should ALWAYS be censor_text(), bbcode_secon_pass(), bbcode_nl2br(), smiley_text(), parse_attachments()
- using \r on custom bbcodes to allow line breaks [Bug #10758]

#8456

#8374

- Changed handling of the bitfield in bbcode.php
- #6270, reverted to an earlier version of list handling + bug fixes

he braces style is deprecated as of PHP 6

sql_in_set changes

OK…

This commit should increase the total number of BBCodes from 31 to 2040. Some things to watch out for:

Each database likes to deal with binary data in its own, special way. They are, quite frankly, too cool for school.

MySQL, MSSQL and Oracle all allow me to send in a default value for their binary column using a hex number. However, MSSQL forces me to send the specific data as a hex number and thus we must CAST it.

PostgreSQL allows me to set a binary column, but with a twist. It demands that the default be in octal and its datatype allows somewhere around a gigabyte’s worth of BBCodes ( PGSQL users, we shut you down to 2040 for your own good! )

Firebird has no decent mechanism for allowing me to shuttle in binary data so I must force my way in. By virtue of triggers and a UDF, we ram in our default values.

SQLite is the most bizarre of them all. They have no mechanism for turning an ASCII code into a ASCII character. Because of this, we have a trigger and a UDF (just like Firebird!) but with a twist! The UDF is defined on the PHP side of things instead of SQL. SQLite also demands that it’s data be encoded before being sent off.

Other notes:
- SQLite installs again :D
- Firebird nearly installs again :P
- Database backup is not screwed up :P

P.S.
I hope nothing broke :D

what? yeah…
- turns out the backup issue was not a backup issue but a schema issue
- let there be color

erm, ok, my fault. :/

- fixed a few bugs
- added user_add() function
- check posted images ([img]) for same domain/scipt and php files
- auth_api.html updated to the coding guidelines look&feel
- introduced ability to force non page-updates (cron is using it)
- correctly resend coppa email

- get every bbcode tpl block defined within bbcode.html. ;) (#1889)

- fixing a few smaller bugs/glitches
- init user session in cron.php (else it can produce errors if functions expect the user object being set)
- fix sql escaping for mssql/mssql_odbc

- file_get_contents instead of imploding file()s or fread()ing till the maximum filesize
- language and style properly use compression
- language now prompts user for methods
- functions_compress does not need to eval() to get a hex date, instead calls pack()
- A writing method is defined at the end of tar operations only if data has been sent to the archive
- BBCode parser does not have to eval(), it instead uses the regex to loop around the matches

Hopefully nothing broke :-)

- added acp_language (language pack management)
- minor adjustments to cope with PHP5.x

- bugfixes
- do not hardcode url bbcode tag (please change the bitfield accordingly – see schema file!)

- letting urls work again, fixing [code] breakage on urls, corrected magic_url to be able to parse urls at the beginning/end of bbcode blocks
- fixed “edited by” message.

- more updates, mostly bugfixes to the bbcode parser
- changed current_user in sessions (please review)
- give more flexibility to style authors in regard to the pagination elements
- profile fields updates (included a sample constuct into viewtopic_body.html – have to be documented extensivly)
- code optimizations (use of strpos, sizeof, loops not iterating functions on every call, memory savings…)
- and last but not least - hopefully not introduced more bugs than healthy (cough)

trouble oh trouble… trouble oh trouble… trou… SLAP!

- forum rules + link to forum rules
- three new (tiny) functions added to functions_posting responsible for handling text with bbcode/smilies/urls, use them at items all over across phpbb…
- some bugfixes within admin_forums and other files
- new admin_board layout (much safer, security wise)

inline attachment capability…

Not even worth a log msg ;)

username quoting should be working again…

Correct pathname for template

Primary / secondary style bbcode implementation. Not thoroughly tested yet but my test board still functions so I guess it works ;)

Cope with secondary (per forum) styles, probably other minor things too … there is a known permissions problem, will work on that soon. Ashe, the bbcode primary/secondary stuff may need some tightening, particularly since it only checks the bbcode_bitfield for the primary template (which may not exist as coped with later) ... I’ll leave that to you to alter.

Fix up display of sigs and bbcode for preview

Added: width / height parameters to flash
Fixed: ol closing tag
Screwed-up: ol opening tag – will check that later

This version tends to do what it was supposed to do … I guess users will prefer this …

Added: [/] tag (list item end tag). Automagically added if needed, in which case it’s stored as [/:m:$uid]
Added: any {L_*} var in bbcode.html is replaced by its matching $lang string

a few updates, added #539865 and #694413.

Move second parse cache init after assignment of bitfield … in case bitfield isn’t set globally

More bbcode fixes

Added some extra ’s’ extensions to preg_matches to cope with multiline data

Various, typically posting related updates

Various updates and alterations

Fix for “security vulnerability” in img tag

Move phpbb_preg_quote back into functions because it’s plain annoying … :D

Fix for bug #529642… Tabs should end parsing for magic urls as well as spaces or newlines…

Fixed #506066, [img] didn’t work with multiple instances directly following each other

Minor change to email match

Add a ; to URI validation rex

Couple more updates to URL ‘fixes’

alphaNUMERICS Paul, ... doh

!!$## gotta stop testing on one machine and commiting changes on another… I mistyped one word, and broke quotes completely. :( Somebody please get me a beer

Fix for bug #496944 “quotes with usernames containing “]”

fixed [code] bbcode linebreaking nbsp; stuff.

tabs-to-spaces and other indentation mojo for [code] bbcode.

[quote=username] bbcode.

Changes related to private messaging + some bug fixes

color and size tags

Numerous updates and additions for polling and assorted fixes … or bugs, whichever they turn out to be

Modified header comments

Beginnings of the forum managament code (no functionality yet). Also a bit of a fix to view topic so it dosan’t screw up when HTML is turned off. Still needs work, HTML works in [quote] tags… havn’t tracked it down yet. Nate should look at it!

Ran John’s fix_files script to fix all the windows carriage returns.
Also added the script in the develop dir. To use it copy it to the phpBB2 root dir and run it