phpBB

ok… i hope i haven’t messed too much with the code and everything is still working.
Changes:
- Ascraeus now uses constants for the phpbb root path and the php extension. This ensures more security for external applications and modifications (no more overwriting of root path and extension possible through insecure mods and register globals enabled) as well as no more globalizing needed.
- A second change implemented here is an additional short-hand-notation for append_sid(). It is allowed to omit the root path and extension now (for example calling append_sid(‘memberlist’)) – in this case the root path and extension get added automatically. The hook is called after these are added.

merge with revision #r8350

dumdidum… sorry. ;)

Some changes… non-invasive…

it has been decided amongst the team that using glob() is bad practice, after determining the overall usage among projects as well as the security history of the function.

- do not include if there are no files fetched with glob()
- allow options for merged files on update (merge, new file, old file)

“Ghost” topics in active topics list when shadow topics and corresponding topic in same resultset [#10313]
Find a member supporting hidden groups for those able to see them [#10305]
Display hidden groups for all those able to see them across the board (composing messages, viewonline)
Fix space for sending PM’s to groups
Let the permissions_phpbb file be included the same way as all other permission files [#10301]
Add request_a-z+ handling within modules_auth suggested by Pyramide. This will allow modders to directly show/hide their module in addition to !empty() $_REQUEST variables. [#10297]

some tiny bugfixes and changed is_active() a bit…

- added confirm box to ucp zebra (adding fried/foe)
- permission fixes for conversions
- use more appropiate error message within convertor if source tables could not be found
- other tiny fixes

some fixes today
- most important change is the consolidation of the display attachment functions; merging them together to have one function we need to call.

hmm, this was for debugging. :)

fix for bug #5490
- make sure bots are catched by the posting auth too.

Revised attachment categories a bit
Fixes for the following bugs:
#4830
#4818
#4816
#4810
#4808
#4798
#4796
#4772
#4662
#4646
#4546
#4524
#4270

I hope not having introduced additional severe errors :)

- renamed the following columns:
comment -> attach_comment
new, forwarded, unread, marked, deleted -> pm_new, pm_forwarded, pm_unread, pm_marked, pm_deleted
module_name -> module_basename
value -> lang_value

- every column is now NOT NULL
- every column is now having a DEFAULT value
- hopefully mostly consistent across every db schema
- untested schemas: sqlite, oracle, firebird

- get swatch converted into new acp format
- add page title to ucp pages
- add ability to supress getting the who is online list in page_header() (saves us ideally 1-2 queries on ucp/mcp pages)
- fixing pm rules a bit as well as now having complete author memberships for author_in_group (sender -> is in usergroup -> xxx)

ok, try this one. :) Hopefully not breaking anything.

correctly hide categories with only hidden modules

- create forums by default
- hide prune options if not enabled
- fixed module management enable/disable switch if in module itself
- fixed some schema errors
- adjusted $user->page array generation for developers calling scripts outside of phpBB root

- changed module*_url to only use the main module name but the mode as parameter
- custom module lang function now suffixed by _lang
- added general custom function with mode and module_row parameter

- do not display friends/foes if zebra has been disabled

- fix cookie shortening
- let the acm handle the module cache
- call $cache->save() after destroying data if necessary

- fix some tiny bugs
- fix module system (sometimes the layout is broken due to falsly deactivated categories)
- auth updates (setting permissions)
- fix “category jumping” bug in acp
- u_action is defined by the module itself

- ability to change anonymous user settings more easily
- fix serious bugs in permissions (always allowing if permissions explicitly set and getting wrong permission options from bitfield)
- added option for returning an array to make_forum_select
- again fixing bugs in module system (one for a very query consuming part and one for correctly filling the cache)

Rats! Out of Bug Spray… Still have a handy can of Superfluous Function-call Be-gone!

// TODO: Pick up more Bug Spray!

- fix a very nasty error: If there is a tree of more than one category but with no module in there there is no module to activate (module not found error). We have to go through the tree to make sure we are not displaying categories with no modules – took a bit to find this bug. :/

- custom profile fields
- prune users
- prune forums

- some SQL:2003 changes (basicly joins, mysql5 is sql:2003 compliant in strict mode now) – postgresql not supporting this standard. :/
- acp changes

In keeping with tradition I remove yet more code….
(abstraction of functionality used by the mcp to allow it to be used
elsewhere)

- some ucp changes (added the module info too)

- add module_display to modules table (for modes executed but not displayed)
- correctly assign $id variable for modules (name for modules and id for categories)

- added new query type to dbal’s sql_build_array
- allow setting custom template path
- adjusted module class to correctly parse trees with more than one category
- added caching to module class

- Pauls (psoTFX) new module class

Hello everyone! My name is functions_module, happy to meet you … no humping please