phpBB

Merge revisions:
r8974, r8975, r8976, r8977, r8978, r8979

- queue trigger feature
- queued posts do not affect user_posts
- show links to MCP + queued posts in ucp and acp

merge

merge? merge.

ok… i hope i haven’t messed too much with the code and everything is still working.
Changes:
- Ascraeus now uses constants for the phpbb root path and the php extension. This ensures more security for external applications and modifications (no more overwriting of root path and extension possible through insecure mods and register globals enabled) as well as no more globalizing needed.
- A second change implemented here is an additional short-hand-notation for append_sid(). It is allowed to omit the root path and extension now (for example calling append_sid(‘memberlist’)) – in this case the root path and extension get added automatically. The hook is called after these are added.

merge again, revisions 8516 to 8525

merging… again

Merging revisions #r8352, #r8353, #r8354 and #r8355

grr

oh boy…
- Migrate code base to PHP 5.1+

#15484

dumdidum… sorry. ;)

Ok, here comes a big one. Poor updater. Also requires testing.

#i91
#i92
#i93
#i94
#i95
#i96

#14566

- BBCode parsing order should ALWAYS be censor_text(), bbcode_secon_pass(), bbcode_nl2br(), smiley_text(), parse_attachments()
- using \r on custom bbcodes to allow line breaks [Bug #10758]

two fixes

some fixes here and there

#12981

let’s see if i can break something. :o

#12287
#12219

A little clean-up in the installer (thanks ToonArmy)

oh my god – what did he do? Adding attachment display to post/topic review, queue, reports, post details, mcp topic view… fixing other tiny things along the line.

#11046 – properly show load button.

#10942 + cron image into

#10781
Thanks APTX

davids “update topics last post information on approval -> disapproval change” fix. :P
Fixed start transaction for posting.

remove useless variable that caused some undefined errors

some bug fixes…

#10669

this is pretty neat.
- We save a nasty query from every new topic and reply. We can do this because we are in a transaction, asking the database what is the newest info would just return the post_id we just inserted
- editting is now far cheaper if it turns out the newest post has been editted.
- switch the globality of a topic (making it global/unglobal) is now cheaper by a lot. If it turns out that we have changed the universe in any important way we can easily fix things much faster than before.

Regression bugs from: r1=1.233&r2=1.234">http://phpbb.cvs.sourceforge.net/phpbb/phpBB2/includes/functions_posting.php?r1=1.233&r2=1.234

Anchor fragments should be ”#p12345”, not “p=12345” (which AFAIK ends up working the same as ”#p”)

Better support for nested transactions…

fixes for search button in header – #10389, #10225, #9548
added missing colour swatch to prosilver – #8657
language changes – #10387, #10375, #10373, #10353, #10279
line-height for font size (still not ideal) – #10317
Search load setting checked in sessions.php along with limit_load and also reset if not possible to determine load – #10383
Fix editing issues – #9660

Prepare to be yelled at and brace for the tide of bug reports: I had hoped we would not have to do this, but it seems that we have to.

Route all avatar downloads through download.php – adrien
-Change the way inline attachments are delivered
-Fixes a few (unreported) bugs, notably avatar upload during group generation
#10079

- m_warn is no longer a local moderation permission
- magic urls should properly use html entities
- speed up posting on big boards, MAX query can be simplified a lot in certain cases
- user IP list should be labelled with “Other users” [Bug #9707]

other fixes…

• empty log message *

Fixing the following bugs:
#8444 (language dependent buttons no longer include the dimensions to allow bigger/smaller translated images)
#8414
#8396
#8388
#8216

thanks to bartvb and kellanved for providing possible fixes…

trying to fix some bugs…

-Topic review is fast :D
#7894

adjust text for getting image dimensions as well as not suppressing warnings for getimagesize()

fixing some bugs, most being submitted grammatical/spelling errors.

- telling the admin for what the board contact and board email addresses are used for and also making sure this explanation is correct ;)
- fixes for bugs #6694, #6664 and #6662

- some fixes
- important bugfix for the mcp and determining allowed ids in general (if global announcements are included)

- bug fixes for #5618, #5588 and #5584
- remove messenger->reset() calls (they are already performed on sending)

- fixing a bunch of bugs
- moved the install trigger error to sessions and also disabled it for those having DEBUG_EXTRA enabled.
i hope not having introduced too many new bugs.

- a handful of mcp fixed, the most important one is the change for check_ids() – it is now supporting ids from more than one forum too, making it possible to use some mcp features as designed initially. We really need to get our moderator team testing the mcp extensively.
- fixed some other tiny glitches
- if a forum category with subforums get changed to a link type forum give options of what to do with the subforums (#5334)
- other bugfixes

ok, change from doing the same logic all over again we call a function to do it for us. Also allow template designers to choose which method to use by just adding a fully compiled username string (profile link + user colour). This commit may introduce problems.

ok, i am an idiot…

- implemented the suggested html_entity_decode function made by david
- fixed string length checking by also decoding entities for the sake of checking
- used the new html_entity_decode function

Revised attachment categories a bit
Fixes for the following bugs:
#4830
#4818
#4816
#4810
#4808
#4798
#4796
#4772
#4662
#4646
#4546
#4524
#4270

I hope not having introduced additional severe errors :)

- extend config checking to include check for writeable path
- removed not utilized user_allow_email column from schema
- removed inactive groups (they had no use at all, since inactive users are not able to login)
The only benefit those brought are distinguish users – but this is no longer needed too due to the inactive code present. This also allows us to retain group memberships as well as default settings for users being set inactive due to profile changes.
- rewrote user_active_flip to support multiple users and a mode, as well as coping with the aforementioned changes
- implemented updated jabber class to support SRV server records and for better jabberd2 support.
- jabber errors now logged to the error log with a full transaction
- fixed user_delete calls to include usernames where possible and also update last post information correctly
- implemented additioal checks to user management to cope with common mistakes
- On installation, guess the required mysql schema as best as possible. Users now only need to decide if they want to use the mysqli extension or not (mysqli selected by default) and no longer need to know their mysql version.
- founders do not need to re-activate their account on profile changes
- remove older session if re-authentication was successful (re-authentication always assigns a new session id)
- set the cookie directly instead of using php’s function
- added inactive_remind to see which users got deactivated because of reminders (or re-activation) sent out

hopefully not introduced too many bugs – those testing with CVS releases, please concentrate on user registration, activation, profile changes (email/password)...

These changes should let olympus scale a little bit better.
i haven’t adjusted the schemas but added the details to create_schema_files – david is able to build them then in line with his changes. :)

- fixed some bugs
- changed attachment handling a bit
- tried to remove target tags out of the code
- do not add session ids to urls for bots as well as not creating a new session on each page view for them

I bet i introduced some bugs too. ;)

- birthdays/age in user’s timezone and not server’s local time
- parse bbcode in posts with fewer characters than selected maximum on search results page
- retrieve search word context in posts which are longer than maximum characters (no raw BBCode anymore)
- formatted text is processed in the same order everywhere now: censor_text, replace newlines, bbcode, smileys, attachments, highlighting [including Bug #2048]
- highlighting pattern updated to exclude style and script (e.g custom BBCode) [Bug #3856]
- fixed a style problem in Opera [Bug #3770]
- performance increase for user::img()
- slight adjustments to search

some fixes.

David, could you check the pass_complex expressions? They are:
.* PASS_TYPE_ANY (any characters are allowed, no check)
[a-zA-Z] PASS_TYPE_CASE (password must contain alphanumerics)
[a-zA-Z0-9] PASS_TYPE_ALPHA (password must contain alphanumerics and numbers)
[a-zA-Z\W] PASS_TYPE_SYMBOL (password must contain alphanumers, numbers and symbols)

At the moment the pass complexity check is done within validate_password(), but the expressions are wrong. :)

Initial batch of colourization changes. This includes:
– schema changes for first post and last post
– display in viewforum, search and ucp of first post
– update of database on posting
Still outstanding
– display of last post

chr(0×20 | 0×10) = “0”

sql_in_set changes

- load tracking updates. Need to be tested on a clean installation too – at the moment only tiny quirks are noticed at area51.
- reported bugs fixed

- fixed some bugs
- made imageset naming more consistent
- updated every schema to be consistent and also fixed it (every db should install fine now)
-

fixing a typo ;-)

oops :P

- some bugfixes
- set ip_check to A.B.C. by default
- display postings in other encodings by default and present link to force the encoding as usual.

fix some bugs… again. :)

- fixed a parse error (oops)
- pass forum_ids to search indexing functions
- fixed a bug in fulltext_native’s cache destroying