phpBB

Mini bug fix for UNDEFINE

Extracted the IF code to make a generic parsing function,
now DEFINE is nicely integrated and we can even do things
like <!- BEGIN foo($FOO, $BAR) -> if we really wanted
to do so.

change conditional enclosements in template engine
oh… thank you very much brainy. :)

Added the locking code back in… Marek, feel free to reorder it as you see fit.

- Add some necessary evil
- Template DEFINE variables can now be assigned other variables

...

ok… i hope i haven’t messed too much with the code and everything is still working.
Changes:
- Ascraeus now uses constants for the phpbb root path and the php extension. This ensures more security for external applications and modifications (no more overwriting of root path and extension possible through insecure mods and register globals enabled) as well as no more globalizing needed.
- A second change implemented here is an additional short-hand-notation for append_sid(). It is allowed to omit the root path and extension now (for example calling append_sid(‘memberlist’)) – in this case the root path and extension get added automatically. The hook is called after these are added.

oh boy…
- Migrate code base to PHP 5.1+

- more accurate comment

ok, we are not able to cover all possibilities (IF A eq (B & C)) for example… or IF A == B… this would require a lot more code we do not see the need for.

some fixes…

some fixes

- fix some oddities (doubled spaces for example)
- changed the way make_forum_select() is returning the forum list – now including skipped forums but being disabled. This should make identifying the correct forum much more easier.
- Changed some permission namings based on suggestions by the community
- Tried to comply to the permission field ordering within the language files while displaying permission sets. Hopefully it’s worth the additional processing time.
- Disable submit buttons after clicking for installation and conversions.

- fixing some bugs
- removing utf8 characters from email files (has been discussed internally, you guys know why)
- making sure some opendir calls are checked before calling readdir.

- quite a few optimizations to the template engine. bitwise arithmatic is used to check odd/even, usage of ref to the root template variables should reduce the number of hash lookups needed, usage of refs within loops should reduce the amount of hash lookups, incrementing vars were turned from class variables to regular variables, cache now uses preincrementing variables instead of postincrementing variables, some regex were optimized/trimmed
- a bug fix somewhere in there…

- fixing a bug i am unsure about when it occurs (but it occurs). The symptoms are broken template cache files if after removing unnecessary php opening/closing tags result in statements being syntactially incorrect.
- added real syncing to forums acp (not only forum statistics rebuild)

the tokenizer is buggy across several versions of PHP. The regex that is always used complies strictly with what the internal lexer uses, we are safe.

more efficient + fixing an oops

Fixed: oops, forgot ASP-like tags
Fixed: <?! was not escaped, despite being valid PHP
(cvstats++)

could have been a copy&paste error, but the expression is also removing the tag from valid script blocks (javascript for example). :)

- fix bug within php code removal expression. Thanks to BenP for reporting it to our security tracker.

make sure custom profile fields are created correctly on registration (#2225)

character class… character class… character class…

some changes before i forget…

introduce LA_ for addslashing language variables for use in js vars (idea by naderman)

- clean up marklist calls (global function)
- added new feature: test out others permissions (admin permissions will not be copied)
- changed attachment processing by directly using the template engine
- fixed some attachment related bugs
- additional tiny fixes

- fix the template error (no headers displayed, wrong ! assignment, wrong check for .loop)

- This should work! :D

We all make mistakes :D

- file_get_contents instead of imploding file()s or fread()ing till the maximum filesize
- language and style properly use compression
- language now prompts user for methods
- functions_compress does not need to eval() to get a hex date, instead calls pack()
- A writing method is defined at the end of tar operations only if data has been sent to the archive
- BBCode parser does not have to eval(), it instead uses the regex to loop around the matches

Hopefully nothing broke :-)

Some fixes to the template code
– this handles the case where file caching is used and no cached
version exists