phpBB

Merge of the language-specific custom path change Revision #r8782

do not allow [flash=0,0]... not implemented for images due to the reliance on getimagesize() – as usual both sizes are able to be limited by the maximum/minimum image size configuration options

Go away evil carriage returns\!

merge revisions #r8392 and #r8393

Correctly check empty subjects/messages (Bug #17915)
Do not check usernames against word censor list. Disallowed usernames is already checked and word censor belong to posts. (Bug #17745)
Additionally include non-postable forums for moderators forums shown within the teams list. (Bug #17265)

do not allow [size=0]

fixing some annoying bugs

some tiny bugfixes

#i71
#i72

- BBCode parsing order should ALWAYS be censor_text(), bbcode_secon_pass(), bbcode_nl2br(), smiley_text(), parse_attachments()
- using \r on custom bbcodes to allow line breaks [Bug #10758]

- added information about Unicode to coding guidelines
- two little changes

Cleaning up (#13689)
Also removed the useless login box from the ACP.

some more fixes

fixing some bugs

um, oops

#12189

ok, mess around with the templates + fixing some bugs + adjusting headers for those files already modified to circumvent conflicts for those having their editor set to remove trailing spaces (not recommended!)

fix an improper fix.
- generally, sorry, but direct url parsing after ] will no longer work…
- try to eliminate the most common “bug” for placing urls within the [url=][/url] part (the text). This will trigger make_clickable and render the url invalid (doubled url), moreso if other text is involved too. This is still te case if the url is not written directly after the [url=] part. This is nearly the best we can get within 3.0.x – and every report about [url=], [url] and make_clickable and it’s non-parsing or parsing will be closed with “will not fix”, except it is a critical bug resulting in the non-functioning of the board. We may adjust this later to our own liking while we try to find different ways to face these problems.

we included a check for getimagesize() existance… now we again can suppress notices while running this function.

ok… enough of this. Do not change [quote] layout at all. Smilies, urls, etc. won’t parse now again directly after quotes – away with this. Actually we do not need to babysit users, but the feature was nice and fixed an inability which anoyed me in 2.0.x. Hey, you can’t have everything – at least it is no longer error prone.

#10982

ok, parsing code correctly now? ;)

#10635
This should work, it could be made more strict but am leaving it alone for now

#9811

#8572

This actually bugged me to for a long time too.

#8456

#8244
- cleaned up the TRUNCATE/DELETE FROM in the native search backend
- fixed an imporoper default value on some upgrades

- found a small bug in the list parser while working on another bug

- some bugfixes
- bugfixes for the convertor (typecasting for example was totally broken)

sprintf

some fixes today
- most important change is the consolidation of the display attachment functions; merging them together to have one function we need to call.

- Optimize acl_getf_global a bit
- a little performance improvement of the IP regular expressions
- convert post_text/subject collation to utf8_unicode_ci if a user wants to use mysql_fulltext to allow case insensitivity [Bug #6272]
- mysql_fulltext should alter all necessary columns at once to speed up the process
- validate URLs against RFC3986
- fixed some weirdness in make_clickable
I hope I didn’t break any URLs with this commit, if I did then report it to the bugtracker please!

#6090
- some cool regex stuff (one of them looks kinda weird :\ ...)

some updater changes as well as tiny bugfixes

hopefully fixed bug #5644 while also retaining the fix for bug #3572
testing this is appreciated.

- fixes for the following bugs:
#5326
#5318
#5304
#5290
#5288
#5278
#5276
#5272
#5266
- also fixed the “Call-time pass-by-reference” bug #5252
- within this step changed the normalize calls to require references.
- added captcha size variables to the class scope (suggestion was posted at area51)

ok, i am an idiot…

- store sql_layer directly within the layer itself
- new method sql_multi_insert to circumvent db-specific hacks
(hopefully not introduced any parsing errors)

strpos…

- forgot to make the same change to the ODBC driver
- MySQL 3.x works now
- FirebirdSQL is now on the same level as MySQL and PostgreSQL, zero hacks exist inside the core code now

- fixed some bugs
- changed attachment handling a bit
- tried to remove target tags out of the code
- do not add session ids to urls for bots as well as not creating a new session on each page view for them

I bet i introduced some bugs too. ;)

some updates. Also adjusted the utf tools and normalizer more to our coding guidelines.

If i could force you all to use PHP 5.1.0+, then i could just use the count param with preg_replace. Oh well…

so…. what does this thing do?

well, the super fast, ultra efficient, massively huge BBCode handling system was implemented differently on each DBMS. Although this provided the best performance, the solution was a bit hacky.

So what does this new thing do? We use base64 encoding to make everything nice and shiny, it turns into nice, safe characters that we can just jam into varchars on essentially any database. This has two implications: we must decode every bitfield we get AND we have slightly fewer IDs to work with. It goes down from 2040 BBCodes to 1512. We lose like a quarter of them :P

P.S. I hope nothing broke :P

OK…

This commit should increase the total number of BBCodes from 31 to 2040. Some things to watch out for:

Each database likes to deal with binary data in its own, special way. They are, quite frankly, too cool for school.

MySQL, MSSQL and Oracle all allow me to send in a default value for their binary column using a hex number. However, MSSQL forces me to send the specific data as a hex number and thus we must CAST it.

PostgreSQL allows me to set a binary column, but with a twist. It demands that the default be in octal and its datatype allows somewhere around a gigabyte’s worth of BBCodes ( PGSQL users, we shut you down to 2040 for your own good! )

Firebird has no decent mechanism for allowing me to shuttle in binary data so I must force my way in. By virtue of triggers and a UDF, we ram in our default values.

SQLite is the most bizarre of them all. They have no mechanism for turning an ASCII code into a ASCII character. Because of this, we have a trigger and a UDF (just like Firebird!) but with a twist! The UDF is defined on the PHP side of things instead of SQL. SQLite also demands that it’s data be encoded before being sent off.

Other notes:
- SQLite installs again :D
- Firebird nearly installs again :P
- Database backup is not screwed up :P

P.S.
I hope nothing broke :D

- tackle some usability issues
- fix bug #3147
- added the lock-images made by SHS`
- fixed MSSQL errors (adding the correct ESCAPE sequence)

- add additional auth check to the permission roles modules
- added new function to return globally used expressions (get_preg_expression($mode)). This should be very helpful in getting wide spread similar checks (regular expressions) to one place reducing the risk of forgetting to change every location if you fix one. ;) We will add additional ones later, at the moment only the email check is retrieved…
- added “active module” var to the module class returning the current active module
- changed call to image magick
- add administrator to global moderators group by default
- extend auth_option column a little bit
- other bugfixes

oops?

- automatically sync topic_reported when deleting a post [Bug #2152]
- retrieve forum information in report.php
- don’t update deleted topics
- proper permission check for “admin or moderator”
- allow changing poster while ip dropdown contains a different user [Bug #2190]
- fixed a typo in acp_styles [Bug #2188]
- allow inserting BBCode at the first position of the textarea [Bug #2078]
- allow the style name to be different than the style path

- added class=”radio” to all radio- and checkboxes
- make sure the database gets closed correctly in cron.php
- bugfixes

- fixed a few bugs
- added user_add() function
- check posted images ([img]) for same domain/scipt and php files
- auth_api.html updated to the coding guidelines look&feel
- introduced ability to force non page-updates (cron is using it)
- correctly resend coppa email

try to prevent re-parsing of parsed bbcode content

- fix some smaller bugs
- removed custom profiles preview field from acp

make sure we check the attachment status for the correct user ;)

some tiny changes…

- introduce new function build_url to easily build a valid url from the user->page object as well as optionally removing certain keys
- changed attachment config to utilize the config build methods
- cleaned up posting.php
- the submit/delete_post functions are now usable (functions_posting.php)
- adjusted header icons (transparency)
- a bunch of fixes for mssql
- bug fixes

- removed group settings from roles
- added forum icon in front of forums in permissions acp
- added trace permissions in permission masks (thanks naderman for writing the first code and for the idea… :))
- some bugfixes
- PHP6 fix

To all people having their bug status set to fixed: SF pserver CVS access is currently down, therefore the snapshots are still out of date.

- fix a bunch of bugs
- <!- $Id$ -> is no longer allowed in template (.html) files
- changed layout of private message screens (folders are menu items)
- removed unread mode for private messages
- added new feature to template engine – “jump out of loop” or “loop another loop within my loop” :D (will be documented within the coding guidelines)
- added autologin field to sessions
- check session length checks
- added add_log statement to sessions to track session valid to invalid changes if ip/browser change depending on config settings (only debug)
- added multibyte support for various variables (exception at the moment is usernames which needs some discussion)
- hopefully not broke something. :/

ahhh, there we have it… related to several reports about code blocks and bbcode parsing (#1302)

- Bug 1100

- some bugfixes
- committed coding guidelines as they are at area51
- removed script_path (needs a close inspection later)
- removed the need for server_name and server_port
- able to define server port/name/protocol and force the user-defined server vars (very handy for proxy setups)

implementing permission roles

- copy permissions (adding groups)
- copy permissions (adding forums)
- checking proper groupadd/del settings
- added intro page to permissions (to give an overview and quick links)
- able to select forums + subforums, single forum, all groups, all users (permission screens)
- able to reset permissions (only reset input field)
- fix forum deletion bug

just preparing…

- user avatar, user signature, user attachments

- some SQL:2003 changes (basicly joins, mysql5 is sql:2003 compliant in strict mode now) – postgresql not supporting this standard. :/
- acp changes