phpBB

Get real dbms version instead of relying on php internal functions which only grab the local library version

ok… i hope i haven’t messed too much with the code and everything is still working.
Changes:
- Ascraeus now uses constants for the phpbb root path and the php extension. This ensures more security for external applications and modifications (no more overwriting of root path and extension possible through insecure mods and register globals enabled) as well as no more globalizing needed.
- A second change implemented here is an additional short-hand-notation for append_sid(). It is allowed to omit the root path and extension now (for example calling append_sid(‘memberlist’)) – in this case the root path and extension get added automatically. The hook is called after these are added.

This will prevent a php warning from being printed (and the layout getting ruined) in case of a conflicting permission restriction such as open_basedir

- a few tiny clean ups
- a new MS SQL DBAL, it does not work so hot because of issues with the extension it depends on

#16695
#s17235

#14924

deregister globals to install too

#13463
- tiny issue with get_tables()

#12287
#12219

A little clean-up in the installer (thanks ToonArmy)

Some fixes and improvements.
#11817
#11851
#11801
#11461

undoing the fix for #11421 – correcting post counts was not well liked.
#11665

label changes, language fixes…

fixing some bugs
changed the way we are handling bookmarks. No order_id required, really! Order by last post time as suggested by BartVB.

some language-specific adjustements
fix prune users (adding the list of users to the confirmation page)
tried to fix the show/hide trigger in ACP by not using width: auto; (which gets somehow inherited to each other element)

- * wildcard in a search query should cause \w+ in highlighting, not \w* [Bug #10031]
- display a warning that the search index is not converted from phpBB2 to phpBB3 [Bug #9761]
- forgot to add : to reg_name when deleting userinfo from the url regex constructor [Bug #9868]
- magic urls should work after ”>”
- fixed sorting in mcp_reports/mcp_queue [Bug #9882]
- display a “Report has already been closed” message, if a post is accessed in mcp_reports which has a closed report (might occur if two moderators want to process it at the same time)
- convertor: old forum path should have the trailing slash removed
- subsilver2 will come bundled with phpBB3, but it will not be installed by default (if admins want to use it they can, but it’s not a default option for users)
- prosilver was missing the topic-only mode in mcp_reports/mcp_queue

- check for username_clean collisions prior to conversion

ok, i am not sure if this change is doing what is intended (forcing at least one row to be processed) – please test. :) (i am currently not able to)

- found a small flaw, no more errors from cross conversions :D

#8234
- some stupid bugs in restore
- centralized the method of getting tables

- clean up mssql and mssql_odbc, mssql now uses a different method of dealing with IDENTITY
- clean up firebird, I will consider changing it to use fetch array instead of fetch object. it’s identity code already uses this method as of right… now :D
- fix a tiny bug in MySQL’s driver (remember to pass the connect id to all DBAL functions)
- add new_link as a new param for sql_connect. This allows you to make connections that are not dependant on each other. This is done for our friends mysql, mssql, postgresql and oracle. Now for everybody else.. (I said this was clever ;) MySQLi and SQLite should always spawn a new connection when you call it while mssql_odbc and firebird both will create new links if you give them different params (different creds) than the previous connection(s). Thus we can always promise new links :D
- fixed a bug in the converter
- cleaned up the dbal a little

- fixed a referencing problem with objects (PHP4/5 conflict)
- user_group_auth can take data from both target and source database

- allow converting from one database to another, no need for tables to be in one database anylonger (this also allows switching from one DBMS that was used with phpBB2 to another DBMS supported by phpBB3 including new systems available in Olympus only)
- abstracted some installation code that is now relevant to converting as well into functions_install.php (mostly DBMS selection related)
- fixed a weird smiley path problem, no idea why nobody else noticed this, maybe my fix was incorrect?
- forgot to commit a file last time

- reimplemented autoincrement support in the convertor, made it more generic
#7528

#7698
- small UTF-8 thing

make sure the session table is empty after conversion and the current session being killed. This makes sure the user converting does not inherit wrong user settings becuase the 3.0.x users table being completely new.

- should fix some Firebird issues ( can’t believe that nobody found this until now )

- fix some oddities (doubled spaces for example)
- changed the way make_forum_select() is returning the forum list – now including skipped forums but being disabled. This should make identifying the correct forum much more easier.
- Changed some permission namings based on suggestions by the community
- Tried to comply to the permission field ordering within the language files while displaying permission sets. Hopefully it’s worth the additional processing time.
- Disable submit buttons after clicking for installation and conversions.

- fixing some bugs
- removing utf8 characters from email files (has been discussed internally, you guys know why)
- making sure some opendir calls are checked before calling readdir.

fix some general bugs and some convertor related

- ok… first of all, let the forum names and descriptions being recoded correctly…
- fixed the php notices for a non-existant poster id. They were related to user signature conversion
- adjusted the topic_poster id; this should solve wrong user assignments for topic poster
- adjusted private message author; normally here some users should have encountered wrong ids.
- adjusted the batch sizes to support the usual 2.0.x target base – the old values were used for really huge conversions. :)
- commented out meta refresh for the time being – we will add a setting for this, some may want to sit in front, some may want to go away while converting (most likely when they did a test run before)

silly pants

some fixes…