phpBB

- queue trigger feature
- queued posts do not affect user_posts
- show links to MCP + queued posts in ucp and acp

Fix some instances where we left db connections open (registration -> captcha for example)

ok… i hope i haven’t messed too much with the code and everything is still working.
Changes:
- Ascraeus now uses constants for the phpbb root path and the php extension. This ensures more security for external applications and modifications (no more overwriting of root path and extension possible through insecure mods and register globals enabled) as well as no more globalizing needed.
- A second change implemented here is an additional short-hand-notation for append_sid(). It is allowed to omit the root path and extension now (for example calling append_sid(‘memberlist’)) – in this case the root path and extension get added automatically. The hook is called after these are added.

cross-ci

merge with revision #r8350

wrong call – utf8_clean_string() instead of utf_clean_string() :)

err…

#15889

dumdidum… sorry. ;)

#i71
#i72

#i62 – #i65
gone through every javascript invocation and making sure we adhere to our coding guidelines.

- two new packages… diff and utf
- only 60 chars for topic title if new post (please see changelog for explanation)
- change utf8_wordwrap (had some bugs david and nils spotted – was not really functional, sorry for this. :D)

err, forgot to commit

do not get too excited

#13657 – thanks Thatbitextra

#12947 – thanks to APTX for his partial patch and Highway_of_Life and iWisdom for testing

Adding the bot mark/unmark links already promised in the changelog.
Adds backlinks to the success screen after closing reports (#12905)
Some style and language fixes (#12493, #12235, #11235, #11949) – the latter is still not perfect.
Added code to the phpBB2 converter to deal with slashed quotes (#12607)

Changes and adds language entries :)

Fixing a few minor bugs; changing one language variable.

#12123
#12483
#12489
#12513

my round of bug fixes

#12263

Some fixes and improvements.
#11817
#11851
#11801
#11461

#11257

... 96 bugs on the wall …

#10781
Thanks APTX

#10567

#10005, #10003, #10001, #9999, #9945, #9965, #9909, #9906, #9877, #9861, #9831, #9830, #9815, #9665, #9624

prosilver adjustments for important announcements in ucp – #9995
MCP fixes for user notes/warnings – #9981
Preserving imageset values on save/edit
find a member link for Mass PM’s – #9925
syndicate window.onload events where necessary – #9878
Duplicate topics in forums with announcements – #9840
Email template for forced re-activation – #9808
Topic pagination adjustment – #9763
Changed compose message layout in UCP – #9706, #9702
Fixed inline attachment font size (hopefully)

Revert and undoing bug #9736

Won’t fix, at least for 3.0.x. Re-review come 3.2.x and perhaps may be able to get localised prefixes, so something like:

Sv: Re: Antwort:

... doesn’t happen. :P

checking in some fixes… also added “previous/next pm in history” links to prosilvers private message view; dhn, you may want to have a look at the placement. :)

other fixes…

again… some more fixes.

Fixing the following bugs:
#8444 (language dependent buttons no longer include the dimensions to allow bigger/smaller translated images)
#8414
#8396
#8388
#8216

thanks to bartvb and kellanved for providing possible fixes…

trying to fix some bugs…

- removed download mode selection (the column info and constants will not be removed, we or others may be able to re-use them later on)
- removing extension from physical filename for uploaded attachments (as has been suggested some time ago from our community), can still be used by using the new ‘unique_ext’ mode on file cleaning
- fixed a bug with copying attachments if copying a topic
- made sure no attachment files get removed used at another location
- changed media player “embed” code. For some this may result in no auto-resizing – though a download link has been added.

#6504

#6076
- removed unused junk from functions.php

#5734
- replaced array_rand($array) with mt_rand(0, sizeof($array) – 1) as array_rand did not take my seed

- fixing a bunch of bugs
- moved the install trigger error to sessions and also disabled it for those having DEBUG_EXTRA enabled.
i hope not having introduced too many new bugs.

- a handful of mcp fixed, the most important one is the change for check_ids() – it is now supporting ids from more than one forum too, making it possible to use some mcp features as designed initially. We really need to get our moderator team testing the mcp extensively.
- fixed some other tiny glitches
- if a forum category with subforums get changed to a link type forum give options of what to do with the subforums (#5334)
- other bugfixes

message

ok, i am an idiot…

- adjust unread query a bit to cope with large topics (thanks bart!)
- fixing some bugs
- more username_clean work

for some things we do not need the utf8 function. :)

#3794

consistent acp layout regarding backlinks and messages.

- fixed some bugs
- changed attachment handling a bit
- tried to remove target tags out of the code
- do not add session ids to urls for bots as well as not creating a new session on each page view for them

I bet i introduced some bugs too. ;)

hopefully fixing bug #3966

- fixed some bugs
- made imageset naming more consistent
- updated every schema to be consistent and also fixed it (every db should install fine now)
-

OK…

This commit should increase the total number of BBCodes from 31 to 2040. Some things to watch out for:

Each database likes to deal with binary data in its own, special way. They are, quite frankly, too cool for school.

MySQL, MSSQL and Oracle all allow me to send in a default value for their binary column using a hex number. However, MSSQL forces me to send the specific data as a hex number and thus we must CAST it.

PostgreSQL allows me to set a binary column, but with a twist. It demands that the default be in octal and its datatype allows somewhere around a gigabyte’s worth of BBCodes ( PGSQL users, we shut you down to 2040 for your own good! )

Firebird has no decent mechanism for allowing me to shuttle in binary data so I must force my way in. By virtue of triggers and a UDF, we ram in our default values.

SQLite is the most bizarre of them all. They have no mechanism for turning an ASCII code into a ASCII character. Because of this, we have a trigger and a UDF (just like Firebird!) but with a twist! The UDF is defined on the PHP side of things instead of SQL. SQLite also demands that it’s data be encoded before being sent off.

Other notes:
- SQLite installs again :D
- Firebird nearly installs again :P
- Database backup is not screwed up :P

P.S.
I hope nothing broke :D

hmm… This commit does not increase the number of BBCodes. However, this does other things that we need to do first. This splits the usage of allow_* from the BBCode bitfield in forum descriptions, forum rules and group descriptions. This also fixes a tiny, tiny severe issue that nobody found :D I hope it works :P

fix some bugs… again. :)

some bugfixes

- add additional auth check to the permission roles modules
- added new function to return globally used expressions (get_preg_expression($mode)). This should be very helpful in getting wide spread similar checks (regular expressions) to one place reducing the risk of forgetting to change every location if you fix one. ;) We will add additional ones later, at the moment only the email check is retrieved…
- added “active module” var to the module class returning the current active module
- changed call to image magick
- add administrator to global moderators group by default
- extend auth_option column a little bit
- other bugfixes

- removed db cache (might re-appear, but for now we do not see the need for it)
- all changes to styles/subsilver/template are purely cosmetic (no functional changes)
- cosmetics
- bugfixes
- add index to modules table
- use modules ordering code for forums too

- fix some smaller bugs
- removed custom profiles preview field from acp

make sure we check the attachment status for the correct user ;)

#1871

fix bug #1857

- introduce new function build_url to easily build a valid url from the user->page object as well as optionally removing certain keys
- changed attachment config to utilize the config build methods
- cleaned up posting.php
- the submit/delete_post functions are now usable (functions_posting.php)
- adjusted header icons (transparency)
- a bunch of fixes for mssql
- bug fixes

- some adjustements for phpdocumentor

- Added some missing lang strings

say hello to role descriptions, role ordering and tooltips on role selects

To all people having their bug status set to fixed: SF pserver CVS access is currently down, therefore the snapshots are still out of date.

- fix a bunch of bugs
- <!- $Id$ -> is no longer allowed in template (.html) files
- changed layout of private message screens (folders are menu items)
- removed unread mode for private messages
- added new feature to template engine – “jump out of loop” or “loop another loop within my loop” :D (will be documented within the coding guidelines)
- added autologin field to sessions
- check session length checks
- added add_log statement to sessions to track session valid to invalid changes if ip/browser change depending on config settings (only debug)
- added multibyte support for various variables (exception at the moment is usernames which needs some discussion)
- hopefully not broke something. :/

do not ask why i put the pm table there instead of the polls. :o
- remove forum description from title tag (now it’s able to hold bbcode etc. resulting in broken layout)

- a bunch of bugfixes. :P

- added “display_on_posting” setting to custom bbcodes (creates a button with the bbcode tag)
- fixed forum editing and parent id selection
- completely removed HTML support (it only creates security problems)
- changed cache_moderators() to reflect permission changes

- blabla, additional bugfixing permissions…

- moved add_log out of functions_admin (this file should only be included in admin/admin-related pages)
- fixed cookie based topic tracking
- added missing config variables
- other minor things

- size select fix
- introduced function for building group options (acp)
- fixed acl_getf if negated option needs to be retrieved
- only using one function for updating post informations
- fixing module display if module is disabled
- if user is having a non-existent style do not print out error message, instead fix the users value and load the default style

- search deals with global topics
- fixed some other search related bugs

just preparing…

- overhauled search system
– updated structure for search backend plugins
– better result caching using ACM
– search results no longer session restricted => link to them by copying the URL :)
– in-topic search
– indexing posts now uses search backend plugins
– develop/search_fill.php working again
– fulltext_mysql not working yet
- tiny bugfixes to ACM

- updated topic tracking code
- additional changes (mostly bugfixes)
- bart, if you update your user table with the user_lastmark field, set it to the user_lastvisit value ;)
- and last but not least, introducing some bugs in ucp main front (regarding topic tracking)

fix tiny bug. ;)