History | View | Annotate | Download (29.3 kB)
Fix Bug #48875 - we compare the bitlength, therefore we indeed do not need to re-cache if we think acl options got changed (which we did)
- Display coloured usernames in ACP groups management screens- Changed behaviour of group_create() function to support specifying additional group columns- New groups option to excempt group leaders from group permissions
Implemented strict check for cached user permissions and existing ACL options. This fix makes sure cached permissions are valid, even if they got already cached.
fixing two potential problems- blank style- check for correct role assignment within auth.php (should not happen, but seems like some users are not able to persist from manually messing with the db)
Hiding everywhere little buggers, eh?
- Remove left join for query used to retrieve already assigned users and groups within permission panel - #20235- also test the serialize/unserialize approach for cached roles
revamp how we query permissions. This is half-experimental actually, needs a bit of testing.Should fix the bug with low max_join_size values, but may give problems for those on very low memory settings.
This commit was manufactured by cvs2svn to create branch 'phpBB-3_0_0'.
dumdidum... sorry. ;)
space, where art thou?
#13863 (oops)
do not consider permissions the admin is not able to change, track or see.
tweak the sql_like_expression feature a little bit to allow correct escaping
new wrapper for LIKE expressions to streamline the fixes. We actually need to adjust them for different DBMS as well as SQLite2 not supporting escaping characters in LIKE statements (which is a reason why we think about dropping sqlite support completely).
ok, mess around with the templates + fixing some bugs + adjusting headers for those files already modified to circumvent conflicts for those having their editor set to remove trailing spaces (not recommended!)
erm... um... NOBODY SAW THIS :P
#11255#11259#11291#11335#11457#11473#11475#11511#11523#11527
some tiny changes
#10255
changed the cache files to save some memory (all global ones are hold in memory, doubling it).
some changes/bugfixes
- improvements to search indexing performance, espacially tidy() by adding a word_count column, the database update from b5 to next version will take quite a while on bigger databases, I also lowered the default common word threshold from 20 to 5 percent, big boards might want to use 3 or 2 percent, 20 was way too high...
a performance improvement
show dropdown box for choosing the forum in user management screen -> permissions
- Optimize acl_getf_global a bit- a little performance improvement of the IP regular expressions- convert post_text/subject collation to utf8_unicode_ci if a user wants to use mysql_fulltext to allow case insensitivity [Bug #6272]- mysql_fulltext should alter all necessary columns at once to speed up the process...
- the same procedure as every... oh. this is taken.- also including the first bugfix within beta4, just noticed at area51 that quicktools are not working in global announcements. :D
- a handful of mcp fixed, the most important one is the change for check_ids() - it is now supporting ids from more than one forum too, making it possible to use some mcp features as designed initially. We really need to get our moderator team testing the mcp extensively....
- now username changes should work as desired- removed some extract() calls
- store sql_layer directly within the layer itself- new method sql_multi_insert to circumvent db-specific hacks(hopefully not introduced any parsing errors)
- introducing clean usernames, needs to be tested more, I'm not sure I didn't miss anything- homograph list should probably be extended
tried to begin adjusting all string functions where applicable - still a lot to do.i hope i catched all relevant sections and did not mess something up.
- extend config checking to include check for writeable path- removed not utilized user_allow_email column from schema- removed inactive groups (they had no use at all, since inactive users are not able to login) The only benefit those brought are distinguish users - but this is no longer needed too due to the inactive code present. This also allows us to retain group memberships as well as default settings for users being set inactive due to profile changes....
- Fix some bugs- fixed retrieving of permissions if the LIKE statement is used as well as proper supporting (needs testing on mssql)
sql_in_set changes
- fixing some bugs- removed file_exists calls for auth plugins since they need to be there once set up
- display age in user profile and make it available on viewtopic- various tiny bugfixes including [Bug #2351] [Bug #2549] [Bug #2681] [Bug #3015]- strip first, then change newlines [Bug #2403]- added support for creating user profiles to the login function (makes use of user_add), triggered by LOGIN_SUCCESS_CREATE_PROFILE constant...
change ACL_NO to ACL_NEVER and ACL_UNSET to ACL_NO to let our users get what is meant on the first look.
the downside is that the information is no more accurate (permissions are still unset, defaulting to no) - someone might to overlook all explanations. :)
fix bugs #2271 and #2273
- removed db cache (might re-appear, but for now we do not see the need for it)- all changes to styles/subsilver/template are purely cosmetic (no functional changes)- cosmetics- bugfixes- add index to modules table- use modules ordering code for forums too
make sure custom profile fields are created correctly on registration (#2225)
ok, this one is rather large... the most important change:re-introduce append_sid: old style continues to work, not a performance hog as it was in 2.0.x -> structure is different
apart from this, code cleanage, bug fixing, etc.
hopefully fixing bug #2022 with this
fixing bug #1860
- david: copy&paste error? ;)
I hope nothing broke!
- Added a query builder, it is currently only used for complex queries that involve a FROM clause with two tables and a left join- Changed some function calls in the DBAL- Made the viewtopic queries nicer
- removed group settings from roles- added forum icon in front of forums in permissions acp- added trace permissions in permission masks (thanks naderman for writing the first code and for the idea... :))- some bugfixes- PHP6 fix
- clean up marklist calls (global function)- added new feature: test out others permissions (admin permissions will not be copied)- changed attachment processing by directly using the template engine- fixed some attachment related bugs- additional tiny fixes
ok, this will fix various permission discrepances. :) What happened is that the static permission cache and the static acl forum ids were used... globally (of course). But this led to users inheriting permissions from previously called user permission setups resulting in users seeing private forums in profiles as well as other areas i could imagine being "wrong". Thanks to Yawner for letting me login with his username. :D
- streamlined reports to consist of the feature set we decided upon (Nils, your turn now)- use getenv instead of $_ENV (with $_ENV the case could be wrong)- permission fixes (there was a bug arising with getting permission flags - re-added them and handled roles deletion differently)...
implementing permission roles
- copy permissions (adding groups)- copy permissions (adding forums)- checking proper groupadd/del settings- added intro page to permissions (to give an overview and quick links)- able to select forums + subforums, single forum, all groups, all users (permission screens)...
my turn to break things... harharhar- checking in permission settings and permission masks- permission presets and documentation not finished yet- added backtrace function to determine file/line for sql errors- fixed marlist for orphan attachments/groups/logs/users...
- new acl method -> acl_getf_global()usage example: acl_getf_global('m_approve'); returns true if user has m_approve permission in one or more forums, else false
- ability to change anonymous user settings more easily- fix serious bugs in permissions (always allowing if permissions explicitly set and getting wrong permission options from bitfield)- added option for returning an array to make_forum_select- again fixing bugs in module system (one for a very query consuming part and one for correctly filling the cache)
- moved add_log out of functions_admin (this file should only be included in admin/admin-related pages)- fixed cookie based topic tracking- added missing config variables- other minor things
- size select fix- introduced function for building group options (acp)- fixed acl_getf if negated option needs to be retrieved- only using one function for updating post informations- fixing module display if module is disabled- if user is having a non-existent style do not print out error message, instead fix the users value and load the default style
move around - better not call create_function in a loop
just preparing...
- sperate permissions from sessions- added some comments to the auth class for better understanding- revised some permission functions- added option to negate permission check by prefixing option with a ! (for example checking for !f_read returns true if user is not able to read forum)...
