View | Annotate | Download (123 KB)
[Fix] Force full date for board online record date. Authorised by: bantu
remove unnecessary query parts... thanks to asinshesq for pointing it out.
move up the feed code because MODs often use this location which results in more unneccessary conflicts.
Fix login for passworded forums - Bug #51265 Was a regression from r10067 for Bug #50285
Fix bug #51075 introduced in r10121.
Further adjust unread tracking query, should work now for user last mark times less than forum/topic mark times.
Rename get_unread_topics_list() to get_unread_topics(). Cleanup: Remove some stuff we no longer need. Related to report #46765
Fix retrieval of unread topics list. The old queries were too heavy, using temporary and filesort and actually only based on topics being retrieved before. Instead now use one query which is also a lot faster and yields the same results.
Adjustments to r10005: Use request_var() to get cookie data. Some more adjustments to get_unread_topics_list() Related to report: #46765
#50675 ; also don't reset the captcha on login
Fixed bugs #43145, #44375, #44415 and #43045
Save some calls here, since page_footer(true) gets called quite often.
Only embed cron.php if there is no cron lock present to reduce overhead. (Bug #45725 - Patch by TerryE)
Addition to r10060: Add function documentation.
Simplified login_box() and redirection after login. S_LOGIN_ACTION can now be used on every page. (Bug #50285)
Send service unavailable response code for E_USER_ERROR
Fix Bug #49195 - Queries on un-indexed column user_email Added function to generate email-hash.
Authorised by: AcydBurn
Change of r10055, which itself was: Adjustement for r10050, related to Bug #50185
Instead of S_TAB_INDEX we now use a method suggested by nickvergessen - we simply DEFINE the tabindex for the captcha depending on where it is included.
One more unread posts search adjustment. Authorised by: AcydBurn
Adjustement for r10050, related to Bug #50185 Use internal S_TAB_INDEX instead of DEFINE
More unread posts search adjustment. Authorised by: AcydBurn
Better tracking of global announcements Authorised by: AcydBurn
i know, i know, no need to hrm me. :P - r10009
no need to call generate_board_url() twice - r10008
Ability to define constant PHPBB_USE_BOARD_URL_PATH to use board url for images/avatars/ranks/imageset... This feature does not change anything for those not using the constant and this feature is also quite in-flux. We need to test this with some applications and bridges and there may be other locations able to benefit from it.
Add unread posts search support for cookie-based tracking Authorised by: AcydBurn
i am very very sorry for this hackish approach... (ability to skip add_log calls)
Fix r9961 - populate who is online only where required
r9961 - also set item name in page_header parameter for better implementation of #31975
ok, i am very sorry, but this needs to be fixed. Generally, our config table is not really suited for holding large datasets. Because feed settings for the forums to enable news feeds and excluded forums rely on the forums itself we have decided to introduce a forum_options table where custom options can be stored....
populate who is online only where required
change item to item_id; related to #49485
Fix bug #15729 - Global announcements marked as read if all new topics in forum are viewed Authorised by: AcydBurn
log general errors in cron, images and when debug is enabled
and for pseudocron too (to conisder: log db errors to debug faulty cron jobs)
add the option to place image debugging information to the log
Adjust build_url() to not prepend $phpbb_root_path if path returned from redirect() is an URL. This fixes redirect issues with some installations and bridges. (Bug #47535)
Fix tiny typo in r9884, #46765. Thanks rxu.
Move get_unread_topics_list() up in functions.php, added some documentation. Related to #46765
More small adjustments to get_unread_topics_list(). #46765
Fix r9855 for #46765 Authorised by: bantu
Minor captcha API change - disable display of plugin by returning false in get_template.
Fix r9755 for #46765 Authorised by: ToonArmy
fix r9758
Ensure user errors are displayed regardless of PHP settings. #47505
#42925
- PHP4 compatibility
Feature Bug #43375 - Ability to delete warnings and keep warnings permanently
Fix bug #46765 - View unread posts Authorised by: AcydBurn
Fix bug #47775 - Properly convert and show filesize information Authorised by: naderman
Fixed Bug #24075 - GZIP status is not showed up correctly in debug mode Authorised by: AcydBurn
Fix r9728 - It does actually not work that way. ;-) Authorised by: naderman
Fix bug #47785 - Fetch requested cookie variables directly from cookie super global. This should fix a problem with phpBB installations on PHP 5.3
Authorised by: naderman
revert r9653 because it does not work as advertised (a load of bugs and not really what we wanted... back to the drawing board ;))
- Fix XHTML for r9666 - Utilize $captcha->solved property - Only validate captcha once to retain captcha mode over switching from/to agreement page
Fix bug #46765 - View unread posts Authorised by: acydburn
Fixed bug #43125
rename user_id in confirm_box to confirm_uid. We are able to do this because confirm_box is completely transparent to the outside.
Fix bug #31975 - Enhance obtain_users_online_string to be able to return user-lists for other session-items
Authorised by: acydburn
- [Feature] New "Newly Registered Users" group for assigning permissions to newly registered users. They will be removed from this group once they reach a defineable amount of posts. - [Feature] Ability to define if the "Newly Registered Users" group will be assigned as the default group to newly registered users....
Use dynamic includes, fix some style bugs, make the old default captcha family backwards compatible to 3.0.5 styles
First ATOM Feed commit/integration - Idea and original RSS Feed 2.0 MOD (Version 1.0.8/9) by leviatan21
Fix dynamic config update routine error if firebird is used (Bug #46315)
some corrections, only very minor things.
Correctly determine writable status of files on Windows operating system. #39035
Okay, a first ci of the new captcha plugins. We'll add dynamic template includes later, as well as documentation on how to use this. I'm prepared to get yelled at for bugs (oh, I know that there are plenty); but please blame spammers for broken styles and MODs.
suppress warnings (stat failed). Though may be good to know... why!
#43755 - also return GiB sizes for get_formatted_filesize(), patch by nickvergessen
a language alteration for captchas. Added min/max captcha chars constants and changed the length from 5-8 to 4-7
fix unkown variable problem. ;)
SQL optimisations
Fix race condition for updating post/topic/etc. counter. (reported by BartVB) please do not try such fixes at home - the correct solution would be to create a second config table with integer columns. ;)
backport 3.2 version of phpbb_chmod() - need to be tested further...
Tiny change to accept back slashes for Windows paths, phpBB passes forward slashes but other code might not
remove the cache for the session lookups. Actually, the disk reads/writes are more expensive than the sql queries. At phpbb.com for example this results in excessive disk access and more than 1000 cache files. This is not acceptable.
Add same redirect disable_cd_check parameter to meta_refresh - #38065
Slight performance increase for common parameter calls to append_sid() (Bug #37555 - Patch by BartVB)
Fix potential issues with the stat cache and phpbb_chmod()
stupid PHP manual :@ the two parameters to clearstatcache() are 5.3 only. Fix r9144
Let's face it - the most common setup we see with phpBB is having group-specific settings for external users (FTP, whatever). Changed phpbb_chmod() to set the group bit, even if the PHP user is the owner. (somehow this sounds complicated, i hope you get the idea).
inheritance is reflexive
- Do not show link to user/group profiles if user has no permission to view the linked page and gets a denied message anyway. (Bug #15088) - Do not display last post link and sort display options for search engines. (Bug #15088)
Remove NUL-Bytes directly in request_var() for strings and within the custom DBAL sql_escape() functions (MSSQL, Firebird, Oracle) (reported by AdhostMikeSw)
further adjustments to exit; statements force E_USER_ERROR to exit always - it is always a fatal error which should stop every execution happening
check fields properly not being set sometimes. ;)
Set secure cookie for style switcher if required. (Bug #19625)
Extra slash is included in the redirect url when redirecting to the forum root directory. Closes #33605 Fix small mistake in CHANGELOG
Show users posts in queue in acp and profile + link to mcp
fix installation by defining our needed CHMOD_READ and CHMOD_WRITE constants.
fix a small glitch in phpbb_chmod
some changes for proper code documentation
change the way we do chmodd'ing. I know, my implementation really sucked... good we have motivated community members who point this out. ;) Thanks to faw for providing a way better function and for discussing and also abiding to our needs. :) LEW21 should maybe credited too... he gave the inspiration without knowing it.
comments
as per evil3, some more anti-CSRF
the chmod change i already had within the changelog (by mistake). This should further secure writable directories and created files. Installation need to be tested on different hosts.
fix cookie secure detection... hopefully
cleaning tpl fallbacks up
tiny alterations/bugfixes
Bug #29635
New parameter for redirect() to circumvent the cross-domain check.
further checks on maximum storage length
remove the $Id$ line there and instead add valuable information. Oh, and did not know the phpass project catched our implementation of their code. :) Nice to see.
added two comments to describe the functions use-case
Regular expression for email matching in posts will no longer die on long words
#27395
typo
Some xenophobia
ok, well, my team is allowed to give me some slappage. :/ I now changed this sooo often and never realised the code portion is absolute rubbish... with ini_get returning something completely different. Now, this should work (at least for PHP 5.2.x) - tested all 16 possible combinations of triggering errors before and after headers sent, with and without gzip compression, with and without output buffering. Now, please work for others too...
Too much for a minor; sorry
a little polish
give the ACP a login screen
we slowly get to it
did i ever mention that i hate php's handling of buffers (or i simply do not understand them)
Remove caching. Ideally, this owuld depend on the current load
suppress ob_flush() output and flush() at the end (within my tests this solved blank pages on some setups and do not affect gzip compression).
Hiding everywhere little buggers, eh?
some corrections to let the update work flawlessly.
#24105 - Quite compliacted lang changes, translators will complain :|
Allow & and | in local part of email addresses - #22995
i think i will stop committing thinks today. :/
i somehow mixed my local copy with the changes
grr
hmm, still bugs there
- some changes to the recent session change - display errors on inserting sessions - fix database updater
meh
This should get rid of the filesorts and temp tables on index (with topic read tracking as exception). Updater still needs testing. Not yet merged to 3.1 #22715 - thanks HoL
and the API
some language/style/code fixes (refer to the diff of the changelog)
Fix Custom BBCode {EMAIL}-Token usage - #21155
Fixing realpath issues for provider returning the passed value instead of disabling it. This fixes issues with confirm boxes for those hosted on Network Solutions for example. - #20435 many thanks to the reporter for allowing me to debug this on his server. :)
One commit for those fixes having a very tiny impact (mostly only whitespaces or forgotten spans, etc.) Although i somehow mistakingly got #20445 and #15249 into it. :/
Removing s_watching_img from watch_topic_forum() function (Bug #20445) Changing order for post review if more than one post affected (Bug #15249)...
#19955
Same goes for the 3_0_0 branch... Fixed a problem caused by "-x-" variations of a translation, such as fr-x-strict and de-x-sie. We're now sending the main language code to the output so it will at least be a valid language code
This commit was manufactured by cvs2svn to create branch 'phpBB-3_0_0'.
Late fix for #16174
wonderful, another change... now come slap me to death... conquering mars.
- Constant PHPBB_DB_NEW_LINK introduced which can be used to force phpBB to create a new database connection instead of reusing an existing one if the dbms supports it [Bug #14927] - Automatic URL parsing no longer allows dots in the schema but can parse URLs starting after a dot [Bug #15110]...
some further fixes - re-introduce grabbing random number from /dev/urandom
some changes
fixing one severe bug showing since 5.2.4
Lesson learned.
#14679
new clicky thingies.
example.com
dumdidum... sorry. ;)
#i43
#i42 new password hashing mechanism for storing passwords
#14621 #14596 info file changes
- fixed database updater - fixed hook function call in database updater - fixed bot agent detection (we used a wildcard within the w3c-agent, therefore we should really support this. ;))
remove one problematic instance from the realpath replacement
#i41 (basically do not allow autocompletion for admin re-authentication)
Ok, here comes a big one. Poor updater. Also requires testing.
#i91 #i92 #i93 #i94 #i95 #i96
#i8
#i112
#i66
new hook system (do not get it confused with events or plugins please) - introducing two new hookable functions too
#i62 - #i65 gone through every javascript invocation and making sure we adhere to our coding guidelines.
#i61
put expressions for ip validation into our get_preg_ function.
some fixes. :P - language authors may review their email template files...
- http://www.boardlocation.tld/phpBB/ links will not get an extra trailing slash with magic url anymore [Bug #14362]
necessary changes...
- make sure the copyright/disclaimer is consistent - two fixes...
fix for bug #14165... hopefully
away with debug code...
- BBCode parsing order should ALWAYS be censor_text(), bbcode_secon_pass(), bbcode_nl2br(), smiley_text(), parse_attachments() - using \r on custom bbcodes to allow line breaks [Bug #10758]
- strip_bbcode should not treat smilies which look like BBCode and are placed in front of a closing tag as BBCode - highlight in post subjects and topic titles - language entry SMILIE_ONE_ADDED should have been SMILIES_ONE_ADDED
some bugs fixed
Some changes... non-invasive...
some tiny fixes and two new features. ;)
err, forgot to commit
clean up
remove T_THEME_DATA completely... now the css data is able to be fetched for banned users too. Gives us a good chunk of memory back.
- search result extract shouldn't end in the middle of a multibyte character [Bug #11863] - missing localisation for an imageset shouldn't create lots of "imageset refreshed" log messages [Bug #12027] - explain that themes which need parsing cannot be stored on the filesystem [Bug #11134]...
even more fixes. :o
a bunch of fixes
#13315
allow what is stated within the changelog...
some fixes
#13121 #13093
let's see if i can break something. :o
tweak the sql_like_expression feature a little bit to allow correct escaping
new wrapper for LIKE expressions to streamline the fixes. We actually need to adjust them for different DBMS as well as SQLite2 not supporting escaping characters in LIKE statements (which is a reason why we think about dropping sqlite support completely).
Fixing a few things for postgres. Thanks to wagnerch for researching the issue and providing a patch. #12587
try to support -- in smileys by not using comments within post text display...
Changing the behaviour of the hideonline permission.
Test the current setting before altering the memory limit during install(Bug #12195)
And another language var.
my round of bug fixes
ok, mess around with the templates + fixing some bugs + adjusting headers for those files already modified to circumvent conflicts for those having their editor set to remove trailing spaces (not recommended!)
do not put mailto: in front of the text if parsing email address
- Send stylesheet in style.php even without a valid session id [Bug #11531] - request_var should strictly return the requested number of dimensions - corrected a character mapping in the search indexing character list, people might want to reindex after this change if they use fulltext_native
fix an improper fix. - generally, sorry, but direct url parsing after ] will no longer work... - try to eliminate the most common "bug" for placing urls within the [url=][/url] part (the text). This will trigger make_clickable and render the url invalid (doubled url), moreso if other text is involved too. This is still te case if the url is not written directly after the [url=] part. This is nearly the best we can get within 3.0.x - and every report about [url=], [url] and make_clickable and it's non-parsing or parsing will be closed with "will not fix", except it is a critical bug resulting in the non-functioning of the board. We may adjust this later to our own liking while we try to find different ways to face these problems.
we included a check for getimagesize() existance... now we again can suppress notices while running this function.
those little things. ;)
The Grand Copyright Year Unification... breakdown of years, of re-copyrighting due to major changes:
2000 - phpBB1.0.0 released 2002 - phpBB2.0.0 released & phpBB2.2.x commenced 2005 - phpBB2.2.x is canned with phpBB3.0.0 to succeed it, prosilver also starts development proper...
#11074 - only process and check (as well as display) images if the category also matches. ;)
Making logout somewhat more secure.
Language variables, take them while they're hot. (just one, so be quick)
#10956
#10948
#10883
- use /48 and /64 subnets for IPv6 matching [Bug #9538]
- correctly transfer the search query across search result pages - changed highlighting so foo* will match foo again [Bug #10031] - restructured magic urls (functionality still mostly the same), added a check for entities in urls and punctuation at the end of magic urls [Bugs #10639, #10293]...
#10617
fixing some bugs changed the way we are handling bookmarks. No order_id required, really! Order by last post time as suggested by BartVB.
#9828, #10545, #10541, #10533, #10529, #10527, #10521, #10503, #10481 - more label fixes - simpler approach to get input cursor text
Stragglers that got missed during ACP prosilver-isationageing.
added class for disabled options in ACP E_USER_ERROR now using language keys if available [related to #10445] UCP/MCP title tags [#10441] Check $start parameter in viewforum [#10435] Check for postable forum for moving user posts within users ACP [#10433]...
some language-specific adjustements fix prune users (adding the list of users to the confirmation page) tried to fix the show/hide trigger in ACP by not using width: auto; (which gets somehow inherited to each other element)
#10283 - no style if banning anonymous/ip and using style requiring stylesheet parsing. Also fixes a bug for non-parsed THEME_DATA...
email preg
Prepare to be yelled at and brace for the tide of bug reports: I had hoped we would not have to do this, but it seems that we have to.
-Route all avatar downloads through download.php - adrien -Change the way inline attachments are delivered -Fixes a few (unreported) bugs, notably avatar upload during group generation...
- * wildcard in a search query should cause \w+ in highlighting, not \w* [Bug #10031] - display a warning that the search index is not converted from phpBB2 to phpBB3 [Bug #9761] - forgot to add : to reg_name when deleting userinfo from the url regex constructor [Bug #9868]...
- magic urls should have class="postlink", added class="postlink-local" for relative magic urls [Bug #9867] run develop/adjust_magic_urls.php to modify your post/sig/pm contents to use class="postlink" - corrected a few bugs in fulltext_mysql stats [Bug #10165]
changed the cache files to save some memory (all global ones are hold in memory, doubling it).
make it work like viewtopic
#9836
- m_warn is no longer a local moderation permission - magic urls should properly use html entities - speed up posting on big boards, MAX query can be simplified a lot in certain cases - user IP list should be labelled with "Other users" [Bug #9707]
Revert and undoing bug #9736
Won't fix, at least for 3.0.x. Re-review come 3.2.x and perhaps may be able to get localised prefixes, so something like:
Sv: Re: Antwort: <Subject>
... doesn't happen. :P
#9736
Quidquid latine dictum sit, altum sonatur... redux! :P
Quidquid latine dictum sit, altum sonatur. :P
revert this change. It is actually not a bug. We use append_sid on view to let relative links correctly work.
ticket #9599 - Nils, please review!
#9578
#5386 - make new/unread private message variables available (holding the number of said private messages)
other fixes...
some changes/bugfixes
not doubling notices...
again, some changes here and there...
some fixes... hopefully not breaking something. :o
small redirect fix. ;)
#24601 ;_;
#8632
#8618 + padding store check
apply correct check for hiding session
again... some more fixes.
- fix some group specific bugs - correctly determining terrafrost's birthday mod
- small MSSQL thing - changed how we store tracking data
- added a UNIQUE index on the wordmatch table - some modifications of search indexing which might improve the speed and hopefully fixes [Bug #8352] - added logging to search indexing [Bug #8384]
"Reintroducing" S_CONTENT_DIR_LEFT & S_CONTENT_DIR_RIGHT as S_CONTENT_FLOW_BEGIN & S_CONTENT_FLOW_END, but rather than taking values from ./language/xx/common.php (which often got translated when not needed, eg: to French, or just plain not used at all, swapping left=>right and right=>left in RTL mode)....
#8282
- fix htmlspecialchars handling in search (search backends get specialchared input, and should return specialchared output), current backends strip entities anyway [includes Bug #8156] - allow cancelling search index creation/removal - custom CSS class name input too short [Bug #8328]...
trying to fix some bugs...
no h2
do not rely on admin style for E_USER_ERROR messages
#8254
fixing some bugs more mcp links for easier moderating different aspects (all, forum, topic) i may have introduced new bugs with this commit due to me having fixed some things weeks ago and some code changed in between - please report if you see something not working as expected.
- Pruning doesn't lower user post counts anymore [Bug #7676] - Better resync explanations in ACP - relative link to board shouldn't result in an empty link [Bug #7762] - allow spaces to define multiple classes [Bug #7700] - forgot addslashes for password conversion [Bug #7530]...
adjust text for getting image dimensions as well as not suppressing warnings for getimagesize()
only some minor fixes
SEPARATOR, not SEPERATOR... also "neutralised" variable naming as it's used elsewhere outside of pagination. :)
#7424 - rebuild username_clean column due to changes in utf8_clean_string()
- fix some oddities (doubled spaces for example) - changed the way make_forum_select() is returning the forum list - now including skipped forums but being disabled. This should make identifying the correct forum much more easier. - Changed some permission namings based on suggestions by the community...
fixing some bugs, most being submitted grammatical/spelling errors.
fixing some bugs
ok, handled some bugs... the most important being validate_username (the variable passed to validate_data([...]array('username', [...])) and updating group listings while doing relevant group actions. Oh, and PM icons are working now. :o
- solved a problem with magic urls inside brackets, and with bbcodes being treated as IPv6 addresses - turn NOT IN () and IN () into 1=1 and 1=0 so the database will understand it, instead of throwing an error in sql_in_set [Bug #7118] - some tiny fixes to fulltext_native
- new homographs or IDN confusables ( http://www.unicode.org/reports/tr39/data/international.txt ) - also added character names to old homographs - pagination_sep theme option removed, PAGINATION_SEPERATOR can be set in language files and the theme can overwrite it using span.page-sep [Bug #6872]
- use constants no weird numbers ;-) - solved problem with \w using UTF-8 search (fulltext_mysql) by using PCRE unicode character properties if available [Bug #5768]
- allow login with redirect parameter - altered URL regular expression so it won't cause problem with long URLs - PCRE >:( [Bug #6720] - moderator list on index should have coloured groups in bold as everywhere else too - correctly handle password requirements in UCP [Bug #6692]...
- removed download mode selection (the column info and constants will not be removed, we or others may be able to re-use them later on) - removing extension from physical filename for uploaded attachments (as has been suggested some time ago from our community), can still be used by using the new 'unique_ext' mode on file cleaning...
- do not allow setting the parent to currently assigned childs [Bug #6708] - Allow the display_on_index setting to be specified for link forums [Bug #6660] - Rank code in functions_display.php [Bug #6656] - Added some new locations for the viewonline page [Related to bug #6484]...
Unused Code inside function update_forum_data [Bug #6606] Copy permissions protection for groups [Bug #6594] HTML issues in ACP [Bug #6580, #6578] Always send the correct encoding [related to bug #6576] Mass email fixes for first loop iteration [Bug #6570]...
- display search type as page title for premade searches [Bug #6508] - flash enabled on user side by default, so that admins can actually change anything by activating it (still disabled by default) - properly implemented password complexity check [Bug #6584]...
some fixes today - most important change is the consolidation of the display attachment functions; merging them together to have one function we need to call.
regex man strikes again!
#6462, not a bug unless you run a version of PHP 5 that is less than 5.0.4...
#6436, thanks ToonArmy for the patch :D
- Optimize acl_getf_global a bit - a little performance improvement of the IP regular expressions - convert post_text/subject collation to utf8_unicode_ci if a user wants to use mysql_fulltext to allow case insensitivity [Bug #6272] - mysql_fulltext should alter all necessary columns at once to speed up the process...
proper solution to #6114, guarantees $seed lies below 0x7FFFFFFF
- re-add script_path for "strange configurations" to let them force the generated urls correctly - show rank title if no rank image present in memberlist - other fixes.
#6076 - removed unused junk from functions.php
minor bugfixing
oops :D
#5734 - replaced array_rand($array) with mt_rand(0, sizeof($array) - 1) as array_rand did not take my seed
some tiny bugfixes.
- a bunch of fixes - added todos to the updater to make sure i do not forget. :)
better layed out...
#5610
Using a different approach for the data updates (same as the schema updates)
blah ..
#4892
- bug fixes for #5618, #5588 and #5584 - remove messenger->reset() calls (they are already performed on sending)
rather large update, most important things done: - implemented provided patch/diff file for bug #5350 (Highway of Life) with some tiny changes and alterations - more username/colour changes/fixes - added a note about PM rule-dependant message removals so the user is not wondering too much if he can't remember his rules. :)...
decrease the barrier for E_ALL error reporting and email traces from DEBUG_EXTRA to DEBUG
- fixing a bunch of bugs - moved the install trigger error to sessions and also disabled it for those having DEBUG_EXTRA enabled. i hope not having introduced too many new bugs.
some tiny fixes.
#5446 - slight opti thrown in :D
- a handful of mcp fixed, the most important one is the change for check_ids() - it is now supporting ids from more than one forum too, making it possible to use some mcp features as designed initially. We really need to get our moderator team testing the mcp extensively....
#5376 - removed some unneeded globals
adjust some comments to work with phpdocumentor. :)
ok, change from doing the same logic all over again we call a function to do it for us. Also allow template designers to choose which method to use by just adding a fully compiled username string (profile link + user colour). This commit may introduce problems.
- fixes for the following bugs: #5326 #5318 #5304 #5290 #5288 #5278 #5276 #5272 #5266 - also fixed the "Call-time pass-by-reference" bug #5252 - within this step changed the normalize calls to require references. - added captcha size variables to the class scope (suggestion was posted at area51)
consistant obtain_* functions
message
- some fixes - added script for easy adjustement of username_clean column within the users table (please see the note i added to the utf8_clean_string() function)
- use the $var_ary for settings in a more logical way (hopefully removes the clutter and shows where which variable is set how) - hopefully utf8 passwords are working too now
- compress is nicer (fixed a bug :P) - UTF-8 code is nicer (fixed a bug :P) - new CAPTCHA. Replaced the old one for size and usability issues. The old CAPTCHA will most likely be released as a separate package
ok, i am an idiot...
- implemented the suggested html_entity_decode function made by david - fixed string length checking by also decoding entities for the sake of checking - used the new html_entity_decode function
some updates; and hopefully not completely breaking redirects (again). :D You know, i like breaking things.
Changing regeneration of the rand seed
Add an optional flag to allow the disabling of generating the cron image for pages if appropriate
ENT_COMPAT is the default, with ENT_QUOTES a few features will no longer work.
- now username changes should work as desired - removed some extract() calls
Revised attachment categories a bit Fixes for the following bugs: #4830 #4818 #4816 #4810 #4808 #4798 #4796 #4772 #4662 #4646 #4546 #4524 #4270
I hope not having introduced additional severe errors :)
- typo in functions.php - #4826
let the forum link work again (we do not need the removed check because the board url is always prefixed, except for those urls having a valid scheme and host part)
looks like nobody ever found this bug :D
if we want a string, don't close the DB and cache
- store sql_layer directly within the layer itself - new method sql_multi_insert to circumvent db-specific hacks (hopefully not introduced any parsing errors)
- introducing clean usernames, needs to be tested more, I'm not sure I didn't miss anything - homograph list should probably be extended
some test code, hopefully working for all occassions where we are using the functions...
- make sure all sort keys are valid and selectable.
do not use parse_str because it could lead to "unexpected" output which could lead to XSS
he braces style is deprecated as of PHP 6
better not. ;)
strpos...
tried to begin adjusting all string functions where applicable - still a lot to do. i hope i catched all relevant sections and did not mess something up.
- support re-caching of theme data if stylesheet.css changed and load_tplcompile enabled - mcp fixes - fixed some usability issues
- extend config checking to include check for writeable path - removed not utilized user_allow_email column from schema - removed inactive groups (they had no use at all, since inactive users are not able to login) The only benefit those brought are distinguish users - but this is no longer needed too due to the inactive code present. This also allows us to retain group memberships as well as default settings for users being set inactive due to profile changes....
consistent acp layout regarding backlinks and messages.
Prevent cookies from other applications interfering with our forms
of course $host instead of $domain
err, no, from the php manual actually... the zend function has some security issues.
- added confirmation to removing bbcodes - added optional MX and DNSBL checks - added backtrace (triggering sql error) on error within sql_in_set as well as making sure it is handling an array - let users having f_list access to a forum actually see the forum without a topic list and not displaying an error message - this allows for giving people access to subforums but not the parent forum without the need to add the (sub-)forum to the index....
some tiny fixes here and there
- no more encoding mixture, say hello to UTF-8 (I'll add a validation solution for PHP 4.3.3/4 ASAP) [side effect: fixes Bug #3762] - take local server time into consideration for birthday/age calculation - faster active topic search - allow changing active topic time frame [Bug #4150]...
implement bare-bone validation for config variables...
- fixed some bugs - changed attachment handling a bit - tried to remove target tags out of the code - do not add session ids to urls for bots as well as not creating a new session on each page view for them
I bet i introduced some bugs too. ;)
- fix security issue in download.php - fixing some phpdocumentor warnings/errors - adjust pop-before-smtp "auth" (nowadays no one should rely on it) - add backtrace for smtp email errors if DEBUG_EXTRA is enabled
- fixing profile bug - adjusting acl_gets calls (they are or'd - make sure they get checked correctly based on the situation) - automatically assign the u_download and u_search permission to the guest group
some changes/fixes
fix some bugs - hopefully not breaking anything...
- birthdays/age in user's timezone and not server's local time - parse bbcode in posts with fewer characters than selected maximum on search results page - retrieve search word context in posts which are longer than maximum characters (no raw BBCode anymore)...
- some bugfixes - using E_USER_WARNING if an error occurred within the ACP (sadly not able to use it as a default for trigger_error - it seems to be hardcoded in PHP)
fix redirect if we are within the admin directory (not /ucp.php but /{admin_directory}/index.php)
some updates. Also adjusted the utf tools and normalizer more to our coding guidelines.
- getcwd replacement - realpath stuff thanks to Chris
If i could force you all to use PHP 5.1.0+, then i could just use the count param with preg_replace. Oh well...
sql_in_set changes
so.... what does this thing do?
well, the super fast, ultra efficient, massively huge BBCode handling system was implemented differently on each DBMS. Although this provided the best performance, the solution was a bit hacky.
So what does this new thing do? We use base64 encoding to make everything nice and shiny, it turns into nice, safe characters that we can just jam into varchars on essentially any database. This has two implications: we must decode every bitfield we get AND we have slightly fewer IDs to work with. It goes down from 2040 BBCodes to 1512. We lose like a quarter of them :P...
- load tracking updates. Need to be tested on a clean installation too - at the moment only tiny quirks are noticed at area51. - reported bugs fixed
- finally making the age calculation work [Bug #3582] - replacing all occurances of L_NONE with a more specific string [Bug #3494] - a few corrections to html id attributes in the installer - using correct permission in mcp_report [Bug #2471] - allow deleting the avatar, when no upload method is enabled and hide the delete button if no avatar is set
- fixing some bugs - shortening some db columns to meet the requirements - correctly increase/decrease user post counts - fix the topic title length bug(s)
OK...
This commit should increase the total number of BBCodes from 31 to 2040. Some things to watch out for:
Each database likes to deal with binary data in its own, special way. They are, quite frankly, too cool for school.
MySQL, MSSQL and Oracle all allow me to send in a default value for their binary column using a hex number. However, MSSQL forces me to send the specific data as a hex number and thus we must CAST it....
hmm... This commit does not increase the number of BBCodes. However, this does other things that we need to do first. This splits the usage of allow_* from the BBCode bitfield in forum descriptions, forum rules and group descriptions. This also fixes a tiny, tiny severe issue that nobody found :D I hope it works :P
add not applied sql_escape in memberlist
- renamed the following columns: comment -> attach_comment new, forwarded, unread, marked, deleted -> pm_new, pm_forwarded, pm_unread, pm_marked, pm_deleted module_name -> module_basename value -> lang_value
- every column is now NOT NULL - every column is now having a DEFAULT value...
- tackle some usability issues - fix bug #3147 - added the lock-images made by SHS` - fixed MSSQL errors (adding the correct ESCAPE sequence)
some bugfixes
re-check cookie_secure value within generate_board_url() for those users having it enabled but not running on a SSL connection (which of course results in server errors). This should (hopefully) further minimize support requests. ;)
Thanks again to aninhill for giving me full access to his board to be able to spot this error.
- fixed language pack management a bit (supporting backslashes) - fixed ftp_fsock, also fixing a reported bug in there
- add additional auth check to the permission roles modules - added new function to return globally used expressions (get_preg_expression($mode)). This should be very helpful in getting wide spread similar checks (regular expressions) to one place reducing the risk of forgetting to change every location if you fix one. ;) We will add additional ones later, at the moment only the email check is retrieved......
Show message to those browsing whilst board is disabled
ok, first attempt at solving some compatibility issues. - dropping in replacement for realpath
make sure set_config is called with the correct is_dynamic value
time to squash some bugs
- removed db cache (might re-appear, but for now we do not see the need for it) - all changes to styles/subsilver/template are purely cosmetic (no functional changes) - cosmetics - bugfixes - add index to modules table - use modules ordering code for forums too
make sure custom profile fields are created correctly on registration (#2225)
- added class="radio" to all radio- and checkboxes - make sure the database gets closed correctly in cron.php - bugfixes
- get swatch converted into new acp format - add page title to ucp pages - add ability to supress getting the who is online list in page_header() (saves us ideally 1-2 queries on ucp/mcp pages) - fixing pm rules a bit as well as now having complete author memberships for author_in_group (sender -> is in usergroup -> xxx)
removed the ability to parse after closing brackets, since this seems to create a bunch of new problems added a space after quotes for correctly parsing urls/smilies instead of splitting the url just compare with strpos david: please review once you get home. :)
;-)
try to prevent re-parsing of parsed bbcode content
- BBCode bugs - PostgreSQL now gives us database info (if you are running 8.1 or have the dbsize contrib module installed)
Hide search links if you are not allowed to use them (if we're not sure, then they are displayed just to be safe)
Another bug bites the dust
- fix some smaller bugs - removed custom profiles preview field from acp
ok, this one is rather large... the most important change: re-introduce append_sid: old style continues to work, not a performance hog as it was in 2.0.x -> structure is different
apart from this, code cleanage, bug fixing, etc.
correctly re-init auth array on login/logout (bug #2055 is related to it)
- create forums by default - hide prune options if not enabled - fixed module management enable/disable switch if in module itself - fixed some schema errors - adjusted $user->page array generation for developers calling scripts outside of phpBB root
- do not allow pruning founders - do not display full path to installation in error message text (only occurence would be "header already sent" warnings)
- remove description from profile fields - added disclaimer about DEBUG_EXTRA to the ACP (i think this is needed - some idiots might think it is wise to have this enabled on a production board. :) We may let it there for the Betas though, but it will be removed during the RC's)...
some tiny changes...
- fixing a few smaller bugs/glitches - init user session in cron.php (else it can produce errors if functions expect the user object being set) - fix sql escaping for mssql/mssql_odbc
- fixed dotted topics on some occassions being wrong - fixed post author change - fixed moving topics (they should not count into read tracking now) - think about having only one column for shadow topics/similar to forum links - moved a function from functions.php to functions_display.php (this function is only used by viewtopic and viewforum which already include this file)...
- fixing a few tiny bugs - added new function to (re)apply sids where needed (login and mcp quickmod) - #1829
- added a few missing log variables - include acp/common.php language file if displaying logs (LOG_ variables should be stored there only now) - added check to cron.php - added database_gc config variable - recalculate binary trees every once a week ;)
- captcha stuff - unique_id
using another approach
- introduce new function build_url to easily build a valid url from the user->page object as well as optionally removing certain keys - changed attachment config to utilize the config build methods - cleaned up posting.php - the submit/delete_post functions are now usable (functions_posting.php)...
- introduce LA_, UA_ and A_ template variables (they allow styles to use template variables used for javascript in subSilver outside javascript in their own template while they won't break our javascript if they contain quotes) also fixes [Bug #1116] - corrected page title for search indexing progress bar [Bug #1695]...
- put the error reporting check into another location (since we do want to display our notices. ;)) - default error reporting in common.php - E_ALL being set if DEBUG_EXTRA defined
- fix bug #1727 (need to be watched - problems could arise by this change) - added a note about login_box() to the coding guidelines
- slightly adjusted the DEBUG/DEBUG_EXTRA requirements - changed error_reporting to E_ALL - our error handler now takes the error_reporting value into account allowing us to correctly supress notices
- fixed ul/li margin - fixed [code=php] tag (tags got mangled on edit) - fixed a tiny issue within the ban function
- fixing some bugs, containing fixes for anonymous username displays, eaccelerator issue, permission trace and a few smaller bugs.
- fixed gen_rand_string
Fix a broken explain link
- Bug #1285
- build explain links a bit different... - fix btn_ip reference (it is btn_info now) - removed sql_report.css (we use the acp css) - updated the sql report layout
- removed group settings from roles - added forum icon in front of forums in permissions acp - added trace permissions in permission masks (thanks naderman for writing the first code and for the idea... :)) - some bugfixes - PHP6 fix
OK< so it did break it - copy and paste error
Porting the random number generator code over Fingers crossed that this doesn't break anything.... ;-)
- clean up marklist calls (global function) - added new feature: test out others permissions (admin permissions will not be copied) - changed attachment processing by directly using the template engine - fixed some attachment related bugs - additional tiny fixes
i do not think i need this any longer. ;)
- fixed some bugs - made sql schemas consistent - added correct sequences and generators to sql schemas - extended some rows to hold more data. This solves issues with multibyte characters and too short topic titles, names, etc. - allow multibyte characters in usernames
- check m_ permission for quickmod [Bug #1317] - don't sync the global forum (id 0) [Bug #1383] - corrections to available time zones [Bug #1306] - only display open reports on mcp_front - added whois information to mcp_post [Bug #1400] - copy "dot" when copying a topic [Bug #1321]...
#1362 - Url shortening error on local URL's
#1264 - fix redirecting if page dir is empty
changed the way re-authentication is handled, basically hardening the process. - also forbid re-authenticating as another user.
needs further testing.
my attempt to fix custom profile fields
- added the load settings for custom profile fields - re-added our famous make_clickable function - removed group_by clauses (due to the lang id selection the group by clause is no more needed)
I hope that i have not just created new bugs. ;)
- extended session_page and user_lastpage to hold a maximum of 200 chars (instead of 100) - session_page gets truncated to 200 chars - streamlined the process of generating text with bbcode/smilies/urls (forum rules, forum descriptions, group descriptions at the moment)...
adjusting sql_freeresult a bit as well as our error handler (it now prints out if it is because of DEBUG_EXTRA being defined - which is not enabled within the betas/rc's and stable releases).
- a bunch of bugfixes. :P
- fix some bugs...
- adding ability to assign moderator specific ban options - fixing destroying of sql caches - fixing referencing of sql cached queries if more than one are active on one page - other fixes
We now return the log_id of newly created logs. This is used by the warnings code and may prove to be of use elsewhere or in MODs
erm... actually remove the debugging thingy... holla
slightly different redirect function (now hopefully able to handle all sorts of uris)
- added users activity load setting
- streamlined reports to consist of the feature set we decided upon (Nils, your turn now) - use getenv instead of $_ENV (with $_ENV the case could be wrong) - permission fixes (there was a bug arising with getting permission flags - re-added them and handled roles deletion differently)...
- Moved the image loading outside the big loop. This brings fewer comparisons and allows us to unload the image data sooner. - Used a more appropriate method to break the images into chunks.
- fix cookie shortening - let the acm handle the module cache - call $cache->save() after destroying data if necessary
- By default, new installations of magick add itself to PATH and not to a variable that it creates.
Expire issued warnings after and admin configurable time TODO: Add config option for this value to the ACP
- some bugfixes - committed coding guidelines as they are at area51 - removed script_path (needs a close inspection later) - removed the need for server_name and server_port - able to define server port/name/protocol and force the user-defined server vars (very handy for proxy setups)
just remove a little error message that came up in a very seldom situation
implementing permission roles
- copy permissions (adding groups) - copy permissions (adding forums) - checking proper groupadd/del settings - added intro page to permissions (to give an overview and quick links) - able to select forums + subforums, single forum, all groups, all users (permission screens)...
- fix some tiny bugs - fix module system (sometimes the layout is broken due to falsly deactivated categories) - auth updates (setting permissions) - fix "category jumping" bug in acp - u_action is defined by the module itself
display complete backtrace. ;)
my turn to break things... harharhar - checking in permission settings and permission masks - permission presets and documentation not finished yet - added backtrace function to determine file/line for sql errors - fixed marlist for orphan attachments/groups/logs/users...
- A MUCH better UI to editting an imageset :-)
- moved add_log out of functions_admin (this file should only be included in admin/admin-related pages) - fixed cookie based topic tracking - added missing config variables - other minor things
I'm removing the HEADER_INC check from the error handler to resolve incomplete output in some cases. If this causes a problem in a specific case, please let me know the details
- fix minor bugs
- size select fix - introduced function for building group options (acp) - fixed acl_getf if negated option needs to be retrieved - only using one function for updating post informations - fixing module display if module is disabled - if user is having a non-existent style do not print out error message, instead fix the users value and load the default style
- assign user rank - only a few very tiny bugfixes
- overhauled search system - updated structure for search backend plugins - better result caching using ACM - search results no longer session restricted => link to them by copying the URL :) - in-topic search - indexing posts now uses search backend plugins...
- array_combine replacement for PHP4 - properly send the charset
making sure coding guidelines are met... ;)
Updated the General Error page
- install style and style elements - refresh template and style cache
- mt_srand in unique_id working properly (swapped usec and sec) - mt_srand in digest_md5 removed
This was causing trouble on ppc, I kept getting the same random string (probably the passed value was too big). And "As of PHP 4.2.0, there is no need to seed the random number generator with srand() or mt_srand() as this is now done automatically." so I removed it completely.
- some changes to browser checking (was the reason for not working logins) - partly working style acp - other tiny changes here and there
- ok, get away with the secondary style approach (styles can be mixed together easily with the acp) - introduce a more generic approach of defining some additional variables through cfg files as well as the name, copyright and version fields - please note that at the moment this is in flux. I added it now for Tom because he needs the theme parameters.
Third time around, it turns out that the code where I made that mistake initially is completely unneeded since you won't get to this point if the user is anonymous (or a bot) anyway
Fix an issue with hidden users showing up on the online list if their global setting was yes but they had hidden for this session
I was told I also had to commit something today ;-) Hexadecimal should be in double quotes.
Adding the ability to change send_encoding needs a slight tweak to the code which tests it since it will now always be set
- custom profile fields - prune users - prune forums
- banning, disallow usernames and ranks
- some bugfixes - checking if page_header has been called already - call correct page footer function - rewrote avatar gallery - seperated compilation of template and template functions (new file: functions_template.php) - added assign_display function to template...
- added acp_language (language pack management) - minor adjustments to cope with PHP5.x
- some ucp changes (added the module info too)
- tiny bugfixes. ;)
I'm merging a few changes that we made to the session code in 2.0 into this code stream as well. This should work, but equally it might break the autologin :-)
- updated topic tracking code - additional changes (mostly bugfixes) - bart, if you update your user table with the user_lastmark field, set it to the user_lastvisit value ;) - and last but not least, introducing some bugs in ucp main front (regarding topic tracking)
- added new query type to dbal's sql_build_array - allow setting custom template path - adjusted module class to correctly parse trees with more than one category - added caching to module class
- some bugfixes
- move some functions from global functions file to functions_display (those only needed in posting and viewtopic/forum)
hidden fields adjustments
- added function for easily building hidden fields - extended confirm_box function (ability to use custom urls, ability to use custom confirm message)
- view active topics - seperated search id (int) from search id (string) for security reasons
- request_var updates - added group selection to pm filter - fixed activation/deletion of inactive user accounts in admin index - fixed some color swatch bugs
- some cross-db related changes - putting active bots array into cache
- some private message fixes
- test slightly modified topic tracking code - some bugfixes
- made path information available to template (T_) - eased topic/post icon in templates (removing hardcoded img) - added S_FIRST_ROW and S_LAST_ROW to template engine
- added updated coding guidelines - introduced is_registered and is_bot flags for correct determinition of guest/registered/bot users - changed bot code to act on useragent || ip
- fixed custom profile field get/store - changed tz lang array to hold more descriptive timezones (no more tz+-13, dst is a seperate option) - fixed bugs after jabber queue processing (data being escaped differently)
- Documentation related changes - added resend activation email dialog - fixed issue in session code - log failed/successful admin re-authentication/login - fixed simple forum dropdown box (used in mcp and posting)
- and my second attempt
change viewonline page slightly. Mental Note: Step away from using in_array in conjunction with huge arrays (and within a loop), might get slow. ;)
Fixed dotted topics on reply
fix admin_session "bug"
BBCode enabled profile fields, removed field_name from profile fields, fixed some uninitialised variable issues, some small conversion issues
- removed unnecessary pm options - added one option to clearly define email visibility
- bugfixes - default sort options for posts too - adjusted format_date to remove the (time intensive) preg_ calls - temporary style.php code.
- bugfixes - do not hardcode url bbcode tag (please change the bitfield accordingly - see schema file!)
Fixed small PM issue in header
...see if i am able to break the cookie tracking system this time. :D - made some session code updates - added new acl function (might be helpful later)
- fixed [code=php] - optimized db/mysql.php a little bit
Remove version information from display
- a bunch of updates, most of them bbcode related
- cur_page no longer in use - fix confirm box (since it used cur_page) :)
set correct dynamic config field if config name not present
Remove globalsearch action, no need
Global search action
- extensions_allowed changed a bit.
- more updates, mostly bugfixes to the bbcode parser - changed current_user in sessions (please review) - give more flexibility to style authors in regard to the pagination elements - profile fields updates (included a sample constuct into viewtopic_body.html - have to be documented extensivly)...
- print memory usage if available
- re-enable polls (user is now able to decide if users are able to change votes if this feature is enabled within the given forum)
my turn to break the forum (and at least pm's are no longer working - will not last long). HARRRR
This is a mass commit ... expect trouble! Changes made here are primarily to how login is handled, schema changes necessary!
- fixing some issues with the confirm screen - merging our (the devs) approaches (more fail-safe now) - fixing some small issues...
- remove output buffering options from download.php (not needed anymore) - optimized viewtopic.php a little bit - removed the create_function (was consuming too much memory) from viewtopic - check for manually added convert[.exe] program name to imagemagick path in admin_attachments...
- added folder_moved image - new feature: bookmark topics - fixed post details link - added confirmation screen to cookie deletion
- added delete cookies link - fixed global announcement links in viewforum - do not display redirects in link forums as posts in forum overview
- forum rules + link to forum rules - three new (tiny) functions added to functions_posting responsible for handling text with bbcode/smilies/urls, use them at items all over across phpbb... - some bugfixes within admin_forums and other files - new admin_board layout (much safer, security wise)
more updates
fix some issues with oop, fixing small bugs and prepare the next steps... NOTE TO DEVS: have a look at adm/admin_board.php (new config layout)
add a little bit more information for style authors ease the jumpbox handling a little bit
- check for array [lang] - admin_forums delete routine updated - added extension groups per forum
show correct login screen (accessing /adm while logged out)
splitted language files
always redirect on login (fixes the "i am not logged in" problem. ;))
- put consoring and smilie processing into functions (we use them all over the place) for better changing and consistency. - changed docs/AUTHORS to reflect the recent code re-use in functions_messenger.php - pleasing the users a little bit more by using table constants. :D...
hopefully fixed "mark forums read" -> db based tracking
gen_random_string move ... not entirely sure about this ... may well return to user functions
Enable redirect after login
Mark given set of forums marked, show "Mark forums read" link on subforum display
hhmm, string cleanup was rather ... broken
Minor changes, add new S_USER_LANG template var
Update ACP linkage
gurgle blurp ... make some more changes, blurp, gurgle, move discover_auth to auth class as acl_get_list method, blurp gurgle blurp
We're going down, we're going down, blurp, blurp, gurgle, gurgle
Change to discover auth ... this time I think I got it right ... ooohh look @ that pretty iceberg ...
Finally add deletion of expired sessions from forum access table, remove request_var useage for explain linkage
/me whoopsies all over the floor /me is ashamed
Admin load switch for jumpbox
request_var update to support 2-dimensional arrays.
finish bump topic feature...
Remove need for session_ids for "allowed" bots, dump user_founder/user_active in favour of user_type, new user_type, USER_IGNORE
well, seems putting the queue process in the footer doesn't work on "real boards" where people hit stop constantly on their browser :D
Let's break lots of things
new rule
request_var init
Fix missing path seperators in template/imageset T_ vars
Fixed: sql_return_on_error() calls. Now works as expected Changed: var types explicitly casted
This checkin msg is dedicated to dhn ;)
fixed censoring (quote post, word boundaries, attachment comments)
Updates mainly for removal of extension + header comment ... moved some aspects of ucp around, further work to be done on these areas ... not commiting search for time being
saved one query by moving max smilie check to the emoticons function
Taken explain code out of sql_query. New improved layout.
bah, group handling needs some further discussion ... I'm done with it for M-2
A few more changes ... nearly there ... deleting users is going to be a little troublesome
Fixed: removes the ending slash if the script path is empty resulting in a double slash in the URL
Remove trailing slash from T_XXXX_PATH vars
Moved sql_close() down, after the cache is unloaded.
A fair amount of additional working or semi-working stuff ... template stored db source (when appropriate), switch theme/templates between DB/filesystem (if available), import, upload templates, imagesets, themes (if available ... i.e. no safe mode), etc. still a fair amount of stuff to do but getting there ... take care using this, backup any themes/templates/imagesets before fiddling and let me know of issues
Changes for styling directory layout alterations
Send DB stored css data to template if necessary ... yes, I realise this won't be cached like a normal stylesheet but there are potential ways around that
More styling stuff ... activate, deactivate styles ... deactivated styles can still be used in forum/board styling selectors
Update data for styling schema changes
Cope with secondary (per forum) styles, probably other minor things too ... there is a known permissions problem, will work on that soon. Ashe, the bbcode primary/secondary stuff may need some tightening, particularly since it only checks the bbcode_bitfield for the primary template (which may not exist as coped with later) ... I'll leave that to you to alter.
sqlite support UNION ALL SELECT method
Yet more updates, topic marking works again ... still intend (optional) checking of "forum read" status on return to index (rather than just the current fudge of visiting the forum), obtain_ranks as a function (used in at least three scripts), removed jabber method that was needed, oops
more fun with cookies
Changed: set_config() won't actually update the database if config values match
Wasn't stripping slashes from the cookies ... that will account for some of the erroneous mark read, nothing changes issues. Add name="" to image generation ... for "on" event handlers, etc.
get_forum_branch() moved to function_admins.php
More functions added ...
Yet more mildly fudged code ... just to get something up, minor fixes/updates elsewhere
Returned to instantiation of ucp object ... perhaps this approach is better? Altered basic info for ucp_modules, updated editor to allow alternative form and textarea names ... still lots of fudginess, hhhmmmm fudge, uuuuugggghhh
Had to make a start on the UCP proper ... note that things may and in places are quite broken
Fixed: moderators "viewprofile" links
Changed forum_link_track to forum_flags for storage of additional info [ pruning related ], moved lang selection into DB, other minor changes, still working on admin_prune, per forum styling for posting
email topic, minor other changes, removed updating of parent forums upon posting (handled by functions_display)
Removed nav_links
Fixed, hopefully, jumpbox indentation issues
No need to require guests to login before asking for password
page header/footer become functions, forum passwords (I know, I know but it appears a popular feature for some reason ... inclusion not yet set in concrete nor complete), various bug fixes (and no doubt new bugs).
Various updates, forum links, "improve" forum management, cleanups, blah blah, note the schema changes, note also that forum management may misbehave ... reports on wrong doings are welcome ... seem to be having problems with some mcp functions under apache/win32
Various changes, and tests ... marking/tracking is not complete ... tinkering, changing, etc. still to be done ... it's just I've made numerous and various changes to different files so a commit really is due
Fixed some undefined variables
oops, I completely forget that viewforum uses the new topics_marking table ... guess I need to commit all related changes after all ... pooh
A few changes, moved some items to templates
Minor changes
Some change-arounds ... hopefully not introducing problems ...
Enable/disable display of moderator listings
fixed delete post bug, use extension cache while posting, fix download counter for images
initial 'view attachments' implementation. added new template var (merged include, to preserve previous block vars), could be changed later to consider caching. some config variables and upload icons are not present as of yet...
Moved back gen_sorting() to mcp.php
Trying to centralise sorting... currently used in MCP, successfully tested in viewforum.
show the attach icon in viewforum. added cached extensions (we need them within viewtopic)
Just throwing this in ... dependencies still not complete ... the GUI and storage has caused me to do more "thinking" than I'd anticipated ... comments are welcome on what you see. Note also ALLOW/DENY/INHERIT have become YES/NO/UNSET
Don't output error page header when header already sent
global $db... ashe, i think you noticed already. :)
forum_parents made more reliable. Removed the $extra_form_fields parameter from jumpbox routines.
board_email becomes board_contact, board_email is now intended for use in "From:" and "Reply-to:" ... board_contact to be used where a "user facing" contact point is needed, e.g. spam, errors, etc.
Tidy up and simplify emailer class, add generate_board_url function ... note changes to emailer setup! Example will be adm/index.php remind
sql char field types must be enclosed in ' rather than "
Moved login procedure to a function enabling "inline" login links ... no more "messy" redirects ... install will be broken for now, at least when it comes to redirecting after completion. Moved "front-end" login to ucp.php
Redirect path changes
Slight change to obtain_icon sql
Do away with icon_id > 1 business since it's no longer needed ... note you should delete the empty icon in your icons table.
Re-enabled fully dynamic config settings.
Merged forum nav for viewtopic/viewforum, fixed cache behavior with an empty icons table.
Cache topic icons ... being used in three places, two high traffic areas ... probably worth caching, alter word censor to one var array ... hopefully this doesn't break anything :D
Un-b0rked ACL options caching, small general fixes
Minor fixes
EOL should be fixed now
Implementation of an experimental cache manager.
This is red, now why is it red ... probably because it's not green ... so let's make it green and hope it wasn't red for some specific reason
Updates as opposed to downdates
Various updates
Redirect changes
oops
I know the jumpbox layout doesn't always match the real forum structure ... will fix
Fixing my fix and initial checkin of markread()
Some changes to forum admin to better reflect subforum 'post/non-post' changes ... no guarantees I've not broken something ... note the schema changes
Made the error handler behave responsibly when $user isn't there yet
Moved profile.php to ucp.php. ucp is really really broken right now, don't even think about trying to use it.
Update jumpbox for subforum changes
Further layout faffing, nav links for viewtopic (code needs merging with viewforum/posting), moderators for viewtopic
Cache moderator names? Output moderators for all forums in viewforum. Alter a few things in templates
Cache moderator names?
Cleaned up viewforum/index, altered template class to replace missing lang strings with a nicely formatted text, pre-implemented topics prefetching and broke some things.
Subforums update take #1
viewforum queries update + a couple of bugfixes.
Various, typically posting related updates
Minor changes, trying to get it working on my test server
Changed $board_config to $config, more posting "stuff", altered polling code in viewtopic and loads of new problems, poor coding, etc. created :)
sql_quote fixed
Rules and lang changes
Rules updates
Preliminary 'freeze' on permissions system awaiting developer feedback, testing, etc. Caching of non-dynmaic config and acl option elements.
Mostly changes to turn userdata into user->data, lang into user->lang + bitstring 2nd format + inheritance for permission admin and various other updates/fixes/changes ... note that user->lang & user->theme isn't final
More jumpbox stuff, still not happy with the layout though =(
Minor bugfix (subforums template was called even if there only were empty subcats). Jumpbox got its "Select a forum" entry back.
Bugfix (disappearing forum names) + enabled jumpbox and modified it to allow category jumping.
Added the redirect() function for nice and clean redirection.
Permission changes, updates admin functions, indented jumpboxes ... note that the update script doesn't seem to introduce the user_permissions field @ present so you need to add it manually
Well, here are all my changes ... don't blame me if things break :D
Subforums handling part 2, it almost works. Also added: the "Explain" link at the bottom page, can be removed easily before official release if necessary.
Cleanups
Some sql changes
Rule output changes ... no point in limiting delete/attach just to viewtopic ...
Changed things ... in various ways ... I think
Wrong footer .. what a shock
bye bye computer
The next thing to go wrong causes this computer to go flying ...
message_die admin header/footer update
Pagination updates ... new function for on_page
Updated user search system ... this really needs to be integrated with memberslist or something ... but it'll do here for now
Updates to message output for admin (primarily)
How come this worked fine locally ... bloody amazing ...
Combine, update, remove various functions ... by committing this various 'things' will stop working, I did warn you not to use 2.1.x ... :)
IP related updates + fixed gc in sessions
merged from 2.0.0 branch (marked merge_point_20020420) + assorted updates and trial stuff for example session alterations
Various updates with any luck they fix a few minor issues without causing new ones ...
pre-freeze on main templates, various bug fixes (highlighting search results, various search related issues, blah blah). These updates need thorough checking, quickly
Move phpbb_preg_quote back into functions because it's plain annoying ... :D
Fix bad word cockup ... oh look the censor failed and let cockup through, oh, and again ... geez sourceforge needs better censors for its CVS system
timezone setup should be isset not !empty ... GMT is 0 after all .. oops
bah
Stuff that phpbb_preg ... not including bbcode and can't be bothered to move phpbb_preg out ...
phpbb_preg_quote that bad word replace ... just in case ...
Stop being too paranoid about hacking of includes containing only fully inclusive functions
Updates to overcome security issue + updates of various functions, initial version of profile registration include ... not completed but should be functional for obvious reasons(!)
Localise days/months, fix bug in validate_username ... this doesn't see functions.php split, working on that separately
preg_quote badword ... don't use # in your bad word list(!)
Slight mod to language selector to handle double underscored lang files
Failed to switch to English images default if prefered language doesn't exist ...
Move activation key stuff to profile, search_username stuff to search, re-add @ to create_date
Use default style if user doesn't have a theme set (shouldn't happen)
Fixed error in make_forum_select box generation output
Change way error is returned to validate email/username, fixes problem with lack of language support for error output and subsequent doubled username, etc. issues + remove get_userdata_from_id and use get_userdata instead + other minor changes
Fixed 404 for header (#51499)
Fixed missing " bug #514823
hmmm, doh ... of course removing the preg_quote here is no doubt going to cause bug reports of "I can't censor xyz@asd" ...
Various updates, mods, changes to several functions, moved smilies stuff to bbcode.php ... nathan may kill me ... good bye all in advance
Another change to the way {LANG} is handled for images ... last one, ... hopefully :)
Fixed bug #507473
Changed selection of localised images ... new {LANG} replace format
Fix various bugs; password length warning, proper warnings for username/email errors
Fixed bug #505838, debug messages didn't show SQL errors
Cosmetic error in language_select() (related to #499989)
Added / to dirname . file for is_file/links for language selector ...
Removed windows carriage returns and newline at end of file ...
Ok that was stupid.. Better version of a fix for 497077... Somebody hand me a beer.
Updated validate_username function for use with mysql4 Bug #497077
Clean up display of languages, limit to directory names only
Sigh
Fixed small problem with translation of imgs
More \' updates
Made smileys case-sensitive (i.e. :o != :O )
Oops, another file I forgot to commit, perhaps I should commit myself ...
Fix bug #493735 was still using old config value name for theme
Remove guest user topic tracking via cookies, update viewtopic to re-fix highlighting of search terms, add lang capability to images, various other issues, removed remote avatar size reduction
bug #488067: no, preg_quote() didn't always have 2 args.
More updates for Euclid, minor update to subSilver, fixed bug #490798
Fixed #490848 and introduced $current_template_path
Fixed bug #488016
Should fix bug #487886 bad word preg now uses # and quotes # too
Fixed bug #486207
Fixed problem with disappearing Mozilla nav bar when message_die() is called
Implemented Navigation bar in Mozilla
Fixed bug 478218 -- [ and ] in usernames qith quote= bbcode. Usernames can no longer contain the double-quote character. Also removed a dupe from lang_main file.
Order of username in username search was missing
More language updates
Mainly language updates but some bug fixes too
Treat moved topics as being non-existent for re-sync of topic counts
Fixed bug #477831 + some minor alterations
Altered various language constructs + new quote changes for PM + altered pagination
Slight mods to the usersearch function, moved to search.php
Fixed some bugs with banning and some code that wasnt updated when we changed the theme/template system
Username Disallow Admin...
Various updates mainly to message die for admin compatibility
Changed paths for language
Fixed preg single quote potential problem, altered jumpbox slightly - Third time lucky ... I hate FTP ...
Fixed preg single quote potential problem, altered jumpbox slightly
This is getting boring ... I FTP, or think I do and yet still these files get through unchanged ...
Changes related to private messaging + some bug fixes
Damn newlines
Error reporting on set_style()
Updated and fixed various issues, see post in developers forum for info
Various changes
Combined theme/templates in profile as suggested, added META refresh and made a couple of other changes
Fixed bug #460075
Removed some trailing newlines
Altered layout of phpbb_config table
Fixed bug #459427
Numerous updates and additions for polling and assorted fixes ... or bugs, whichever they turn out to be
Fixed bug #457835
Fix for bug #457835
Tidied up the sync functions
Re-added GPL disclaimers
addition for sorting smiley codes so that they all work properly on all DBMS's The smiley functions should probably be moved to bbcode.php at some point
Modified header comments
Thought it best to add the email validate now
LENGTH not compatible with ODBC
Added border=0 as suggested to remove borders around linked smilies
Fixed moved topic in sync
Fixed bug in updating forum last post in sync
Hurray the smilies code appears to work :)
Ok last bit with the smilies :)
Another attempt at fixing smilies code :)
Fix for smilies code ;)
Moved smilies code into functions, would it be better in bbcode.php?
User, IP and email banning admin functional
More compliance ... it never ends
More compliance updates + select previous posts in viewtopic
Removed header frame, reduced timezone naming, added DB size for MySQL, no major technical changes
System config admin section started. Can view settings but can't modify them at the moment
Still seems to be pagination problem, I dont have it so what havent I committed ...
Template config system, store relevant config stuff here
Split posts works, split beyond this post does not. Still needs interface work as well
Changes to include location + some other misc stuff
Split is half done... don't try and use it though its current b0rked :)
Some tidying up and switchover to message_die
Added a count of total number of topics to the get_db_stats function
Switched validate_username check to groups table
Fixed isset and empty checks on userdata so user prefs now work again
Posting preview done, ability for anonymous users to post with a username
Some updates
Likely fix for pagination failure on div 10 boundary
Similar problem with the user_timezone field
Check user_dateformat against '' was messing up sourceforge so I changed it to an
if($userdata[user_dateformat])
insted.
Auth Stage-1 goes in
More work on posting. Editing now works. Also replies can have subjects.
Fixed a small problem with pagination
Lots of work on posting. New topic and reply functionality is mostly done. Edit post loads the form but needs database functionality All this is only been tested on Postgres, donno if it works as well on MySQL yet, will test when I can get access to sourceforge again
Moved the append_sid routine to the sessions.php file
This fixes the error that I though I fixed in the last commit ... doh
First of changes to SQL
Added generate_pagination routine
Now allow for GET based session
Moved config, images vars to arrays and various other fixes
Moved several functions to profile.php
Fixed bug in utilising user selected timezone
Added some passthru support to login Got edit profile half working..
Fixed a pile of Windows carriage returns
Added forgotten default_theme to global declarations
Minor change to var in user_prefs
Updated for generic theming
Added user selectable templates, and put the system template into the config database. Updated mysql_schema as well
Removed need to send db as a parameter to functions
Moved all included files to includes