History | View | Annotate | Download (22.6 KB)
Revert INC/DEC feature. It is not consistent with the other template variables - bad idea. ;) We will get to it though... but not now.
This is an enhancement for revision r10051 (INC template variable)Within the mentioned revision INC was only able to be applied to defined template variables.I extended it now to work on all supported variables (template vars, defines, loops, defines in loops)...
Add INC (working name) to template syntax
Preserve newlines in template files (one newline had been always dropped after a template variable due to PHP's handling of closing tags)
Fix bug #45805 - INCLUDEPHP not depending on phpbb_root_path
Authorised by: acydburn
Dynamic template includes :)
Enforce correct case for template variables. {var} no longer works for example.
Fix r9363, DEFINE uses template_compile::compile() which was generating really broken PHP :)
add IN_PHPBB check to generated cache files
Missing read permission from calls to phpbb_chmod()
Don't compile {} or {$}.
change the way we do chmodd'ing. I know, my implementation really sucked... good we have motivated community members who point this out. ;) Thanks to faw for providing a way better function and for discussing and also abiding to our needs. :) LEW21 should maybe credited too... he gave the inspiration without knowing it.
the chmod change i already had within the changelog (by mistake). This should further secure writable directories and created files.Installation need to be tested on different hosts.
only some space/tab changes as well as removing my debug code from the template file. ;)
change conditional enclosements in template engine
Okay. Frozen, we never said anything about it being permafrost. Also, this is not 100% tested, expect troubel with store_db (I'm waiting for the bug reports)
Hiding everywhere little buggers, eh?
This commit was manufactured by cvs2svn to create branch 'phpBB-3_0_0'.
dumdidum... sorry. ;)
- more accurate comment
ok, the nasty one then... :/
ok, we are not able to cover all possibilities (IF A eq (B & C)) for example... or IF A == B... this would require a lot more code we do not see the need for.
test adding isset() calls to if expressions. :o
some fixes...
allow constructs like <!-- ELSE -->0<!-- ENDIF --> (the 0 was replaced by '' due to the empty() checks on $trim_text_check)
some fixes
- generate fewer opcodes, make a smaller cache, a bit more readable
- fix some oddities (doubled spaces for example)- changed the way make_forum_select() is returning the forum list - now including skipped forums but being disabled. This should make identifying the correct forum much more easier.- Changed some permission namings based on suggestions by the community...
fixing some bugs, most being submitted grammatical/spelling errors.
- fixing some bugs- removing utf8 characters from email files (has been discussed internally, you guys know why)- making sure some opendir calls are checked before calling readdir.
#6596
- quite a few optimizations to the template engine. bitwise arithmatic is used to check odd/even, usage of ref to the root template variables should reduce the number of hash lookups needed, usage of refs within loops should reduce the amount of hash lookups, incrementing vars were turned from class variables to regular variables, cache now uses preincrementing variables instead of postincrementing variables, some regex were optimized/trimmed...
- some fixes- added script for easy adjustement of username_clean column within the users table (please see the note i added to the utf8_clean_string() function)
- fixing a bug i am unsure about when it occurs (but it occurs). The symptoms are broken template cache files if after removing unnecessary php opening/closing tags result in statements being syntactially incorrect.- added real syncing to forums acp (not only forum statistics rebuild)
- added confirmation to removing bbcodes- added optional MX and DNSBL checks- added backtrace (triggering sql error) on error within sql_in_set as well as making sure it is handling an array- let users having f_list access to a forum actually see the forum without a topic list and not displaying an error message - this allows for giving people access to subforums but not the parent forum without the need to add the (sub-)forum to the index....
the tokenizer is buggy across several versions of PHP. The regex that is always used complies strictly with what the internal lexer uses, we are safe.
some updates. Also adjusted the utf tools and normalizer more to our coding guidelines.
more efficient + fixing an oops
The regex used here are more or less identical to those used internally by the PHP lexer (ok, ok, they are a little bit more optimized), we should not need to call the tokenizer at all now...
Fixed: oops, forgot ASP-like tagsFixed: (cvstats++)
Fixed: bug #3352 (function token_get_all() is missing)
could have been a copy&paste error, but the expression is also removing the </script> tag from valid script blocks (javascript for example). :)
another expression for grabbing php code in templates provided by davidalso included "the ultimate solution" provided by ludovic (only added a check for T_OPEN_TAG_WITH_ECHO
- fix bug within php code removal expression. Thanks to BenP for reporting it to our security tracker.
- add additional auth check to the permission roles modules- added new function to return globally used expressions (get_preg_expression($mode)). This should be very helpful in getting wide spread similar checks (regular expressions) to one place reducing the risk of forgetting to change every location if you fix one. ;) We will add additional ones later, at the moment only the email check is retrieved......
make sure custom profile fields are created correctly on registration (#2225)
ok, this one is rather large... the most important change:re-introduce append_sid: old style continues to work, not a performance hog as it was in 2.0.x -> structure is different
apart from this, code cleanage, bug fixing, etc.
character class... character class... character class...
- allow commenting out on one line:<!-- <!-- IF WHATEVER --><br /><b>{WHATEVER}:</b><!-- ENDIF --> -->bug #1869
(i hope i did not break something :o)
some changes before i forget...
- added the template editor (doesn't use a hardcoded list of template filenames for categorisation anymore)- fix some bugs related to storing template files in the database- allow templates stored in subfolders of the /styles/name/template/ folder
introduce LA_ for addslashing language variables for use in js vars (idea by naderman)
- Bug #1237
- clean up marklist calls (global function)- added new feature: test out others permissions (admin permissions will not be copied)- changed attachment processing by directly using the template engine- fixed some attachment related bugs- additional tiny fixes
added/changed language strings
- fix the template error (no headers displayed, wrong ! assignment, wrong check for .loop)
To all people having their bug status set to fixed: SF pserver CVS access is currently down, therefore the snapshots are still out of date.
- fix a bunch of bugs- <!-- $Id$ --> is no longer allowed in template (.html) files- changed layout of private message screens (folders are menu items)...
- This should work! :D
- add our beloved in_phpbb check
We all make mistakes :D
- implementing David's proposed expression changes (some of them already noted within the events CCP)
- file_get_contents instead of imploding file()s or fread()ing till the maximum filesize- language and style properly use compression- language now prompts user for methods- functions_compress does not need to eval() to get a hex date, instead calls pack()...
- some changes to browser checking (was the reason for not working logins)- partly working style acp- other tiny changes here and there
Some fixes to the template code - this handles the case where file caching is used and no cachedversion exists
- some bugfixes- checking if page_header has been called already- call correct page footer function- rewrote avatar gallery- seperated compilation of template and template functions (new file: functions_template.php)- added assign_display function to template...