View | Annotate | Download (42.4 KB)
Rename get_unread_topics_list() to get_unread_topics(). Cleanup: Remove some stuff we no longer need. Related to report #46765
since we now have several search_ids, all with different default results modes we now always add the sr variable to the URL - Bug #50775
One more unread posts search adjustment. Authorised by: AcydBurn
Add unread posts search support for cookie-based tracking Authorised by: AcydBurn
Fix bug #49525 - Search for unreads should require login Authorised by: AcydBurn
Fix r9755 for #46765 Authorised by: ToonArmy
Correctly propagate umlauts over search result pages [Bug #33755]
Fix bug #46765 - View unread posts Authorised by: AcydBurn
Fix bug #47765 - Search by authorname does not display posts of deactivated users
Authorised by: AcydBurn
Fix bug #36565 - Search by authorname does not display posts of guests and deleted users
Authorised by: naderman
revert r9653 because it does not work as advertised (a load of bugs and not really what we wanted... back to the drawing board ;))
Fix bug #46765 - View unread posts Authorised by: acydburn
Fix bug #19135 - Exclude forum from active topics option is ignored
Authorised by: acydburn
remove item from change log
group by is required to be correct, but this creates a temporary table. I do not think we will let "new posts" display non-approved posts...
revert query change which caused boards to halt.
Fixed bug #'ers 42585, 35505, 36675, and 42705 Authorised by: acydburn
Apply append_sid() to newest/latest post links in viewforum/search and UCP main module. (Bug #26815)
small SQL optimization
very minor annoyance
Pass S_SEARCH_ACTION through append_sid() in search.php. (Bug #21585)
make topic icon image width/height available to viewforum and search templates (Bug #15934)
- Added missing terms parameter to search pagination. #34085 - Do not use the topics posted table when performing an egosearch.
Do not show non indexed forums on the search page if they contain no subforums. #33125
#29435 (do not highlight if only wildcard(s) provided)
Hiding everywhere little buggers, eh?
This commit was manufactured by cvs2svn to create branch 'phpBB-3_0_0'.
dumdidum... sorry. ;)
some tiny fixes...
- added an option to specify a port for the LDAP server - restricted access to "Recent searches" to admins who are allowed to configure search [Bug #14085]
- BBCode parsing order should ALWAYS be censor_text(), bbcode_secon_pass(), bbcode_nl2br(), smiley_text(), parse_attachments() - using \r on custom bbcodes to allow line breaks [Bug #10758]
- allow multibyte search configuration - added ldap_user_filter to add additional restrictions on the user objects used for authentication [Bug #12627] - improved ldap explanations a bit - display searchable subforums of invisible parents in advanced search forum selection [Bug #11395]
- strip_bbcode should not treat smilies which look like BBCode and are placed in front of a closing tag as BBCode - highlight in post subjects and topic titles - language entry SMILIE_ONE_ADDED should have been SMILIES_ONE_ADDED
some bugs fixed
do not get too excited
#13579 This changes the signature of author_search. Search backends will need adjustment.
try to normalize everything...
Cleaning up (#13689) Also removed the useless login box from the ACP.
- search result extract shouldn't end in the middle of a multibyte character [Bug #11863] - missing localisation for an imageset shouldn't create lots of "imageset refreshed" log messages [Bug #12027] - explain that themes which need parsing cannot be stored on the filesystem [Bug #11134]...
even more fixes. :o
some fixes here and there
#12941
tweak the sql_like_expression feature a little bit to allow correct escaping
new wrapper for LIKE expressions to streamline the fixes. We actually need to adjust them for different DBMS as well as SQLite2 not supporting escaping characters in LIKE statements (which is a reason why we think about dropping sqlite support completely).
- author search should take UTF-8 [Bug #11793]
#12545
- correctly transfer the search query across search result pages - changed highlighting so foo* will match foo again [Bug #10031] - restructured magic urls (functionality still mostly the same), added a check for entities in urls and punctuation at the end of magic urls [Bugs #10639, #10293]...
fixes for search button in header - #10389, #10225, #9548 added missing colour swatch to prosilver - #8657 language changes - #10387, #10375, #10373, #10353, #10279 line-height for font size (still not ideal) - #10317 Search load setting checked in sessions.php along with limit_load and also reset if not possible to determine load - #10383...
- * wildcard in a search query should cause \w+ in highlighting, not \w* [Bug #10031] - display a warning that the search index is not converted from phpBB2 to phpBB3 [Bug #9761] - forgot to add : to reg_name when deleting userinfo from the url regex constructor [Bug #9868]...
- removed unneeded code from fulltext_mysql [Bug #9947] - an additional combined index on post_subject and post_text is necessary for fulltext_mysql [Bug #9818] - added phrase searching support to fulltext_mysql while fixing some minor bugs in the keyword processing code, originally intended to do this about a year ago when I switched from split_words array to search_query string in the search backend interface, so finally it's there
#10005, #10003, #10001, #9999, #9945, #9965, #9909, #9906, #9877, #9861, #9831, #9830, #9815, #9665, #9624
prosilver adjustments for important announcements in ucp - #9995 MCP fixes for user notes/warnings - #9981 Preserving imageset values on save/edit find a member link for Mass PM's - #9925...
- urlencoded usernames don't need htmlspecialchars [Bug #8794] - fulltext_mysql still used synonyms/ignore words [Bug #5405] - merge tool extend to allow merging complete topics via quickmod and mcp_forum [Bug #5293] - renamed "fork" to "copy" (was already called "copy" in some places)...
- small MSSQL thing - changed how we store tracking data
- fix htmlspecialchars handling in search (search backends get specialchared input, and should return specialchared output), current backends strip entities anyway [includes Bug #8156] - allow cancelling search index creation/removal - custom CSS class name input too short [Bug #8328]...
- ignore too short/too long search words [Bug #7438]
- fix some oddities (doubled spaces for example) - changed the way make_forum_select() is returning the forum list - now including skipped forums but being disabled. This should make identifying the correct forum much more easier. - Changed some permission namings based on suggestions by the community...
#6772 - some other random things
fix message length calculation for parsing bbcodes as well as saving some bytes of memory. ;)
- display search type as page title for premade searches [Bug #6508] - flash enabled on user side by default, so that admins can actually change anything by activating it (still disabled by default) - properly implemented password complexity check [Bug #6584]...
some fixes today - most important change is the consolidation of the display attachment functions; merging them together to have one function we need to call.
#6264
- finally correctly calculate current time for birthday calculation [Bug #6030] - allow searching forums with unsearchable subforums [Bug #6056] - addition of an optional HTTP_X_FORWARDED_FOR check in sessions, including bans - do not index forums which have indexing disabled on index recreation [Bug #6060]...
- author search should use clean names for searching [Bug #5752] - local moderators are moderators too! - don't show a "word is not contained in any post" message for ignored common words - bold search words in search error messages [Bug #5762]
- a bunch of fixes - added todos to the updater to make sure i do not forget. :)
- Throw error on incorrect search queries [Bug #5648]
#5610
message
rather large update, most important things done: - implemented provided patch/diff file for bug #5350 (Highway of Life) with some tiny changes and alterations - more username/colour changes/fixes - added a note about PM rule-dependant message removals so the user is not wondering too much if he can't remember his rules. :)...
fixes for bugs #5564, #5554 and #5462
- fixing a bunch of bugs - moved the install trigger error to sessions and also disabled it for those having DEBUG_EXTRA enabled. i hope not having introduced too many new bugs.
some tiny fixes.
adjust some comments to work with phpdocumentor. :)
ok, change from doing the same logic all over again we call a function to do it for us. Also allow template designers to choose which method to use by just adding a fully compiled username string (profile link + user colour). This commit may introduce problems.
consistant obtain_* functions
trimmed the highlight regex
- now username changes should work as desired - removed some extract() calls
- store sql_layer directly within the layer itself - new method sql_multi_insert to circumvent db-specific hacks (hopefully not introduced any parsing errors)
tried to begin adjusting all string functions where applicable - still a lot to do. i hope i catched all relevant sections and did not mess something up.
Add coluring to search-posts results
- no more encoding mixture, say hello to UTF-8 (I'll add a validation solution for PHP 4.3.3/4 ASAP) [side effect: fixes Bug #3762] - take local server time into consideration for birthday/age calculation - faster active topic search - allow changing active topic time frame [Bug #4150]...
implement bare-bone validation for config variables...
Next phase of last post changes + a few minor bugs
Note: This template variable is available but will not be used by default
- fixing profile bug - adjusting acl_gets calls (they are or'd - make sure they get checked correctly based on the situation) - automatically assign the u_download and u_search permission to the guest group
- Bug #4000
- only highlight when there is anything to highlight
-forgot list items
- birthdays/age in user's timezone and not server's local time - parse bbcode in posts with fewer characters than selected maximum on search results page - retrieve search word context in posts which are longer than maximum characters (no raw BBCode anymore)...
Phase 2 of the changes This should now be complete
Initial batch of colourization changes. This includes: - schema changes for first post and last post - display in viewforum, search and ucp of first post - update of database on posting Still outstanding - display of last post
- set default_style when the old default style is being deleted - Do not search for moved topics in the premade searches (new/active/unanswered) and if one occurs for whatever reason, at least display it properly [Bug #3756]
sql_in_set changes
- load tracking updates. Need to be tested on a clean installation too - at the moment only tiny quirks are noticed at area51. - reported bugs fixed
- fixed some problems with themes - added support for {IMG_NAME_SRC}, {IMG_NAME_WIDTH} and {IMG_NAME_HEIGHT} - fulltext_native has to use group by in a few more quries
- fixed some bugs - made imageset naming more consistent - updated every schema to be consistent and also fixed it (every db should install fine now) -
- fixed the age calculation (note: turn on your brain before commiting something like this the next time) [Bug #3337] - removed the split_words array, introduced an enforced search_query - the forum used for global topics in the search is now a forum, and no longer a category [Bug #2561]...
- it's \r\n not \n\r [Bug #3121] - a few little search bugfixes - drop in the improved version of the native search based on UTF-8 (still needs some work before it can replace the current native search) Thanks Ashe :)
- fixed a parse error (oops) - pass forum_ids to search indexing functions - fixed a bug in fulltext_native's cache destroying
- display age in user profile and make it available on viewtopic - various tiny bugfixes including [Bug #2351] [Bug #2549] [Bug #2681] [Bug #3015] - strip first, then change newlines [Bug #2403] - added support for creating user profiles to the login function (makes use of user_add), triggered by LOGIN_SUCCESS_CREATE_PROFILE constant...
- improve newposts search performance
ok, sorry for this. :/ - cleaned up table names/constants
ok, this one is rather large... the most important change: re-introduce append_sid: old style continues to work, not a performance hog as it was in 2.0.x -> structure is different
apart from this, code cleanage, bug fixing, etc.
- adjusted coding guidelines - fixed custom bbcode {TEXT} token - added unapproved item/info for unapproved posts in a topic
- added search by author_id to solve problems with looking up posts of users with a name containing wildcards - user based flood control (seperate limits for users and guests) [Bug #1357] - inform the user about ignored words if he receives a "no words specified" message...
- force a default charset - better highlight code in search
- some adjustements for phpdocumentor
- allow searches for multibyte characters in fulltext_native - use preg_quote safely
- correctly use DISTINCT and GROUP BY in search related SQL [Bug #1256] - always display views and replies in search results [Bug #1223] - display error messages occuring during search index creation/deletion [Bug #1274] - correctly align the ACP link on the search results page [Bug #1160]...
- some adjustments for search related config options - one year is 365 days long (52 * 7 = 364, but we have one more day each year ;-)) [Bug #1181] - fixed search own posts link in UCP [Bug #1163] - corrections to timezone selection [Bug #1148] - fix quickmod tools on post details page [Bug #1188]
- Bug 1104: fixed a typo ($necoding => $encoding) - Bug 1139: active_topics now has a button to submit the "Display posts from previous <time>" form - active_topics doesn't return NULL rows anymore - fix a padding bug in the search forum listing
- Lesson learned: If you rename something rename it in all places and not just in a few :) (min_search_chars/max_search_chars/load_search_upd now prefixed with fulltext_phpbb) - search_indexing_state should not be dynamic - a topic link should link to a topic ;-)
- replaced mcp reports system with a simplified version - fixed links to mcp_reports
Me, me, me!
- only search unapproved posts/topics in forums where the user got the m_approve permission - resize the search cache when it grows too huge (drop distant pages) - added unread link to search results page - streamlined search results and viewforum html code for displaying topics...
- added "display_on_posting" setting to custom bbcodes (creates a button with the bbcode tag) - fixed forum editing and parent id selection - completely removed HTML support (it only creates security problems) - changed cache_moderators() to reflect permission changes
- new default result mode: posts - make use of f_search permission
just some tiny changes to meet the coding guidelines
- added fulltext_mysql - sort search results by topic author, not topic author id - topic tracking on search results page - dotted topics on search results page - links to global announcements fixed
- search deals with global topics - fixed some other search related bugs
somehow I knew this had to happen :( (just two very tiny changes to the previous commit)
- overhauled search system - updated structure for search backend plugins - better result caching using ACM - search results no longer session restricted => link to them by copying the URL :) - in-topic search - indexing posts now uses search backend plugins...
Added topic folder image source and user profile link for posts results page
Added the topic icon src variable to bring in line with viewtopic and viewforum
- Replaced the old 2.0.x highlight code with much nicer code :-)
- some SQL:2003 changes (basicly joins, mysql5 is sql:2003 compliant in strict mode now) - postgresql not supporting this standard. :/ - acp changes
- updated topic tracking code - additional changes (mostly bugfixes) - bart, if you update your user table with the user_lastmark field, set it to the user_lastvisit value ;) - and last but not least, introducing some bugs in ucp main front (regarding topic tracking)
- checking in pauls (psoTFX) search changes (with tiny adjustments from me)
- view active topics - seperated search id (int) from search id (string) for security reasons
- some fixes here and there
- made path information available to template (T_) - eased topic/post icon in templates (removing hardcoded img) - added S_FIRST_ROW and S_LAST_ROW to template engine
- Documentation related changes - added resend activation email dialog - fixed issue in session code - log failed/successful admin re-authentication/login - fixed simple forum dropdown box (used in mcp and posting)
- first try to break things...
- fix stopword handling for searches in search results
- search updates
This is a mass commit ... expect trouble! Changes made here are primarily to how login is handled, schema changes necessary!
- fixed permissions for mcp (global permission settings are false if user is only able to moderate one to x forums) - determine permission settings for submodules - further approve/disapprove work (approve_details added)
- remove output buffering options from download.php (not needed anymore) - optimized viewtopic.php a little bit - removed the create_function (was consuming too much memory) from viewtopic - check for manually added convert[.exe] program name to imagemagick path in admin_attachments...
splitted language files
- put consoring and smilie processing into functions (we use them all over the place) for better changing and consistency. - changed docs/AUTHORS to reflect the recent code re-use in functions_messenger.php - pleasing the users a little bit more by using table constants. :D...
new permissions, merged attachment tables (the intended purpose of two tables is no longer valid), attachment updates along the merging...
Note: please merge your attachment tables (develop dir).
Fix a few items, ability to read private forums, etc. ... must look at reducing need to join on posts table when not absolutely necessary
Add search interval check, correct a couple of errors
ah, what the heck ... let's throw this in CVS
Various bits and pieces ... this isn't really what I wanted M-2 to look like but hum ho
basic todo list
page header/footer become functions, forum passwords (I know, I know but it appears a popular feature for some reason ... inclusion not yet set in concrete nor complete), various bug fixes (and no doubt new bugs).
some arrangements...
Another windows carriage returns foobar
Enable/disable searching
Moved profile.php to ucp.php. ucp is really really broken right now, don't even think about trying to use it.
viewforum queries update + a couple of bugfixes.
Dumped sql_query_array, replaced with build_array, posting updates, fixed quoting in mysql layers, fulltext enabled ... speed/problem feedback welcome
Changed $board_config to $config, more posting "stuff", altered polling code in viewtopic and loads of new problems, poor coding, etc. created :)
Mostly changes to turn userdata into user->data, lang into user->lang + bitstring 2nd format + inheritance for permission admin and various other updates/fixes/changes ... note that user->lang & user->theme isn't final
Permission related updates ... is still not final but is getting there ... faster than British Rail too
Well, here are all my changes ... don't blame me if things break :D
More session changes to accomodate ACL_PERMIT/PREVENT ...
More changes ... switched away from prefetch for now ...
Various updates
Add checkboxes
More user search fixes ...
damn damn damn
Look out your window ... just to the left of the Big Dipper you'll see a small dot moving at high speed ... this is my computer ...
bah
Wrong var ... naughty Paul ... smacked wrists
Updated user search system ... this really needs to be integrated with memberslist or something ... but it'll do here for now
Updates for permissions, sessions, lots of things ... note that many things do_not_work now ... I'm commiting them to stop people complaining about my holding on to everything :) There is no update script at present for all these changes, you'll have to work out what's needed yourselves till I finish various things
merged from 2.0.0 branch (marked merge_point_20020420) + assorted updates and trial stuff for example session alterations
Fixing bug 536812: search.php - total_match_count Thanks acydburn! Not a big deal, just did what acydburn recommended.
I'm sooo bored with re-fixing things
search_id change broke various other search options, fixed
pre-freeze on main templates, various bug fixes (highlighting search results, various search related issues, blah blah). These updates need thorough checking, quickly
Update goto page code
Fix enter does not submit problems for username searching, all bow down before Matthijs ... no, not in that way you perverts
Broke bbcode removal when displaying incomplete posts ... fixed
Fix default AND for word concaten..blah blah
Loads'a changes including fix for security issue, thanks to Matthijs for checking this out and confirming
Fix issues with view posts since last visit, errors on next page, re-introduce external stopword list, examine feasibility of stemmer, tidy ups ...
Fixed bug #509335
Fixed pagination bug on search results ( #509852 )
Fixed stripslashing problem which would lead to incorrect search results in some cases
Fix bug #502174, show Guest post usernames correctly ... well as correct as they currently are
Change ego search back to topic output rather than posts (as was till last update) .. even though it does say view own posts ..
Various updates to fix problems with large result sets ... code is quite messy, will clean up
Finished implementation of title searching ... this will please at least one person :)
Changes to topic/forum tracking ... tested for several days on test board and all seems fine, give feedback in forums
Moved all search functions to includes/search.php Paul; please review
Fix bug #497740
Fix bug #496943
Hopefully this addresses the \' and '' problems with MSSQL, etc. ... I'd like opinions on the security of doing this.
Fix bug #495250 and various other issues
Fix bug #495130 and remove unnecessary free_result
Fix for bug #494740
Various changes to accompany session updates ... MSSQL users should be prepared to alter or remove the session_last_visit field or face potential problems
Sped up searching for posts from a specific user a lot
Remove guest user topic tracking via cookies, update viewtopic to re-fix highlighting of search terms, add lang capability to images, various other issues, removed remote avatar size reduction
bug #489842 -- some pages were doing bbencode_second and make_click in a bad order.
bug #488067: no, preg_quote() didn't always have 2 args.
Added another image name for 'goto post'
New session code, probably still dodgy, fix for login failed message, search updates, highlighting URI messup fixes, max limit for ranks
Fix for 'bug' #484650
Finally moved the bbcode_uid from posts to posts_text, DON'T FORGET TO RUN THE CONVERT SCRIPT IN /develop/ !!
Latest variants ... not finished yet ...
Fix for display of newest image icon when one doesn't exist
Search re-write was erm, how can I say this, erm, brown, soft and smelly ... putting old one with required updates back, will do more work soon
Various core updates for searching
Fixed bug #483105
Yet More language updates
More language updates
And again my brain gets ahead of my fingers ... mental note, reduce caffeine intake
Fixed bug #482127 ... part 2, fixes post_subject too
Fixed bug #482127 ... problem occurs when no bad word list exists
Mainly language updates but some bug fixes too
Pagination update
Added arguments to search ACTION to avoid caching probems (back button that doesn't work)
Oops, forgot to commit search.php
Altered for constant table names
New search system, this isn't final, needs alterations, etc. can redeem this against the full priced version with included coupon
Slight mods to the usersearch function, moved to search.php
And all because the lady loves Milk Tray, erm, sorry ... all because I missed a . from a string concaten...thingy
Various changes to location redirection ... please note the format and name changes
Added view newest output for topic search
Just to bring CVS in-line with local copy
New search 'stuff' ... not complete ... update
New search 'stuff' ... not complete
Bug 461842 fixed. Unnecessary uses of addslashes(), stripslashes(), and preg_quote() in search.php..
Removed some trailing newlines
Altered layout of phpbb_config table
Changed all error_die to message_die
Re-added GPL disclaimers
Modified header comments
Changes to include location + some other misc stuff
Fixed error
Switched forum_auth to the forums table
User can only search and see results for forums they have auth_view rights
Various changes and fixes to enable search from username and template updates
Some updates which may have fixed some probs ...
Added ability to jump to a specific post ... click on the little page post icon
In goes initial search engine