View | Annotate | Download (40.7 KB)
Copy 3.0.x branch to trunk
Further adjust unread tracking query, should work now for user last mark times less than forum/topic mark times.
Rename get_unread_topics_list() to get_unread_topics(). Cleanup: Remove some stuff we no longer need. Related to report #46765
Use comparison instead of arithmetic.
instead of only enabling forum feeds in viewforum we set it on every location where forums are shown
add feed switch to forumrow, so forums can be styled correctly (with an rss icon for example)
Better tracking of global announcements Authorised by: AcydBurn
Fix Bug #49615 - Unapproved topic icon has incorrect forum (introduced in r9635 fixing #46865)
Authorised by: ToonArmy
Fix bug #15729 - Global announcements marked as read if all new topics in forum are viewed Authorised by: AcydBurn
Ability to fetch moderators with get_moderators() even if load_moderators setting is off. (Bug #35955)
Fix bug #46865 - Add unapproved topic icon for moderators on forum list
Authorised by: acydburn
Fix bug #46785 - Hide avatars if type disabled and give global option to turn on/off
#44105
tiny tiny changes to r9328
Allow translation of Custom BBCode help messages.
Only display special ranks to guests; no longer display normal ranks for guests (Bug #36735) [a bit ugly, but retains backward compatibility]
- Do not show link to user/group profiles if user has no permission to view the linked page and gets a denied message anyway. (Bug #15088) - Do not display last post link and sort display options for search engines. (Bug #15088)
Fix a tricky little bug in r8909
Do not include hash in redirect back
Correctly handle unread status of subforums (that are not shown on the index) of forums that are shown on the index. #14589
whitespace
adding more hashes
Display popular topic based on posts within topic instead of replies within topic. (Bug #16099)
erm
fixing fault introduced with R8749
as per evil3, some more anti-CSRF
#29335
Hiding everywhere little buggers, eh?
merging r8373 into 3.0 branch: adding a new option to hide the entire list of subforums on listforums
Prepend phpbb_root_path to ranks path for displaying ranks - #19075
One commit for those fixes having a very tiny impact (mostly only whitespaces or forgotten spans, etc.) Although i somehow mistakingly got #20445 and #15249 into it. :/
Removing s_watching_img from watch_topic_forum() function (Bug #20445) Changing order for post review if more than one post affected (Bug #15249)...
- Do not split topic list for topics being promoted to announcements after been moved to another forum (Bug #18635) - Allow editing usernames within database_update on username cleanup (Bug #18415) - Fixing wrong sync() calls if moving all posts by a member in ACP (Bug #18385)...
This commit was manufactured by cvs2svn to create branch 'phpBB-3_0_0'.
#14850
dumdidum... sorry. ;)
#i8
#14211 - doing is_null on Oracle is not good, we return empty strings instead
- Handle forum links/redirects within viewforum if no read permission given (to display login box or error message) (Bug #13467) - Prevent changing postable forum having subforums to link forum without moving subforums out first
That else statement will never come into effect because the ORDER BY makes sure that the parent is dealt with before the children
even more fixes. :o
#11931
some fixes
my round of bug fixes
ok, mess around with the templates + fixing some bugs + adjusting headers for those files already modified to circumvent conflicts for those having their editor set to remove trailing spaces (not recommended!)
Ok, try to fix the "re-approval on edit" bugs. Also added make_clickable to log entries as well as logging moderator edits.
#10523
Just saw this one, whilst thinking about some other stuff... Now possible to select the subforum listing for styling by:
a.subforum { foo: bar; } // both read and unread links
... and either specifically by:
a.subforum.read { foo: bar; } // read links only...
Prepare to be yelled at and brace for the tide of bug reports: I had hoped we would not have to do this, but it seems that we have to.
-Route all avatar downloads through download.php - adrien -Change the way inline attachments are delivered -Fixes a few (unreported) bugs, notably avatar upload during group generation...
#10191
#10005, #10003, #10001, #9999, #9945, #9965, #9909, #9906, #9877, #9861, #9831, #9830, #9815, #9665, #9624
prosilver adjustments for important announcements in ucp - #9995 MCP fixes for user notes/warnings - #9981 Preserving imageset values on save/edit find a member link for Mass PM's - #9925...
my take on getting the bugs down... thanks to those also providing (usable) solutions to the problem. ;) Of course also to those reporting generally...
some fixes...
other fixes...
- small MSSQL thing - changed how we store tracking data
do not display passworded forum topics within the active topics list if the user did not enter the password before... thanks to gamer4ever for pointing this out (though next time straight to the security tracker please)
fixing some bugs more mcp links for easier moderating different aspects (all, forum, topic) i may have introduced new bugs with this commit due to me having fixed some things weeks ago and some code changed in between - please report if you see something not working as expected.
SEPARATOR, not SEPERATOR... also "neutralised" variable naming as it's used elsewhere outside of pagination. :)
- tiny issue in display_forums() made is possible for get_moderators() to cache the same query twice
ok, handled some bugs... the most important being validate_username (the variable passed to validate_data([...]array('username', [...])) and updating group listings while doing relevant group actions. Oh, and PM icons are working now. :o
Forgot that one for #7110
#7110
- new homographs or IDN confusables ( http://www.unicode.org/reports/tr39/data/international.txt ) - also added character names to old homographs - pagination_sep theme option removed, PAGINATION_SEPERATOR can be set in language files and the theme can overwrite it using span.page-sep [Bug #6872]
- allow login with redirect parameter - altered URL regular expression so it won't cause problem with long URLs - PCRE >:( [Bug #6720] - moderator list on index should have coloured groups in bold as everywhere else too - correctly handle password requirements in UCP [Bug #6692]...
- do not allow setting the parent to currently assigned childs [Bug #6708] - Allow the display_on_index setting to be specified for link forums [Bug #6660] - Rank code in functions_display.php [Bug #6656] - Added some new locations for the viewonline page [Related to bug #6484]...
Unused Code inside function update_forum_data [Bug #6606] Copy permissions protection for groups [Bug #6594] HTML issues in ACP [Bug #6580, #6578] Always send the correct encoding [related to bug #6576] Mass email fixes for first loop iteration [Bug #6570]...
some fixes today - most important change is the consolidation of the display attachment functions; merging them together to have one function we need to call.
#6076 - removed unused junk from functions.php
#6024
rather large update, most important things done: - implemented provided patch/diff file for bug #5350 (Highway of Life) with some tiny changes and alterations - more username/colour changes/fixes - added a note about PM rule-dependant message removals so the user is not wondering too much if he can't remember his rules. :)...
- fixing a bunch of bugs - moved the install trigger error to sessions and also disabled it for those having DEBUG_EXTRA enabled. i hope not having introduced too many new bugs.
some tiny fixes.
- do not cache the activity queries, this is only a lot of overhead (haven't noticed the forums also get included) - back to our known poster name display on viewtopic/topic review. :)
ok, change from doing the same logic all over again we call a function to do it for us. Also allow template designers to choose which method to use by just adding a fully compiled username string (profile link + user colour). This commit may introduce problems.
- fixes for the following bugs: #5326 #5318 #5304 #5290 #5288 #5278 #5276 #5272 #5266 - also fixed the "Call-time pass-by-reference" bug #5252 - within this step changed the normalize calls to require references. - added captcha size variables to the class scope (suggestion was posted at area51)
let the user activity queries only update every 5 minutes
consistant obtain_* functions
Revised attachment categories a bit Fixes for the following bugs: #4830 #4818 #4816 #4810 #4808 #4798 #4796 #4772 #4662 #4646 #4546 #4524 #4270
I hope not having introduced additional severe errors :)
Censor last post topic [#4714]
- forum image being an additional image instead of replacing forum indicators - reasons fixes
- finally removed sql_numrows - sql_fetchfield now in dbal.php - check query id correctly as well as other tiny fixes
#4226
- forgot to make the same change to the ODBC driver - MySQL 3.x works now - FirebirdSQL is now on the same level as MySQL and PostgreSQL, zero hacks exist inside the core code now
- fixing a bug i am unsure about when it occurs (but it occurs). The symptoms are broken template cache files if after removing unnecessary php opening/closing tags result in statements being syntactially incorrect. - added real syncing to forums acp (not only forum statistics rebuild)
These changes should let olympus scale a little bit better. i haven't adjusted the schemas but added the details to create_schema_files - david is able to build them then in line with his changes. :)
some tiny fixes here and there
#4406
- fixed some bugs - changed attachment handling a bit - tried to remove target tags out of the code - do not add session ids to urls for bots as well as not creating a new session on each page view for them
I bet i introduced some bugs too. ;)
Next phase of last post changes + a few minor bugs
Note: This template variable is available but will not be used by default
Error if no post in a forum
Phase 2 of the changes This should now be complete
Initial batch of colourization changes. This includes: - schema changes for first post and last post - display in viewforum, search and ucp of first post - update of database on posting Still outstanding - display of last post
sql_in_set changes
submit some attachment changes/fixes as well as fixing the language pack download for zip files.
- load tracking updates. Need to be tested on a clean installation too - at the moment only tiny quirks are noticed at area51. - reported bugs fixed
- fixed some bugs - made imageset naming more consistent - updated every schema to be consistent and also fixed it (every db should install fine now) -
- fixing some bugs - shortening some db columns to meet the requirements - correctly increase/decrease user post counts - fix the topic title length bug(s)
- BBCode helpline is now customizable
- some bugfixes - set ip_check to A.B.C. by default - display postings in other encodings by default and present link to force the encoding as usual.
hmm... This commit does not increase the number of BBCodes. However, this does other things that we need to do first. This splits the usage of allow_* from the BBCode bitfield in forum descriptions, forum rules and group descriptions. This also fixes a tiny, tiny severe issue that nobody found :D I hope it works :P
- renamed the following columns: comment -> attach_comment new, forwarded, unread, marked, deleted -> pm_new, pm_forwarded, pm_unread, pm_marked, pm_deleted module_name -> module_basename value -> lang_value
- every column is now NOT NULL - every column is now having a DEFAULT value...
- tackle some usability issues - fix bug #3147 - added the lock-images made by SHS` - fixed MSSQL errors (adding the correct ESCAPE sequence)
some bugfixes
Some changes to the way folder images are handled for "special" topics
- correctly display subcategories - use L_TRANSLATION_INFO [Bug #2357] - always begin with ACL_UNSET in permission trace - allow copy permissions when editing a forum - default to parent forum for copying permissions - no duplication of the breadcrumps on registration [Bug #2307]
fix bug #2258
ok, sorry for this. :/ - cleaned up table names/constants
fix bug #2086 remove cached sql results for moderator cache table if re-applying moderators
ok, this one is rather large... the most important change: re-introduce append_sid: old style continues to work, not a performance hog as it was in 2.0.x -> structure is different
apart from this, code cleanage, bug fixing, etc.
#2059
- create forums by default - hide prune options if not enabled - fixed module management enable/disable switch if in module itself - fixed some schema errors - adjusted $user->page array generation for developers calling scripts outside of phpBB root
first round of custom profile changes
- fixing a few smaller bugs/glitches - init user session in cron.php (else it can produce errors if functions expect the user object being set) - fix sql escaping for mssql/mssql_odbc
- fixed dotted topics on some occassions being wrong - fixed post author change - fixed moving topics (they should not count into read tracking now) - think about having only one column for shadow topics/similar to forum links - moved a function from functions.php to functions_display.php (this function is only used by viewtopic and viewforum which already include this file)...
- fixing a few tiny bugs - added new function to (re)apply sids where needed (login and mcp quickmod) - #1829
- introduce new function build_url to easily build a valid url from the user->page object as well as optionally removing certain keys - changed attachment config to utilize the config build methods - cleaned up posting.php - the submit/delete_post functions are now usable (functions_posting.php)...
- fixing some bugs, containing fixes for anonymous username displays, eaccelerator issue, permission trace and a few smaller bugs.
- clean up marklist calls (global function) - added new feature: test out others permissions (admin permissions will not be copied) - changed attachment processing by directly using the template engine - fixed some attachment related bugs - additional tiny fixes
- fixed some bugs - made sql schemas consistent - added correct sequences and generators to sql schemas - extended some rows to hold more data. This solves issues with multibyte characters and too short topic titles, names, etc. - allow multibyte characters in usernames
- fix moving up/down for smilies and icons - display number of total topics in viewforum for forums having active topics set to to true
To all people having their bug status set to fixed: SF pserver CVS access is currently down, therefore the snapshots are still out of date.
- fix a bunch of bugs - <!-- $Id$ --> is no longer allowed in template (.html) files - changed layout of private message screens (folders are menu items)...
- extended session_page and user_lastpage to hold a maximum of 200 chars (instead of 100) - session_page gets truncated to 200 chars - streamlined the process of generating text with bbcode/smilies/urls (forum rules, forum descriptions, group descriptions at the moment)...
- streamlined reports to consist of the feature set we decided upon (Nils, your turn now) - use getenv instead of $_ENV (with $_ENV the case could be wrong) - permission fixes (there was a bug arising with getting permission flags - re-added them and handled roles deletion differently)...
tiny fix so the board won't throw an error if it doesn't have any forums
- moved add_log out of functions_admin (this file should only be included in admin/admin-related pages) - fixed cookie based topic tracking - added missing config variables - other minor things
- acm::exists() is considered private now and was renamed to acm::_exists()
Updated references to posts to be #p[post_id] rather than #[post_id] since it is against the W3C spec to have the id="" attribute starting with a number
- file_get_contents instead of imploding file()s or fread()ing till the maximum filesize - language and style properly use compression - language now prompts user for methods - functions_compress does not need to eval() to get a hex date, instead calls pack()...
- ok, get away with the secondary style approach (styles can be mixed together easily with the acp) - introduce a more generic approach of defining some additional variables through cfg files as well as the name, copyright and version fields - please note that at the moment this is in flux. I added it now for Tom because he needs the theme parameters.
- some SQL:2003 changes (basicly joins, mysql5 is sql:2003 compliant in strict mode now) - postgresql not supporting this standard. :/ - acp changes
- updated topic tracking code - additional changes (mostly bugfixes) - bart, if you update your user table with the user_lastmark field, set it to the user_lastvisit value ;) - and last but not least, introducing some bugs in ucp main front (regarding topic tracking)
- move some functions from global functions file to functions_display (those only needed in posting and viewtopic/forum)
- test slightly modified topic tracking code - some bugfixes
- made path information available to template (T_) - eased topic/post icon in templates (removing hardcoded img) - added S_FIRST_ROW and S_LAST_ROW to template engine
- added updated coding guidelines - introduced is_registered and is_bot flags for correct determinition of guest/registered/bot users - changed bot code to act on useragent || ip
- Documentation related changes - added resend activation email dialog - fixed issue in session code - log failed/successful admin re-authentication/login - fixed simple forum dropdown box (used in mcp and posting)
- and my second attempt
Fix topic count display for subfora
- fixed [code=php] - optimized db/mysql.php a little bit
- some fixes/changes
- fix attachment mod errors - make upload path consistent with all other 2.2 path settings - fix "post title wrong after split" bug
- ucp register/remind/activate fixes mostly regarding account activation - general ucp fixing (profile and ucp_main) - created three new functions (return correct topic author string, generate topic related pagination and get topic type/status...). These general bits are used on several pages (subscribed topics, bookmarks, viewforum)....
- extensions_allowed changed a bit.
- more updates, mostly bugfixes to the bbcode parser - changed current_user in sessions (please review) - give more flexibility to style authors in regard to the pagination elements - profile fields updates (included a sample constuct into viewtopic_body.html - have to be documented extensivly)...
- re-enable polls (user is now able to decide if users are able to change votes if this feature is enabled within the given forum)
- remove output buffering options from download.php (not needed anymore) - optimized viewtopic.php a little bit - removed the create_function (was consuming too much memory) from viewtopic - check for manually added convert[.exe] program name to imagemagick path in admin_attachments...
- added delete cookies link - fixed global announcement links in viewforum - do not display redirects in link forums as posts in forum overview
- forum rules + link to forum rules - three new (tiny) functions added to functions_posting responsible for handling text with bbcode/smilies/urls, use them at items all over across phpbb... - some bugfixes within admin_forums and other files - new admin_board layout (much safer, security wise)
message/mail updates
fix some issues with oop, fixing small bugs and prepare the next steps... NOTE TO DEVS: have a look at adm/admin_board.php (new config layout)
- re-enable drafts. ;) - put extension checking into a small function...
- check for array [lang] - admin_forums delete routine updated - added extension groups per forum
- put consoring and smilie processing into functions (we use them all over the place) for better changing and consistency. - changed docs/AUTHORS to reflect the recent code re-use in functions_messenger.php - pleasing the users a little bit more by using table constants. :D...
inline attachment capability...
Return information for display of active topics in subfora ... little kludgy? but seems to work
Mark given set of forums marked, show "Mark forums read" link on subforum display
Finished drafts, one bit is remaining though. added file and disk space statistics. some minor changes here and there.
related to attachments
new permissions, merged attachment tables (the intended purpose of two tables is no longer valid), attachment updates along the merging...
Note: please merge your attachment tables (develop dir).
bump topic and orphan attachments changes here and there...
optimized update_last_post_information query.
fixed censoring (quote post, word boundaries, attachment comments)
initial draft functionality, loading (and a bunch of other stuff) is not implemented yet + bugfixes.
fixed: slashing attachment comments (hopefully) changed header.
Do away with showing "categories" in the subforum listing ... just output a subforum icon/link ... people appear to want this in preference
a few fixes
some updates...
Yet more updates, topic marking works again ... still intend (optional) checking of "forum read" status on return to index (rather than just the current fudge of visiting the forum), obtain_ranks as a function (used in at least three scripts), removed jabber method that was needed, oops
added: download notice for people unable to see files attached to posts changed: put attachment display into a function now called by posting preview and viewtopic (functions_display.php) fixed: small fix in posting routines, cleanups...
more fun with cookies
Fix forum link redirection when tracking clicks
forum_link_track to forum_flags & 1
page header/footer become functions, forum passwords (I know, I know but it appears a popular feature for some reason ... inclusion not yet set in concrete nor complete), various bug fixes (and no doubt new bugs).
Various updates, forum links, "improve" forum management, cleanups, blah blah, note the schema changes, note also that forum management may misbehave ... reports on wrong doings are welcome ... seem to be having problems with some mcp functions under apache/win32
Only displayed subforum icon if subforums were set to display_on_index
Fixed error in handling sub-forum data when displaying "categories"
Various changes, and tests ... marking/tracking is not complete ... tinkering, changing, etc. still to be done ... it's just I've made numerous and various changes to different files so a commit really is due
Fixed some undefined variables
oops, I completely forget that viewforum uses the new topics_marking table ... guess I need to commit all related changes after all ... pooh
icon name change
Add forum image to template vars
lastread stuff is just causing too many problems with repeated forums at present - disabling till fixed
Un-b0rked ACL options caching, small general fixes
Very minor changes.
Initial Lastread support. Mind the schema and config changes\!
Moved profile.php to ucp.php. ucp is really really broken right now, don't even think about trying to use it.
Cache moderator names? Output moderators for all forums in viewforum. Alter a few things in templates
"Fix" problem with forum_id being overwritten by sub forum listing
Output nothing if moderator display is "off"
Minor change to remove total_post count
Fix couple of errors ... you should run UPDATE phpbb_users SET user_permissions = '' after this update
Cleaned up viewforum/index, altered template class to replace missing lang strings with a nicely formatted text, pre-implemented topics prefetching and broke some things.
Fix a couple of issues, hopefully haven't broken anything Ashe was planning ...
Subforums update take #1