View | Annotate | Download (48 KB)
Copy 3.0.x branch to trunk
Fix Bug #51835 - editing posts with attachments - regression from r9843 introduced in #48265
Authorised by: AcydBurn
fix #51235 - regression from 9843 for #48265
#48965
Fix bug #1309 - Multiline [url] not Converted Authorised by: AcydBurn
Fix Bug #47295 - Min/max characters per posts also affects polls option
Fix bug #48265 - Correctly set attachment flag for topics, posts and pms after deleting attachments - Patch by WorldWar and nickvergessen
Color bbcode now supports three-digit hex notation. (Bug #39965 - Patch by leviatan21)
- add options for quick reply (forum-based and board-wide) - add option for minimum post chars (which is a required setting for quick reply, therefore we introduce it here)
#40865 - no message parsing for messages evaluating to false
Revert r9422 while we come up with a better fix
Fixed bug # 42885 - "Select all" selects much too much in Opera Authorised by: acydburn
fix bug #42785
Fixed bug #'ers 41295, 41385, 41955, 41705 and 41985
Authorised by: acydburn
Fixed bug #40565 – Missing end " in quote bb tag deletes text Authorised by: acydburn
Complete fix in r9007
Parse BBCode lists of type square, circle and disc. #35295
some changes for proper code documentation
#26795
do not allow [flash=0,0]... not implemented for images due to the reliance on getimagesize() - as usual both sizes are able to be limited by the maximum/minimum image size configuration options
Hiding everywhere little buggers, eh?
#22865
- Fix quote bbcode parsing adding too much closing tags on special conditions - #20735
Correctly return sole whitespaces if used with BBCodes - #19535
#19955
Correctly check empty subjects/messages (Bug #17915) Do not check usernames against word censor list. Disallowed usernames is already checked and word censor belong to posts. (Bug #17745) Additionally include non-postable forums for moderators forums shown within the teams list. (Bug #17265)
This commit was manufactured by cvs2svn to create branch 'phpBB-3_0_0'.
do not allow [size=0]
further updates
fixing some annoying bugs
prevent posting empty messages with some UTF8-characters as well as fixing conversion in CVS.
some tiny bugfixes
dumdidum... sorry. ;)
#i71 #i72
#i8
- BBCode parsing order should ALWAYS be censor_text(), bbcode_secon_pass(), bbcode_nl2br(), smiley_text(), parse_attachments() - using \r on custom bbcodes to allow line breaks [Bug #10758]
#14132
- added information about Unicode to coding guidelines - two little changes
some bugs fixed
Cleaning up (#13689) Also removed the useless login box from the ACP.
even more fixes. :o
some more fixes
if used more than once, do not print out notices. ;)
fixing some bugs
my round of bug fixes
um, oops
#11833
#12189
removed a looped regex
ok, mess around with the templates + fixing some bugs + adjusting headers for those files already modified to circumvent conflicts for those having their editor set to remove trailing spaces (not recommended!)
do not strip our pre-parsed text if it is outside or between code blocks
fix an improper fix. - generally, sorry, but direct url parsing after ] will no longer work... - try to eliminate the most common "bug" for placing urls within the [url=][/url] part (the text). This will trigger make_clickable and render the url invalid (doubled url), moreso if other text is involved too. This is still te case if the url is not written directly after the [url=] part. This is nearly the best we can get within 3.0.x - and every report about [url=], [url] and make_clickable and it's non-parsing or parsing will be closed with "will not fix", except it is a critical bug resulting in the non-functioning of the board. We may adjust this later to our own liking while we try to find different ways to face these problems.
#11429
we included a check for getimagesize() existance... now we again can suppress notices while running this function.
errr, allow linkage to download.php....
ok... enough of this. Do not change [quote] layout at all. Smilies, urls, etc. won't parse now again directly after quotes - away with this. Actually we do not need to babysit users, but the feature was nice and fixed an inability which anoyed me in 2.0.x. Hey, you can't have everything - at least it is no longer error prone.
Fixing some tiny bugs... - correctly close span tags within code=php
#10982
- correctly transfer the search query across search result pages - changed highlighting so foo* will match foo again [Bug #10031] - restructured magic urls (functionality still mostly the same), added a check for entities in urls and punctuation at the end of magic urls [Bugs #10639, #10293]...
ok, parsing code correctly now? ;)
We do not support nesting code tags - #10763 #10741 Confirm box on pruning forums - #10619 Not stripping empty lines on parsing messages - #10579 Remove reports alongside with users - #10501
#10635 This should work, it could be made more strict but am leaving it alone for now
bugfixes. :/ An ugly one included as a temporary solution...
#9811
my take on getting the bugs down... thanks to those also providing (usable) solutions to the problem. ;) Of course also to those reporting generally...
#8572
This actually bugged me to for a long time too.
stupid debug code :P
#8456
- fix htmlspecialchars handling in search (search backends get specialchared input, and should return specialchared output), current backends strip entities anyway [includes Bug #8156] - allow cancelling search index creation/removal - custom CSS class name input too short [Bug #8328]...
#8244 - cleaned up the TRUNCATE/DELETE FROM in the native search backend - fixed an imporoper default value on some upgrades
adjust text for getting image dimensions as well as not suppressing warnings for getimagesize()
- found a small bug in the list parser while working on another bug
#7228
- some bugfixes - bugfixes for the convertor (typecasting for example was totally broken)
#6598 - should have fixed all uses of curly braces
sprintf
#6542
some fixes today - most important change is the consolidation of the display attachment functions; merging them together to have one function we need to call.
- Changed handling of the bitfield in bbcode.php - #6270, reverted to an earlier version of list handling + bug fixes
- Optimize acl_getf_global a bit - a little performance improvement of the IP regular expressions - convert post_text/subject collation to utf8_unicode_ci if a user wants to use mysql_fulltext to allow case insensitivity [Bug #6272] - mysql_fulltext should alter all necessary columns at once to speed up the process...
until nils comes to inspecting this further we will use this "workaround"
#6090 - some cool regex stuff (one of them looks kinda weird :\ ...)
- re-add script_path for "strange configurations" to let them force the generated urls correctly - show rank title if no rank image present in memberlist - other fixes.
some updater changes as well as tiny bugfixes
#5610
hopefully fixed bug #5644 while also retaining the fix for bug #3572 testing this is appreciated.
Where are you coming from $in? I do not think i invited you...
- fixes for the following bugs: #5326 #5318 #5304 #5290 #5288 #5278 #5276 #5272 #5266 - also fixed the "Call-time pass-by-reference" bug #5252 - within this step changed the normalize calls to require references. - added captcha size variables to the class scope (suggestion was posted at area51)
message
ok, i am an idiot...
- implemented the suggested html_entity_decode function made by david - fixed string length checking by also decoding entities for the sake of checking - used the new html_entity_decode function
- store sql_layer directly within the layer itself - new method sql_multi_insert to circumvent db-specific hacks (hopefully not introduced any parsing errors)
he braces style is deprecated as of PHP 6
strpos...
tried to begin adjusting all string functions where applicable - still a lot to do. i hope i catched all relevant sections and did not mess something up.
- forgot to make the same change to the ODBC driver - MySQL 3.x works now - FirebirdSQL is now on the same level as MySQL and PostgreSQL, zero hacks exist inside the core code now
bug fixes schema changes i really hope nothing went wrong
- fixed some bugs - changed attachment handling a bit - tried to remove target tags out of the code - do not add session ids to urls for bots as well as not creating a new session on each page view for them
I bet i introduced some bugs too. ;)
- fixing profile bug - adjusting acl_gets calls (they are or'd - make sure they get checked correctly based on the situation) - automatically assign the u_download and u_search permission to the guest group
some updates. Also adjusted the utf tools and normalizer more to our coding guidelines.
If i could force you all to use PHP 5.1.0+, then i could just use the count param with preg_replace. Oh well...
sql_in_set changes
so.... what does this thing do?
well, the super fast, ultra efficient, massively huge BBCode handling system was implemented differently on each DBMS. Although this provided the best performance, the solution was a bit hacky.
So what does this new thing do? We use base64 encoding to make everything nice and shiny, it turns into nice, safe characters that we can just jam into varchars on essentially any database. This has two implications: we must decode every bitfield we get AND we have slightly fewer IDs to work with. It goes down from 2040 BBCodes to 1512. We lose like a quarter of them :P...
- custom profile field fixed - fixing sql_fetchfield from cache - changing the quote parser. In my tests i have not seen changed behaviour - but i might have broken something with this change.
OK...
This commit should increase the total number of BBCodes from 31 to 2040. Some things to watch out for:
Each database likes to deal with binary data in its own, special way. They are, quite frankly, too cool for school.
MySQL, MSSQL and Oracle all allow me to send in a default value for their binary column using a hex number. However, MSSQL forces me to send the specific data as a hex number and thus we must CAST it....
- renamed the following columns: comment -> attach_comment new, forwarded, unread, marked, deleted -> pm_new, pm_forwarded, pm_unread, pm_marked, pm_deleted module_name -> module_basename value -> lang_value
- every column is now NOT NULL - every column is now having a DEFAULT value...
- tackle some usability issues - fix bug #3147 - added the lock-images made by SHS` - fixed MSSQL errors (adding the correct ESCAPE sequence)
some bugfixes
- add additional auth check to the permission roles modules - added new function to return globally used expressions (get_preg_expression($mode)). This should be very helpful in getting wide spread similar checks (regular expressions) to one place reducing the risk of forgetting to change every location if you fix one. ;) We will add additional ones later, at the moment only the email check is retrieved......
time to squash some bugs
oops?
- removed db cache (might re-appear, but for now we do not see the need for it) - all changes to styles/subsilver/template are purely cosmetic (no functional changes) - cosmetics - bugfixes - add index to modules table - use modules ordering code for forums too
- automatically sync topic_reported when deleting a post [Bug #2152] - retrieve forum information in report.php - don't update deleted topics - proper permission check for "admin or moderator" - allow changing poster while ip dropdown contains a different user [Bug #2190]...
make sure custom profile fields are created correctly on registration (#2225)
- added class="radio" to all radio- and checkboxes - make sure the database gets closed correctly in cron.php - bugfixes
removed the ability to parse after closing brackets, since this seems to create a bunch of new problems added a space after quotes for correctly parsing urls/smilies instead of splitting the url just compare with strpos david: please review once you get home. :)
- fixed a few bugs - added user_add() function - check posted images ([img]) for same domain/scipt and php files - auth_api.html updated to the coding guidelines look&feel - introduced ability to force non page-updates (cron is using it) - correctly resend coppa email
;-)
try to prevent re-parsing of parsed bbcode content
- a few adjustments to permissions, specifically with regard to global topics - forgot to change a line in permission trace [Bug #2100] - syntax highlighting for php5 - [Bug #2093]
- fix some smaller bugs - removed custom profiles preview field from acp
ok, this one is rather large... the most important change: re-introduce append_sid: old style continues to work, not a performance hog as it was in 2.0.x -> structure is different
apart from this, code cleanage, bug fixing, etc.
make sure we check the attachment status for the correct user ;)
- removed useless code from style.php - added a view template cache mode to acp_styles - syntax highlighting for the acp css - completed refresh actions for themes and templates - fixed theme and template installation - use a function for generating database theme data...
some tiny changes...
- Firebird is people too
- introduce new function build_url to easily build a valid url from the user->page object as well as optionally removing certain keys - changed attachment config to utilize the config build methods - cleaned up posting.php - the submit/delete_post functions are now usable (functions_posting.php)...
- fixed ul/li margin - fixed [code=php] tag (tags got mangled on edit) - fixed a tiny issue within the ban function
- removed group settings from roles - added forum icon in front of forums in permissions acp - added trace permissions in permission masks (thanks naderman for writing the first code and for the idea... :)) - some bugfixes - PHP6 fix
- clean up marklist calls (global function) - added new feature: test out others permissions (admin permissions will not be copied) - changed attachment processing by directly using the template engine - fixed some attachment related bugs - additional tiny fixes
To all people having their bug status set to fixed: SF pserver CVS access is currently down, therefore the snapshots are still out of date.
- fix a bunch of bugs - <!-- $Id$ --> is no longer allowed in template (.html) files - changed layout of private message screens (folders are menu items)...
my attempt to fix custom profile fields
- added the load settings for custom profile fields - re-added our famous make_clickable function - removed group_by clauses (due to the lang id selection the group by clause is no more needed)
I hope that i have not just created new bugs. ;)
ahhh, there we have it... related to several reports about code blocks and bbcode parsing (#1302)
- Fixed my fix :D
- Bug 1100
- added "display_on_posting" setting to custom bbcodes (creates a button with the bbcode tag) - fixed forum editing and parent id selection - completely removed HTML support (it only creates security problems) - changed cache_moderators() to reflect permission changes
- some bugfixes - committed coding guidelines as they are at area51 - removed script_path (needs a close inspection later) - removed the need for server_name and server_port - able to define server port/name/protocol and force the user-defined server vars (very handy for proxy setups)
Another one bites the dust :D
- Nicer way of cleaning junk in PM export - Added various signature and posting controls :P
implementing permission roles
- copy permissions (adding groups) - copy permissions (adding forums) - checking proper groupadd/del settings - added intro page to permissions (to give an overview and quick links) - able to select forums + subforums, single forum, all groups, all users (permission screens)...
- implementing David's proposed expression changes (some of them already noted within the events CCP)
just preparing...
- overhauled search system - updated structure for search backend plugins - better result caching using ACM - search results no longer session restricted => link to them by copying the URL :) - in-topic search - indexing posts now uses search backend plugins...
- user avatar, user signature, user attachments
- drop in the new administration panel - not finished yet: some user related items, style admin, database admin and permissions - Graham: Please add your MCP schema data to the schema data file. ;)
- some SQL:2003 changes (basicly joins, mysql5 is sql:2003 compliant in strict mode now) - postgresql not supporting this standard. :/ - acp changes
- added new query type to dbal's sql_build_array - allow setting custom template path - adjusted module class to correctly parse trees with more than one category - added caching to module class
fix bbcode in bbcode problem
- changed dbal class layout
- fixed breaking quote bbcode ([quote])
- fix two small errors i "introduced" a while back. ;)
- fixed url parsing ([] breakage)
- fix issue with malicious protocols - check input on every hardcoded bbcode/check for empty content
- test slightly modified topic tracking code - some bugfixes
- fix [list] preview and list parsing in general (no [ and ] breaking)
- Documentation related changes - added resend activation email dialog - fixed issue in session code - log failed/successful admin re-authentication/login - fixed simple forum dropdown box (used in mcp and posting)
- and my second attempt
fix admin_session "bug"
BBCode enabled profile fields, removed field_name from profile fields, fixed some uninitialised variable issues, some small conversion issues
- bugfixes - do not hardcode url bbcode tag (please change the bitfield accordingly - see schema file!)
- split long urls fix (& into &)
- fixed [code=php] - optimized db/mysql.php a little bit
- some fixes/changes
- letting urls work again, fixing [code] breakage on urls, corrected magic_url to be able to parse urls at the beginning/end of bbcode blocks - fixed "edited by" message.
Some small touchups
- a bunch of updates, most of them bbcode related
/me destroyed posting messages completly, now operating normal again. :) (... hopefully, never trust a dev)
- search updates
- search indexing fix
- more updates, mostly bugfixes to the bbcode parser - changed current_user in sessions (please review) - give more flexibility to style authors in regard to the pagination elements - profile fields updates (included a sample constuct into viewtopic_body.html - have to be documented extensivly)...
- re-enable polls (user is now able to decide if users are able to change votes if this feature is enabled within the given forum)
my turn to break the forum (and at least pm's are no longer working - will not last long). HARRRR
- made message parser more clear - changed smilie processing again (let's see which bugs pop up here) - fixed url processing, you know this broken links... ;) see important note (maybe the other devs can help here) - more control over processing html, emoticons and magic urls (if used for other purposes)...
message/mail updates
fix some issues with oop, fixing small bugs and prepare the next steps... NOTE TO DEVS: have a look at adm/admin_board.php (new config layout)
- check for array [lang] - admin_forums delete routine updated - added extension groups per forum
minor adjustments
small fix for html replacement
removed message type from message parser assign message if specified parse/decode html if enabled validate url
inline attachment capability...
fixed: smilie parsing in signatures added: edit notes
Minor change: check for potential bbcodes before we parse the message
my attempt to break things...
Finished drafts, one bit is remaining though. added file and disk space statistics. some minor changes here and there.
new permissions, merged attachment tables (the intended purpose of two tables is no longer valid), attachment updates along the merging...
Note: please merge your attachment tables (develop dir).
bump topic and orphan attachments changes here and there...
Let's break lots of things
optimized update_last_post_information query.
request_var updates attachment updates/fixes
Allow/disallow [quote] tags. If we make any other bbcode disable-able we should consider passing them in an array ;)
some small fixes got rid of iframe (topic review)... tested new div method with various browsers, further testing and oppinions would be nice. ;) NOTE: New css element added to theme
fix poll parsing
Trim emoticon preg
username quoting should be working again...
okie, using array_merge. :D fixed: admin_prune added: prune topics last viewed at... (only admin_prune ATM) moved: delete_attachments to functions_admin
some sync-related updates... more logical processing of submit_post.
initial draft functionality, loading (and a bunch of other stuff) is not implemented yet + bugfixes.
speed up split words a tad
fixed: slashing attachment comments (hopefully) changed header.
Added: admin definable bbcodes Changed: preg references, use the prefered $n form instead of the old \\n one Fixed: tweaked PHP highlightning a little
saved one query by moving max smilie check to the emoticons function
Fixed the error message for too many quotes
sqlite support UNION ALL SELECT method
Shifting bits appears to be faster than the pow() function
a few fixes
some updates...
thumbnail creation support
Changed: while validating quotes usernames, the loop will end at the first incorrect bbcode pair
Majority are UCP related updates ... avatars should now work, aside from gallery, fixed a few other issues, updated schema/basic
Changed: \r\n becomes \n within posts Added: width / height parameters to flash Added: bbcodes validation within quotes usernames
Changed: $warn_msg changed into a class var. (allows from returning errors from regexps) Added: max_quote_depth Changed: PHP syntax highlightning modified to use CSS classes instead of <font> tags
Enable view limiting functions ... Ashe, not sure if this is compatible with your thinking for bbcode but it seems the "logical" way to handle disabling of bbcode/flash in this manner. Fixed issue with automatic url handling of local links
Added: [/*] tag (list item end tag). Automagically added if needed, in which case it's stored as [/*:m:$uid]
a few updates, added #539865 and #694413.
Fixed quotes having bbcodes in author name
email topic, minor other changes, removed updating of parent forums upon posting (handled by functions_display)
Various updates, forum links, "improve" forum management, cleanups, blah blah, note the schema changes, note also that forum management may misbehave ... reports on wrong doings are welcome ... seem to be having problems with some mcp functions under apache/win32
changed attachment processing (posting), the old way was a mess. :)
Fixed: imbricated quotes Added: individual bbcodes can be disabled. (still has some bug, not sure where though)
Re-enabled polling ... includes option of multiple choice polling, indication of option voted for, etc. ... preliminary implementation, various things need finishing
First-pass syntax highlightning. Will fix quotes later
Update of comment :D
Replied to comment, no code changes
some arrangements...
More bbcode fixes
Added syntax highlitning for [code]. [code] is now case-insensitive. Nothing else to mention ;)
Enable/disable fulltext index updating
$message is now processed in its unslashed form. Should not break anything...
changed $message to be a class variable, added attachment category constants (now images are displayed inlined by default... no wrong assignments anymore, if you wondered why your zip file got streamed. ;))
BBCode parser + decoder, missing some tags and mildly broken at this time
initial 'view attachments' implementation. added new template var (merged include, to preserve previous block vars), could be changed later to consider caching. some config variables and upload icons are not present as of yet...
Did you know that if you use backslashes in a log message WinCVS freaks out and commit files at random? I didn't either.
Weekly update: MCP templates. Forms renamed to 'main', added mcp_jumpbox.html for easy jumping and mcp_foruminfo.html. Not too happy with HTML though =" templates\subSilver\mcp_forum.html templates\subSilver\mcp_foruminfo.html templates\subSilver\mcp_front.html templates\subSilver\mcp_header.html templates\subSilver\mcp_jumpbox.html templates\subSilver\mcp_move.html templates\subSilver\mcp_post.html templates\subSilver\mcp_viewip.html templates\subSilver\mcp_viewlogs.html
initial attachment functionality... only posting related (add/delete/edit) and schema. Also added attachment switch to board settings admin.
prepare files, last commit before committing initial attachment functionality - please see thread within development forum.
I keep forgetting changes to line terminators and tortoisecvs 1.3.4+
Problem with url matching + spaces
forum and topic notification + poll fixes
some posting updates and fixes.