View | Annotate | Download (59.2 KB)
Copy 3.0.x branch to trunk
Fix Bug #50475 - Only show "Add friend" and "Add foe" links if the specific module is enabled.
Authorised by: AcydBurn
populate who is online only where required
require link hash for switchperm
Change bug #47425 - IP data lost on pagination
Changes to r9617 Fix a template compilation issue, and reshuffle the code. The added template complexity made it more of a problem to check the variables correctly, hence simplification.
Fix bug #10519 - "View user notes" and "Warn user" links shown even if modules disabled Authorised by: acydburn
Fixed bug #'ers 42585, 35505, 36675, and 42705 Authorised by: acydburn
#43665
Fix a regression from r9075
do not display ban link for own profile
Only display special ranks to guests; no longer display normal ranks for guests (Bug #36735) [a bit ugly, but retains backward compatibility]
Do not display COPPA group in memberlist find member dialog if COPPA disabled (Bug #37175)
Fix, small cosmetic issue made in r9004 with sort urls
Fix r8929 and #35275
Make pagination work again, undoing rev8830 to fix #32515 properly
should make last_active work again
- Added 'max_recipients' setting for private messages. This setting allows admins to define the maximum number of recipients per private message with a board-wide setting and a group-specific setting. - Added new permission setting for sending private messages to groups. Now there are two permissions to define sending private messages to multiple recipients and private messages to groups.
Do not jump back to page 1 when hiding member search in memberlist. Closes #32515
actually, queued posts can also be in forums with no post counts
Show users posts in queue in acp and profile + link to mcp
Changes to group display #32155, #32145, #32085, #26675, #26265
#28595 (AVATAR_IMG available to memberlist_body.html)
same here, session id.
What use is a shiny banstick(TM) if nobody finds it?
#24435
Hiding everywhere little buggers, eh?
only allow users having the a_user permission to search by email address (later on there will most likely a new permission for general email visibility)
Pertain select single link on memberlist (Bug #23235 - patch provided by Schumi)
#22805
Try to sort last active date on memberlist correctly at least on current page (Bug #18665) - patch provided by phillipK
Correctly check empty subjects/messages (Bug #17915) Do not check usernames against word censor list. Disallowed usernames is already checked and word censor belong to posts. (Bug #17745) Additionally include non-postable forums for moderators forums shown within the teams list. (Bug #17265)
This commit was manufactured by cvs2svn to create branch 'phpBB-3_0_0'.
dumdidum... sorry. ;)
Ok, here comes a big one. Poor updater. Also requires testing.
#i91 #i92 #i93 #i94 #i95 #i96
#i62 - #i65 gone through every javascript invocation and making sure we adhere to our coding guidelines.
some fixes. :P - language authors may review their email template files...
ups
necessary changes...
- BBCode parsing order should ALWAYS be censor_text(), bbcode_secon_pass(), bbcode_nl2br(), smiley_text(), parse_attachments() - using \r on custom bbcodes to allow line breaks [Bug #10758]
do not get too excited
#13751 Fixing date CPFs for multilanguage boards.
try to normalize everything...
Cleaning up (#13689) Also removed the useless login box from the ACP.
#13679 #13681 #13683
Adding finer error conditions to the IM contact page. Adds one language entry, moves one from viewtopic to common.
again, a lot of bug fixes
#13107 #13107
some fixes. :)
some fixes...
fixing some bugs
yeah, forgot these few lines. :(
tweak the sql_like_expression feature a little bit to allow correct escaping
new wrapper for LIKE expressions to streamline the fixes. We actually need to adjust them for different DBMS as well as SQLite2 not supporting escaping characters in LIKE statements (which is a reason why we think about dropping sqlite support completely).
Changing the behaviour of the hideonline permission.
Test the current setting before altering the memory limit during install(Bug #12195)
And another language var.
ok, mess around with the templates + fixing some bugs + adjusting headers for those files already modified to circumvent conflicts for those having their editor set to remove trailing spaces (not recommended!)
Adding a little more exlanation about flash. Enabling FLASH per default while leaving the default permissions to disable it. There might be no mods and admins visible one a board #12185
#10823
Make the life of style authors not too complicated.
added class for disabled options in ACP E_USER_ERROR now using language keys if available [related to #10445] UCP/MCP title tags [#10441] Check $start parameter in viewforum [#10435] Check for postable forum for moving user posts within users ACP [#10433]...
"Ghost" topics in active topics list when shadow topics and corresponding topic in same resultset [#10313] Find a member supporting hidden groups for those able to see them [#10305] Display hidden groups for all those able to see them across the board (composing messages, viewonline)...
fix wrong query for searching by group id. If not within group mode we only need the user details too (hopefully)
#10005, #10003, #10001, #9999, #9945, #9965, #9909, #9906, #9877, #9861, #9831, #9830, #9815, #9665, #9624
prosilver adjustments for important announcements in ucp - #9995 MCP fixes for user notes/warnings - #9981 Preserving imageset values on save/edit find a member link for Mass PM's - #9925...
#9985
- m_warn is no longer a local moderation permission - magic urls should properly use html entities - speed up posting on big boards, MAX query can be simplified a lot in certain cases - user IP list should be labelled with "Other users" [Bug #9707]
my take on getting the bugs down... thanks to those also providing (usable) solutions to the problem. ;) Of course also to those reporting generally...
#9674
#9605
other fixes...
display those as admins having admin permissions and being within the administrators group (admin group does not need to be the default one)
help day!!!! it would help to limit the number of rows returned... we are not dolly the sheep. :P
grmbl
again... some more fixes.
- fix some group specific bugs - correctly determining terrafrost's birthday mod
#8470
- subtle, very subtle
- pretty sweet speed increase
fixing some bugs more mcp links for easier moderating different aspects (all, forum, topic) i may have introduced new bugs with this commit due to me having fixed some things weeks ago and some code changed in between - please report if you see something not working as expected.
some fixes to be committed.
only some minor fixes
- fix some oddities (doubled spaces for example) - changed the way make_forum_select() is returning the forum list - now including skipped forums but being disabled. This should make identifying the correct forum much more easier. - Changed some permission namings based on suggestions by the community...
- added confirm box to ucp zebra (adding fried/foe) - permission fixes for conversions - use more appropiate error message within convertor if source tables could not be found - other tiny fixes
ok, handled some bugs... the most important being validate_username (the variable passed to validate_data([...]array('username', [...])) and updating group listings while doing relevant group actions. Oh, and PM icons are working now. :o
Some cleanup. Be gone you outdated JS code!
fix some general bugs and some convertor related
#6098 "Find a member" now supports single clicks. Thanks for Highway of Life for helping out here. :)
- do not allow setting the parent to currently assigned childs [Bug #6708] - Allow the display_on_index setting to be specified for link forums [Bug #6660] - Rank code in functions_display.php [Bug #6656] - Added some new locations for the viewonline page [Related to bug #6484]...
- telling the admin for what the board contact and board email addresses are used for and also making sure this explanation is correct ;) - fixes for bugs #6694, #6664 and #6662
- fixed bug within the database update script - #6254 - #6242 - #6184 - #6160 - #6020
- finally correctly calculate current time for birthday calculation [Bug #6030] - allow searching forums with unsearchable subforums [Bug #6056] - addition of an optional HTTP_X_FORWARDED_FOR check in sessions, including bans - do not index forums which have indexing disabled on index recreation [Bug #6060]...
- tiny bit of sunshine :D
- re-add script_path for "strange configurations" to let them force the generated urls correctly - show rank title if no rank image present in memberlist - other fixes.
- a bunch of fixes - added todos to the updater to make sure i do not forget. :)
fix for bug #5586
- bug fixes for #5618, #5588 and #5584 - remove messenger->reset() calls (they are already performed on sending)
rather large update, most important things done: - implemented provided patch/diff file for bug #5350 (Highway of Life) with some tiny changes and alterations - more username/colour changes/fixes - added a note about PM rule-dependant message removals so the user is not wondering too much if he can't remember his rules. :)...
fixes for bugs #5564, #5554 and #5462
- fixing a bunch of bugs - moved the install trigger error to sessions and also disabled it for those having DEBUG_EXTRA enabled. i hope not having introduced too many new bugs.
ok, change from doing the same logic all over again we call a function to do it for us. Also allow template designers to choose which method to use by just adding a fully compiled username string (profile link + user colour). This commit may introduce problems.
consistant obtain_* functions
let utf8 mails work again. I hope this is not giving problems for "strange" mail setups.
ok, i am an idiot...
- make sure the sql layer for mysql always states mysql4 and get to mysql if using mysql < 4 - assign some default vars to email templates (we always need some basic ones)
- implemented the suggested html_entity_decode function made by david - fixed string length checking by also decoding entities for the sake of checking - used the new html_entity_decode function
some fixes
- Handle upper/lower case in memberlist properly [Bug #5012]
- adjust unread query a bit to cope with large topics (thanks bart!) - fixing some bugs - more username_clean work
- introducing clean usernames, needs to be tested more, I'm not sure I didn't miss anything - homograph list should probably be extended
View profile now shows relevant add/remove links
tried to begin adjusting all string functions where applicable - still a lot to do. i hope i catched all relevant sections and did not mess something up.
These changes should let olympus scale a little bit better. i haven't adjusted the schemas but added the details to create_schema_files - david is able to build them then in line with his changes. :)
- no more encoding mixture, say hello to UTF-8 (I'll add a validation solution for PHP 4.3.3/4 ASAP) [side effect: fixes Bug #3762] - take local server time into consideration for birthday/age calculation - faster active topic search - allow changing active topic time frame [Bug #4150]...
- fixed some bugs - changed attachment handling a bit - tried to remove target tags out of the code - do not add session ids to urls for bots as well as not creating a new session on each page view for them
I bet i introduced some bugs too. ;)
- birthdays/age in user's timezone and not server's local time - parse bbcode in posts with fewer characters than selected maximum on search results page - retrieve search word context in posts which are longer than maximum characters (no raw BBCode anymore)...
Duplicated entry in the sort options + misc template issues
sql_in_set changes
- finally making the age calculation work [Bug #3582] - replacing all occurances of L_NONE with a more specific string [Bug #3494] - a few corrections to html id attributes in the installer - using correct permission in mcp_report [Bug #2471] - allow deleting the avatar, when no upload method is enabled and hide the delete button if no avatar is set
- fixed some bugs - made imageset naming more consistent - updated every schema to be consistent and also fixed it (every db should install fine now) -
- custom profile field fixed - fixing sql_fetchfield from cache - changing the quote parser. In my tests i have not seen changed behaviour - but i might have broken something with this change.
- fixed the age calculation (note: turn on your brain before commiting something like this the next time) [Bug #3337] - removed the split_words array, introduced an enforced search_query - the forum used for global topics in the search is now a forum, and no longer a category [Bug #2561]...
- some bugfixes - set ip_check to A.B.C. by default - display postings in other encodings by default and present link to force the encoding as usual.
hmm... This commit does not increase the number of BBCodes. However, this does other things that we need to do first. This splits the usage of allow_* from the BBCode bitfield in forum descriptions, forum rules and group descriptions. This also fixes a tiny, tiny severe issue that nobody found :D I hope it works :P
add not applied sql_escape in memberlist
- renamed the following columns: comment -> attach_comment new, forwarded, unread, marked, deleted -> pm_new, pm_forwarded, pm_unread, pm_marked, pm_deleted module_name -> module_basename value -> lang_value
- every column is now NOT NULL - every column is now having a DEFAULT value...
- tackle some usability issues - fix bug #3147 - added the lock-images made by SHS` - fixed MSSQL errors (adding the correct ESCAPE sequence)
- display age in user profile and make it available on viewtopic - various tiny bugfixes including [Bug #2351] [Bug #2549] [Bug #2681] [Bug #3015] - strip first, then change newlines [Bug #2403] - added support for creating user profiles to the login function (makes use of user_add), triggered by LOGIN_SUCCESS_CREATE_PROFILE constant...
some bugfixes
- add additional auth check to the permission roles modules - added new function to return globally used expressions (get_preg_expression($mode)). This should be very helpful in getting wide spread similar checks (regular expressions) to one place reducing the risk of forgetting to change every location if you fix one. ;) We will add additional ones later, at the moment only the email check is retrieved......
Apply load_onlinetrack to view profile as well
time to squash some bugs
fix bugs #2271 and #2273
- allow searching for post_count = 0 [Bug #2154] - better permission check for user search by ip - permissions for max attachments adjusted
- forgot to commit common.php - cleaning up a few more mcp permissions - adjust some links - make global topics work properly in MCP
Warn user links #2153
ok, this one is rather large... the most important change: re-introduce append_sid: old style continues to work, not a performance hog as it was in 2.0.x -> structure is different
apart from this, code cleanage, bug fixing, etc.
- create forums by default - hide prune options if not enabled - fixed module management enable/disable switch if in module itself - fixed some schema errors - adjusted $user->page array generation for developers calling scripts outside of phpBB root
- added search by author_id to solve problems with looking up posts of users with a name containing wildcards - user based flood control (seperate limits for users and guests) [Bug #1357] - inform the user about ignored words if he receives a "no words specified" message...
some tiny changes...
- fixed a few smaller things
a few changes ;-)
- fixing a few tiny bugs - added new function to (re)apply sids where needed (login and mcp quickmod) - #1829
eh? meh.
This is a screwy world! Screwy I tell you!
HA - classical
- introduce new function build_url to easily build a valid url from the user->page object as well as optionally removing certain keys - changed attachment config to utilize the config build methods - cleaned up posting.php - the submit/delete_post functions are now usable (functions_posting.php)...
ok, maybe now? test new sf infrastructure again, now using the syncmail script in out cvsroot directory
- introduce LA_, UA_ and A_ template variables (they allow styles to use template variables used for javascript in subSilver outside javascript in their own template while they won't break our javascript if they contain quotes) also fixes [Bug #1116] - corrected page title for search indexing progress bar [Bug #1695]...
I hope nothing broke!
- Added a query builder, it is currently only used for complex queries that involve a FROM clause with two tables and a left join - Changed some function calls in the DBAL - Made the viewtopic queries nicer
- some adjustements for phpdocumentor
- fixing some bugs, containing fixes for anonymous username displays, eaccelerator issue, permission trace and a few smaller bugs.
- Bug #1257
- removed group settings from roles - added forum icon in front of forums in permissions acp - added trace permissions in permission masks (thanks naderman for writing the first code and for the idea... :)) - some bugfixes - PHP6 fix
- clean up marklist calls (global function) - added new feature: test out others permissions (admin permissions will not be copied) - changed attachment processing by directly using the template engine - fixed some attachment related bugs - additional tiny fixes
- fixed some bugs - made sql schemas consistent - added correct sequences and generators to sql schemas - extended some rows to hold more data. This solves issues with multibyte characters and too short topic titles, names, etc. - allow multibyte characters in usernames
To all people having their bug status set to fixed: SF pserver CVS access is currently down, therefore the snapshots are still out of date.
- fix a bunch of bugs - <!-- $Id$ --> is no longer allowed in template (.html) files - changed layout of private message screens (folders are menu items)...
Do not display adding friend/foe for anonymous and users own profile
- extended session_page and user_lastpage to hold a maximum of 200 chars (instead of 100) - session_page gets truncated to 200 chars - streamlined the process of generating text with bbcode/smilies/urls (forum rules, forum descriptions, group descriptions at the moment)...
- hopefully fixed inactive create forum input field + button for safari 2.0.2 (floating issue?) - updated format_date calls (fixed ancient calls) - fixed newest username setting for activating users through the admin panel
added some language strings as well as fixing the activity listing (Yawner, could you please test it again at area51?)
- added users activity load setting
- some bugfixes - committed coding guidelines as they are at area51 - removed script_path (needs a close inspection later) - removed the need for server_name and server_port - able to define server port/name/protocol and force the user-defined server vars (very handy for proxy setups)
implementing permission roles
- copy permissions (adding groups) - copy permissions (adding forums) - checking proper groupadd/del settings - added intro page to permissions (to give an overview and quick links) - able to select forums + subforums, single forum, all groups, all users (permission screens)...
Changed url target method for BBcode help links and fixed undefined index bug
just preparing...
- overhauled search system - updated structure for search backend plugins - better result caching using ACM - search results no longer session restricted => link to them by copying the URL :) - in-topic search - indexing posts now uses search backend plugins...
Added grouping by user_id to the team leader list query
- sperate permissions from sessions - added some comments to the auth class for better understanding - revised some permission functions - added option to negate permission check by prefixing option with a ! (for example checking for !f_read returns true if user is not able to read forum)...
- fix query for obtaining usernames beginning with a character and additionally searching for other criterias (produced a join not very healthy to the database - not the correct where statement is used)
Changed ONLINE_STATUS flag to S_ONLINE for consistancy
Little tweaks for the members listing/profile page
Added rank_image_src template variable so it can be used with CSS. Also fixed some undeclared variables.
Third time around, it turns out that the code where I made that mistake initially is completely unneeded since you won't get to this point if the user is anonymous (or a bot) anyway
poster_id does not exist (anonymous should be not present too)
Expose the warning level and user notes in appropriate places (assuming the user has the correct permissions)
A few minor bug fixes to the view profile page
- some SQL:2003 changes (basicly joins, mysql5 is sql:2003 compliant in strict mode now) - postgresql not supporting this standard. :/ - acp changes
- session changes
Fix for bug 73, invalid link under PM icon in memberlist/leaders
- add ability to limit search to groups
- memberlist changes
- some fixes here and there
- Documentation related changes - added resend activation email dialog - fixed issue in session code - log failed/successful admin re-authentication/login - fixed simple forum dropdown box (used in mcp and posting)
- first try to break things...
put user into appropiate group after activating his account
- fix serious bug (not updating topic/post count), i do not know why this slipped through and no one noticed... :) Maybe only i, lately i was performing very badly, had a few flaws, need to update myself to a stable version...
BBCode enabled profile fields, removed field_name from profile fields, fixed some uninitialised variable issues, some small conversion issues
- removed unnecessary pm options - added one option to clearly define email visibility
Censor topic name, signature, occupation, interests and location
Fix profile msn contact link
- minor fixes
- only small fixes to the memberlist
- more updates, mostly bugfixes to the bbcode parser - changed current_user in sessions (please review) - give more flexibility to style authors in regard to the pagination elements - profile fields updates (included a sample constuct into viewtopic_body.html - have to be documented extensivly)...
- re-enable polls (user is now able to decide if users are able to change votes if this feature is enabled within the given forum)
my turn to break the forum (and at least pm's are no longer working - will not last long). HARRRR
widdle
This is a mass commit ... expect trouble! Changes made here are primarily to how login is handled, schema changes necessary!
- removing karma
- fix link to PM (composing message)
- fork/copy topic - resync topics - possible to show only reported posts in topic_view - view reports in post details - mcp_queue (show unapproved items)
- added splitting of topics to mcp - added merging of posts to mcp - fixed parsing of acl_getf results - adjusted tracking code for important announcements (seems to work now)
- remove output buffering options from download.php (not needed anymore) - optimized viewtopic.php a little bit - removed the create_function (was consuming too much memory) from viewtopic - check for manually added convert[.exe] program name to imagemagick path in admin_attachments...
- forum rules + link to forum rules - three new (tiny) functions added to functions_posting responsible for handling text with bbcode/smilies/urls, use them at items all over across phpbb... - some bugfixes within admin_forums and other files - new admin_board layout (much safer, security wise)
only display those forums the user is able to read in.
fix some issues with oop, fixing small bugs and prepare the next steps... NOTE TO DEVS: have a look at adm/admin_board.php (new config layout)
- put consoring and smilie processing into functions (we use them all over the place) for better changing and consistency. - changed docs/AUTHORS to reflect the recent code re-use in functions_messenger.php - pleasing the users a little bit more by using table constants. :D...
use of correct config var
Update for new karma image location/creation
Remove need for session_ids for "allowed" bots, dump user_founder/user_active in favour of user_type, new user_type, USER_IGNORE
Updated the various "users of emailer", fixed issue(!) of jabber using the email address as the uid, blah fixes, blah, blah di blah yakety smackety
Let's break lots of things
Add "Add Friend" to viewprofile
oops, forgot to commit this earlier ... update for search author
hhmm
Updates mainly for removal of extension + header comment ... moved some aspects of ucp around, further work to be done on these areas ... not commiting search for time being
Various bits and pieces ... this isn't really what I wanted M-2 to look like but hum ho
Re-arrange auth and setup calls ... needs to be repeated for all major scripts
Missing sprintf
Further additions to memberslist modes, Jabber support, finally "fixed up" other IM client support, a little messy in places and lacking any permission checking for IM
A few minor updates
Default rank images directory
Incorrect avatar dimensions
Majority are UCP related updates ... avatars should now work, aside from gallery, fixed a few other issues, updated schema/basic
Avatar preferencial display here too
email topic, minor other changes, removed updating of parent forums upon posting (handled by functions_display)
page header/footer become functions, forum passwords (I know, I know but it appears a popular feature for some reason ... inclusion not yet set in concrete nor complete), various bug fixes (and no doubt new bugs).
Various changes, and tests ... marking/tracking is not complete ... tinkering, changing, etc. still to be done ... it's just I've made numerous and various changes to different files so a commit really is due
bbcode parse signatures
Update email form inline with emailer changes
Re-introduce sorting by rank ... note that only normal ranks are actively sorted. Special ranks are listed first no matter what the sort order.
Enable/disable searching ... note that user searching is always enabled for admins at this time (for ACP functionality ... this could be pared down to only those functions requiring username input)
Various updates
Output total posts/topics
Update following move of post count incrementation checks to permissions
Moved login procedure to a function enabling "inline" login links ... no more "messy" redirects ... install will be broken for now, at least when it comes to redirecting after completion. Moved "front-end" login to ucp.php
oops, the idea of hidden groups is that you cannot see who is a member ... duh
Various additions and fixes
Email via memberslist
Additional info for profiles
Moved profile.php to ucp.php. ucp is really really broken right now, don't even think about trying to use it.
Re-activated user search
Changed $board_config to $config, more posting "stuff", altered polling code in viewtopic and loads of new problems, poor coding, etc. created :)
Mostly changes to turn userdata into user->data, lang into user->lang + bitstring 2nd format + inheritance for permission admin and various other updates/fixes/changes ... note that user->lang & user->theme isn't final
Permission related updates ... is still not final but is getting there ... faster than British Rail too
Well, here are all my changes ... don't blame me if things break :D
More session changes to accomodate ACL_PERMIT/PREVENT ...
More changes ... switched away from prefetch for now ...
Updates for permissions, sessions, lots of things ... note that many things do_not_work now ... I'm commiting them to stop people complaining about my holding on to everything :) There is no update script at present for all these changes, you'll have to work out what's needed yourselves till I finish various things
pre-freeze on main templates, various bug fixes (highlighting search results, various search related issues, blah blah). These updates need thorough checking, quickly
Loads'a changes including fix for security issue, thanks to Matthijs for checking this out and confirming
Remove extra session var in session_pagestart
Gave the row number thing a more useful name ...
Added row numbers to memberslist (to check out how you're ranked with # of posts ;)
Fix dopey errors
Fix bug #504383
Fix bug #496166, removed sort_order since for top_ten it makes no real sense ... bet we'll get comments about this ...
Various updates + admin viewing of email addresses
Missed a ['From'] -> ['Location'] change
A 'not quite a Pauls up' + short date format
Mainly language updates but some bug fixes too
Added admin enabling of email form
Email form - free with purchase of any two other items
Various changes to location redirection ... please note the format and name changes
Altered layout of phpbb_config table
Fixed bug #459427
Re-added GPL disclaimers
Modified header comments
More compliance ... it never ends
Template config system, store relevant config stuff here
Changes to include location + some other misc stuff
More user fields available for memberslist template plus graphic changes
Small change to user website url creation
Updated sorting methods
Did some work converting lang file stuff to new format
Additional page info sent to templates
Initial SQL updates complete
Blah, parse error..
Re-added the error message and query echo to DEBUG error message PLEASE do not remove it, it is very helpfull when debugging errors
Fixed various errors, added issets, removed unneeded sql error messages
Fixed stupid windows carriage returns... Fixed pagination
More work on memberlist
Memberlist working. Pagination seems to have problems. Might be generate_pagination code...