phpBB

Copy 3.0.x branch to trunk

Fix Bug #51375 - Do not show QR in closed topics/forums
Authorised by: AcydBurn

Do not take edit post time into account for determining permission to delete last post in topic. (Bug #48615)

Better tracking of global announcements
Authorised by: AcydBurn

we are not supposed to know that yet

ok, i am very sorry, but this needs to be fixed.
Generally, our config table is not really suited for holding large datasets. Because feed settings for the forums to enable news feeds and excluded forums rely on the forums itself we have decided to introduce a forum_options table where custom options can be stored....

Fix bug #15729 - Global announcements marked as read if all new topics in forum are viewed
Authorised by: AcydBurn

Apply locale-independent basename() to attachment filenames. New function added: utf8_basename(). (Bug #43335 - Patch by ocean=Yohsuke)

QR changes to let the options actually work (we use checkboxes and isset())

fix r9775

Authorised by: AcydBurn

#47725

And check for permissions...

this is very much work in progress; please feel free to improve markup, usability and to introduce possible further settings (per forum, per user)

Fix a regression introduced in r9470 #45895

#44875

Force full date on print view (Bug #40355)

#43595 - we should also check for existing classes and use include instead of include_once (of course)

- Add indicator to be used in code if session was created (user visits the site for the first time)
- Correctly count topic views for guests visiting the website the first time by entering the topic directly (Bug #43445)

Bug #39735 - force full date on bump message

Only display special ranks to guests; no longer display normal ranks for guests (Bug #36735)
[a bit ugly, but retains backward compatibility]

Round the displayed percentages in polls. #32375

nitpick alarm. ;)

Display assigned rank/avatar for guests. (Bug #19155)

Stop search bots incrementing topic views. #32675
Use correct link for post author search. #32595
Insert missing space. #32315

#31185

corrected link for searching post author's other posts [Bug #26455]

#26605

One commit for those fixes having a very tiny impact (mostly only whitespaces or forgotten spans, etc.)
Although i somehow mistakingly got #20445 and #15249 into it. :/

Removing s_watching_img from watch_topic_forum() function (Bug #20445)
Changing order for post review if more than one post affected (Bug #15249)...

This commit was manufactured by cvs2svn to create branch 'phpBB-3_0_0'.

'1' might not have been a good choice

- Display "Return to" links on unwritable forums [Bug #14824]

some fixes. :P
- language authors may review their email template files...

- BBCode parsing order should ALWAYS be censor_text(), bbcode_secon_pass(), bbcode_nl2br(), smiley_text(), parse_attachments()
- using \r on custom bbcodes to allow line breaks [Bug #10758]

some bugs fixed

remove the need for filesorting

do not get too excited

try to normalize everything...

a bunch of fixes

Changing the behaviour of the hideonline permission.

Test the current setting before altering the memory limit during install(Bug #12195)

And another language var.

we included a check for getimagesize() existance... now we again can suppress notices while running this function.

fixing some bugs
changed the way we are handling bookmarks. No order_id required, really! Order by last post time as suggested by BartVB.

- * wildcard in a search query should cause \w+ in highlighting, not \w* [Bug #10031]
- display a warning that the search index is not converted from phpBB2 to phpBB3 [Bug #9761]
- forgot to add : to reg_name when deleting userinfo from the url regex constructor [Bug #9868]...

- m_warn is no longer a local moderation permission
- magic urls should properly use html entities
- speed up posting on big boards, MAX query can be simplified a lot in certain cases
- user IP list should be labelled with "Other users" [Bug #9707]

checking in some fixes... also added "previous/next pm in history" links to prosilvers private message view; dhn, you may want to have a look at the placement. :)

- urlencoded usernames don't need htmlspecialchars [Bug #8794]
- fulltext_mysql still used synonyms/ignore words [Bug #5405]
- merge tool extend to allow merging complete topics via quickmod and mcp_forum [Bug #5293]
- renamed "fork" to "copy" (was already called "copy" in some places)...

#5292

nice template variable to have

fixing some bugs
more mcp links for easier moderating different aspects (all, forum, topic)
i may have introduced new bugs with this commit due to me having fixed some things weeks ago and some code changed in between - please report if you see something not working as expected.

- fix some oddities (doubled spaces for example)
- changed the way make_forum_select() is returning the forum list - now including skipped forums but being disabled. This should make identifying the correct forum much more easier.
- Changed some permission namings based on suggestions by the community...

#6944

- made sure ranks are displayed correctly (used RANK instead of RANK_TITLE)
- #6630
- hide a few links from bots (forum/topic marking, memberlist, post/reply/quote/edit/etc. buttons) [#6354]
- #5698

some fixes today
- most important change is the consolidation of the display attachment functions; merging them together to have one function we need to call.

fix for bug #5586

rather large update, most important things done:
- implemented provided patch/diff file for bug #5350 (Highway of Life) with some tiny changes and alterations
- more username/colour changes/fixes
- added a note about PM rule-dependant message removals so the user is not wondering too much if he can't remember his rules. :)...

- a handful of mcp fixed, the most important one is the change for check_ids() - it is now supporting ids from more than one forum too, making it possible to use some mcp features as designed initially. We really need to get our moderator team testing the mcp extensively....

ok, change from doing the same logic all over again we call a function to do it for us. Also allow template designers to choose which method to use by just adding a fully compiled username string (profile link + user colour). This commit may introduce problems.

trimmed the highlight regex

- adjust unread query a bit to cope with large topics (thanks bart!)
- fixing some bugs
- more username_clean work

he braces style is deprecated as of PHP 6

- no more encoding mixture, say hello to UTF-8 (I'll add a validation solution for PHP 4.3.3/4 ASAP) [side effect: fixes Bug #3762]
- take local server time into consideration for birthday/age calculation
- faster active topic search
- allow changing active topic time frame [Bug #4150]...

- fixing profile bug
- adjusting acl_gets calls (they are or'd - make sure they get checked correctly based on the situation)
- automatically assign the u_download and u_search permission to the guest group

- some bugfixes
- using E_USER_WARNING if an error occurred within the ACP (sadly not able to use it as a default for trigger_error - it seems to be hardcoded in PHP)

Poll ended at....

so.... what does this thing do?

well, the super fast, ultra efficient, massively huge BBCode handling system was implemented differently on each DBMS. Although this provided the best performance, the solution was a bit hacky.

So what does this new thing do? We use base64 encoding to make everything nice and shiny, it turns into nice, safe characters that we can just jam into varchars on essentially any database. This has two implications: we must decode every bitfield we get AND we have slightly fewer IDs to work with. It goes down from 2040 BBCodes to 1512. We lose like a quarter of them :P...

- load tracking updates. Need to be tested on a clean installation too - at the moment only tiny quirks are noticed at area51.
- reported bugs fixed

- fixed some bugs
- made imageset naming more consistent
- updated every schema to be consistent and also fixed it (every db should install fine now)
-

- fixed the age calculation (note: turn on your brain before commiting something like this the next time) [Bug #3337]
- removed the split_words array, introduced an enforced search_query
- the forum used for global topics in the search is now a forum, and no longer a category [Bug #2561]...

• Error handling on bans
• Missing language strings
• Grammatical correction in viewtopic (singular vs plural)

fix the schema files as well as other tiny bugs.

fix some bugs... again. :)

some bugfixes

- add additional auth check to the permission roles modules
- added new function to return globally used expressions (get_preg_expression($mode)). This should be very helpful in getting wide spread similar checks (regular expressions) to one place reducing the risk of forgetting to change every location if you fix one. ;) We will add additional ones later, at the moment only the email check is retrieved......

time to squash some bugs

some bugfixes

- fixed a few bugs
- added user_add() function
- check posted images ([img]) for same domain/scipt and php files
- auth_api.html updated to the coding guidelines look&feel
- introduced ability to force non page-updates (cron is using it)
- correctly resend coppa email

Fix the ability to report/view reports and warn in global announcements

some adjustments
nils: please have a look at the @todo comment in mcp_queue.php

counting on primary key should be slightly faster...

no longer needed because we handle shadow topics as "always read" (not to be misreaded as "original topic")

- fixing a few tiny bugs
- added new function to (re)apply sids where needed (login and mcp quickmod) - #1829

- Split the viewtopic query into two pieces. We gain speed by avoiding the need to GROUP BY/ORDER BY the selected elements. We also gain cross-DB compliance. Yay!

- some adjustements for phpdocumentor

fix bug #1549

Viewtopic:
- PGSQL friendly

New Install:
- file_get_contents

New/Old Install:
- remove remarks for PGSQL, some versions don't like 'em
- fixed the regex in remove_remarks
- rewrote split_sql_file

Schema:
- removed explicit inserts, replaced with implicit inserts. This is more friendly to our non auto incrementing friends. (One set of data is not fixed yet, the modules table)...

say hello to role descriptions, role ordering and tooltips on role selects

To all people having their bug status set to fixed: SF pserver CVS access is currently down, therefore the snapshots are still out of date.

- fix a bunch of bugs
- <!-- $Id$ --> is no longer allowed in template (.html) files
- changed layout of private message screens (folders are menu items)...

- extended session_page and user_lastpage to hold a maximum of 200 chars (instead of 100) - session_page gets truncated to 200 chars
- streamlined the process of generating text with bbcode/smilies/urls (forum rules, forum descriptions, group descriptions at the moment)...

- hopefully fixed inactive create forum input field + button for safari 2.0.2 (floating issue?)
- updated format_date calls (fixed ancient calls)
- fixed newest username setting for activating users through the admin panel

Retrieve user_warning count in case a template designer wishes to display it on this page

- adding ability to assign moderator specific ban options
- fixing destroying of sql caches
- fixing referencing of sql cached queries if more than one are active on one page
- other fixes

Weee! My turn to bug things up :D

- A moved topic has two forum_ids, we must update the tracking info on the "fake" forum and the "real" forum.
- Welcome back to register_globals! :P

- some bugfixes
- committed coding guidelines as they are at area51
- removed script_path (needs a close inspection later)
- removed the need for server_name and server_port
- able to define server port/name/protocol and force the user-defined server vars (very handy for proxy setups)

Fixed an an undefined index issue when a topic was bumped by someone who hadn't posted in the topic (like an admin). Still not ideal as it won't state who bumped the topic in this case.

- fix two very annoying bugs
(1) mark topic read behaving incorrectly if editing posts (the topic gets marked unread)
(2) jump to wrong page number (viewtopic with post id) if descending post ordering is set

Updated references to posts to be #p[post_id] rather than #[post_id] since it is against the W3C spec to have the id="" attribute starting with a number

- Polls work! Hooray for polls!

A few fixes and a new online_status template variable

Added rank_image_src template variable so it can be used with CSS. Also fixed some undeclared variables.

Initial commit of files related to the warning system
As the comments suggest, it's not finished but I'm getting it in before
I do things to my machine

MCP again, forgot these two earlier :-)

- session changes

- checkin fixed viewtopic (just forgot to check it in, been applied to area51 after 2.0.16 release)

- related to the updated topic tracking code

- added updated coding guidelines
- introduced is_registered and is_bot flags for correct determinition of guest/registered/bot users
- changed bot code to act on useragent || ip

- first try to break things...

Display poll results after voting even if you can change said vote

tiny addition

- bugfixes
- default sort options for posts too
- adjusted format_date to remove the (time intensive) preg_ calls
- temporary style.php code.

- letting urls work again, fixing [code] breakage on urls, corrected magic_url to be able to parse urls at the beginning/end of bbcode blocks
- fixed "edited by" message.

- minor fixes

- load_moderators taken into account at index.php
- added S_UNREAD_TOPIC to viewforum
- changed S_UNREAD to S_UNREAD_POST in viewtopic

- re-enable polls (user is now able to decide if users are able to change votes if this feature is enabled within the given forum)

Danger Wil Robinson Danger! Paul is commiting files! Danger

This is a mass commit ... expect trouble! Changes made here are primarily to how login is handled, schema changes necessary!

- remove avatar class
- added S_FIRST_UNREAD and S_UNREAD
- removed U_POST_ID

- approve/disapprove posts/topics
- changed mcp_front to be more moderator friendly
- able to change the forum in mcp_queue (for moderators moderating more than one forum)

- fixed permissions for mcp (global permission settings are false if user is only able to moderate one to x forums)
- determine permission settings for submodules
- further approve/disapprove work (approve_details added)

- remove output buffering options from download.php (not needed anymore)
- optimized viewtopic.php a little bit
- removed the create_function (was consuming too much memory) from viewtopic
- check for manually added convert[.exe] program name to imagemagick path in admin_attachments...

- fixed notification redirection
- added SID to ucp redirects

- added delete cookies link
- fixed global announcement links in viewforum
- do not display redirects in link forums as posts in forum overview

fixed last edited by
tryed to fix mark read code
other small fixes...
added (commented out) custom profile fields template support

fix some issues with oop, fixing small bugs and prepare the next steps...
NOTE TO DEVS: have a look at adm/admin_board.php (new config layout)

- check for array [lang]
- admin_forums delete routine updated
- added extension groups per forum

splitted language files

the display code for inline attachments, isn't it cute? ;)

fixed: smilie parsing in signatures
added: edit notes

Update for new karma image location/creation

If you don't know what it is, you shouldn't be reading this...
(query split as discussed in dev forum)
Fixed: board's URL in printer mode

new permissions, merged attachment tables (the intended purpose of two tables is no longer valid), attachment updates along the merging...

Note: please merge your attachment tables (develop dir).

oops... not realised the config name change locally. :/
added logging of bump action

Let's break lots of things

Change in format of module db data, add zebra, many things probably "damaged goods" for now ... don't panic Mr. Mainwaring, don't panic

Updates mainly for removal of extension + header comment ... moved some aspects of ucp around, further work to be done on these areas ... not commiting search for time being

Changing of votes ... possible new icons for "new votes since last view" in viewforum

now display_notice is working as expected.

The moron has left the building

Various updates

a few fixes

Global announcements ... sort of work ... well they seem to, need to look at possbility of splitting topics table in two

Fixed signatures showing up no matter if you wanted it or not

added: download notice for people unable to see files attached to posts
changed: put attachment display into a function now called by posting preview and viewtopic (functions_display.php)
fixed: small fix in posting routines, cleanups...

Default rank images directory

Majority are UCP related updates ... avatars should now work, aside from gallery, fixed a few other issues, updated schema/basic

Wasn't stripping slashes from the cookies ... that will account for some of the erroneous mark read, nothing changes issues. Add name="" to image generation ... for "on" event handlers, etc.

Only set start = 0 when first sorting ... else it screws everything up :)

Enable view limiting functions ... Ashe, not sure if this is compatible with your thinking for bbcode but it seems the "logical" way to handle disabling of bbcode/flash in this manner. Fixed issue with automatic url handling of local links

a few updates, added #539865 and #694413.

email topic, minor other changes, removed updating of parent forums upon posting (handled by functions_display)

page header/footer become functions, forum passwords (I know, I know but it appears a popular feature for some reason ... inclusion not yet set in concrete nor complete), various bug fixes (and no doubt new bugs).

Various updates, forum links, "improve" forum management, cleanups, blah blah, note the schema changes, note also that forum management may misbehave ... reports on wrong doings are welcome ... seem to be having problems with some mcp functions under apache/win32

further work on the attachment panel... and see how plain those icons are... these are the correct ones to rip ;)
Hopefully someone will make some nice upload icons. :)

Fixed some undefined variables (my bad ;))

Re-enabled polling ... includes option of multiple choice polling, indication of option voted for, etc. ... preliminary implementation, various things need finishing

use only one query for updating download counts.

make_normal fixed (was making topics sticky)
quickmod's "delete topic" fixed

viewtopic v1.260: less memory than 1.259 and still 5% faster than v1.256

- BBCode now only loaded if necessary
- now obtains the whole post rowset before actual processing apply
- put all user_cache definitions together
- topic_view is only updated once per topic, not at every page

fixed delete post bug, use extension cache while posting, fix download counter for images

BBCode parser + decoder, missing some tags and mildly broken at this time

IP information moved to Post Details

Fixed the quickmod type-changing tools for global announcements

Re-enable avatar display

Modes renamed - easier to remember

icon name change

Output total posts/topics

Moved login procedure to a function enabling "inline" login links ... no more "messy" redirects ... install will be broken for now, at least when it comes to redirecting after completion. Moved "front-end" login to ucp.php

Added indicators for reported and/or unapproved items. Note that moderators with m_approve permission can now read unapproved topics and posts normally.

Switched up $total and $offset as per MySQL manual

Icon updates

Un-b0rked ACL options caching, small general fixes

Initial Lastread support. Mind the schema and config changes\!

didn't urlencode highlighted url data ... tut tut

Got bored so added print topic output view

Cache moderator names? Output moderators for all forums in viewforum. Alter a few things in templates

viewforum queries update + a couple of bugfixes.

Various, typically posting related updates

Smilies enabled ... note this is not necessarily final ...

Changed $board_config to $config, more posting "stuff", altered polling code in viewtopic and loads of new problems, poor coding, etc. created :)

Mostly changes to turn userdata into user->data, lang into user->lang + bitstring 2nd format + inheritance for permission admin and various other updates/fixes/changes ... note that user->lang & user->theme isn't final

Permission related updates ... is still not final but is getting there ... faster than British Rail too

Forum/Topic marking updates

More session changes to accomodate ACL_PERMIT/PREVENT ...

More re-arrangements

Various changes

Updates for permissions, sessions, lots of things ... note that many things do_not_work now ... I'm commiting them to stop people complaining about my holding on to everything :) There is no update script at present for all these changes, you'll have to work out what's needed yourselves till I finish various things

pre-freeze on main templates, various bug fixes (highlighting search results, various search related issues, blah blah). These updates need thorough checking, quickly

Various bug fixes, polls, Guest vs. Anonymous, quoting guests

Fix error when view is set to somethng unexpected

Loads'a changes including fix for security issue, thanks to Matthijs for checking this out and confirming

oops, removed preg_quote but left \* in place ... bug #516545

No idea if this is as desired but 'topic link' now points to the current page

Add a login redirect for users not logged in who attempt to visit restricted forums ... also shows a forum/post doesn't exist for hidden forums/topics/posts if user is logged in but not authed to view them

Okay, let's give this highlighting preg_ a shot ...

Fixed bug #512194

Fix various var not set warnings ... many thanks go to The Horta for pointing out and offering fixes for many of these

Fix global disallow sig still allows old sigs to display bug #501162

Fix bug #504604

Fix bug #501353

Added alt and title tags to rank image output

Moderator+ viewing of email addresses

Separate sig completely from message

Another lastvisit name change missed

Fix view newest post error + missing mini post icon in posting preview

Remove guest user topic tracking via cookies, update viewtopic to re-fix highlighting of search terms, add lang capability to images, various other issues, removed remote avatar size reduction

Small change to make HTML source of viewtopic more readable

bug #488067: no, preg_quote() didn't always have 2 args.

A 'not quite a Pauls up' + short date format

Finally moved the bbcode_uid from posts to posts_text, DON'T FORGET TO RUN THE CONVERT SCRIPT IN /develop/ !!

Various updates

More lang cleanups

Mainly language updates but some bug fixes too

Lang related update for topic watch

Email form - free with purchase of any two other items

Corrected for space within highlighted words, this is the version running on the main site

Fixed bug #478505 also added code to retain highlight though pagination on viewtopic

Ooops, forgot to clear edited by output for subsequent posts

Minor change to message output when no posts exist

More changes for global announcements. They no longer require the mode to be set (it works without), posting.php has been updated to reflect replies to announcements in ALL forums, and a admin page for announcements (global) has been added, although it can only link to pages with the true forum and auth permissions. A more refined version will be coming soon

Various changes to location redirection ... please note the format and name changes

Preliminary avatar gallery support

Minor updates and fixes

Another file that didn't commit for some reason + change to subSilver body_text colour

topic watch/forum/topic read now cause a message to be displayed, changed profile ICQ for subSilver, various other changes

Slight mod to template name check for subSilver ICQ output ... must alter this

Updated moderator panel, particularly move/delete topic

Altered layout of phpbb_config table

Fixed bug #459427

Numerous updates and additions for polling and assorted fixes ... or bugs, whichever they turn out to be

Re-added GPL disclaimer

ODBC only returning associative fields so modded next/prev topic code appropriately

Various updates for templates

Just some jiggling

Wildcard for censored words now works correctly

Word censoring, first part. Does not support wildcards yet but that's coming in the next step.

Topic notification ... initial stuff

Code added to get around double htmlspecialchar stuff + some of my stuff looks to allow HTML even when off, removed

More varied changes, again hopefully not breaking anything

Beginnings of the forum managament code (no functionality yet). Also a bit of a fix to view topic so it dosan't screw up when HTML is turned off. Still needs work, HTML works in [quote] tags... havn't tracked it down yet. Nate should look at it!

New split icon + tidied up other mod topic icons

Still seems to be pagination problem, I dont have it so what havent I committed ...

Removed unrequired admin checks, modded moderator query, jiggled rank/avatar image stuff

Template config system, store relevant config stuff here

Added a text link to split topic interface. Needs a button

Changes to include location + some other misc stuff

Lots of checking in posting + delete now works

is_first_post was missing from the edit button for some reason..

Finished lang switchover and various updates

Minor irritation with ranks fixed

Fixes and updates

Started on moderator control panel code. Main layout is started, no functionality yet

Spot the mess ups

Switched forum_auth to the forums table

Posting preview done, ability for anonymous users to post with a username

Forum level annoucements and sticky topics are done.
Added topic_type field to the topics database in order to handle ordering. Would have used topic_status but that would have messed up the ordering when topics were locked

Auth now returns a type allowing for more meaningful failure messa ges

Fixed reply w/ quote link (functionality still dosan't exist for it though)
Fixed bug with being able to modifiy someone elses profile
Fixed bug with BBCode not working
Fixed bug with validate_username causing editing of profile to fail (only checks if you actually change you name now)

Allow restricted view forums

Added post subject to postgres schema. Updated viewtopic query to include group by for the auth forums table when linking after posting

Auth Stage-1 goes in

Additional page info sent to templates

More work on posting. Editing now works. Also replies can have subjects.

Users sigs display correctly.
Some minor improvments to posting...still LOTS to be done

Took out some debugging code

Freeking windows carriage returns...someone tell me how to fix UltraEdit so it does do this..

Introduced the $operator variable and cut the amount of SQL statments in half :)

Initial SQL updates complete

Send post id to template for possible anchor name ref

Moved config, images vars to arrays and various other fixes

Updated to use create_date rather than date

error_die changes and various bug fixes to files

Ranks now work

Added make_clickable()

New template system. Lots of merging conflicts, so let nate know if he broke stuff.

Moved include files

fixed little bug in viewtopic

Allow for legacy topic_id as url param

Started on posting.php, got the logic done for displaying the new topic form

Viewtopic mostly done. Need private forum stuff, pagination, and some SQL tweaks